-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
Add doc(plugins), doc(passes), etc. to INVALID_DOC_ATTRIBUTES #82824
Copy link
Copy link
Closed
Labels
A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.Area: Lints (warnings about flaws in source code) such as unused_mut.C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.C-future-incompatibilityCategory: Future-incompatibility lintsCategory: Future-incompatibility lintsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.Area: Lints (warnings about flaws in source code) such as unused_mut.C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.C-future-incompatibilityCategory: Future-incompatibility lintsCategory: Future-incompatibility lintsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
I think we should make
doc(plugins),doc(passes), and any similar attributes hard errors.doc(plugins)is a no-op, and I expect there are almost no people using it. I'm not sure about the status ofdoc(passes), but I think it's been deprecated for several years. There are probably other similar attributes that should become hard errors, so please comment if you know of more.I'm not sure if we need to wait to do this in the 2021 Edition since these attributes are likely not used at all, but I'm tagging this issue as
lang-team-202x-editionand will note this in the#edition 2021Zulip stream in case it has to happen across an edition boundary.cc #82651, #44136
cc @rust-lang/rustdoc