-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
Splitting up rustc_typeck::check::fn_ctxt::FnCtxt #77085
Copy link
Copy link
Closed
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Branching this from #60302.
Originally,
mod.rsforrustc_typeck::checkwas over 6,000 lines. I was able to push that to around 1,100 lines (PR #76906).However, in the process, I found that
FnCtxtwas rather long, with 13 fields in the struct and some rather longimpls attached. The sum total is 3,200 lines, which effectively means that the// ignore-tidy-filelengthcomment was moved frommod.rstofn_ctxt.rs.The goal of this issue is to
fn_ctxt.rssmaller, at minimum less than 3,000 lines byUnknowns to solve:
FnCtxtSolution: Cannot do