-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
Enforce min_const_fn by default in staged_api with opt-out #64285
Copy link
Copy link
Closed
Labels
A-attributesArea: Attributes (`#[…]`, `#![…]`)Area: Attributes (`#[…]`, `#![…]`)A-const-evalArea: Constant evaluation, covers all const contexts (static, const fn, ...)Area: Constant evaluation, covers all const contexts (static, const fn, ...)A-stabilityArea: `#[stable]`, `#[unstable]` etc.Area: `#[stable]`, `#[unstable]` etc.C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.P-mediumMedium priorityMedium priorityT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Labels
A-attributesArea: Attributes (`#[…]`, `#![…]`)Area: Attributes (`#[…]`, `#![…]`)A-const-evalArea: Constant evaluation, covers all const contexts (static, const fn, ...)Area: Constant evaluation, covers all const contexts (static, const fn, ...)A-stabilityArea: `#[stable]`, `#[unstable]` etc.Area: `#[stable]`, `#[unstable]` etc.C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.P-mediumMedium priorityMedium priorityT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
We want to switch to a scheme where everything inside the standard library requires
min_const_fnby default. If an additional#[rustc_not_min_const_fn]is present, then the function will be uncallable from anymin_const_fn.It's also important to note that a function
#[rustc_const_unstable(feature "foo")] const fn bar() {}without#[rustc_not_min_const_fn]should a) enforce that that the function ismin_const_fneven without the feature gate active, b) not be callable asmin_const_fnwithout the the feature gate active.Relevant code exists in:
Context: Centril@93ad760#r34994115 (also see my branch master...Centril:stabilize-vec-new-const)
Conversation replayed (keep-safe):
@oli-obk:
@Centril:
@oli-obk: