-
Notifications
You must be signed in to change notification settings - Fork 74
Use annotate-snippets as the default emitter #947
Copy link
Copy link
Closed
Labels
T-compilerAdd this label so rfcbot knows to poll the compiler teamAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was acceptedA major change proposal that was accepted
Metadata
Metadata
Assignees
Labels
T-compilerAdd this label so rfcbot knows to poll the compiler teamAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was acceptedA major change proposal that was accepted
Type
Fields
Give feedbackNo fields configured for issues without a type.
Proposal
annotate-snippetshas been the default emitter on nightly for nearly a month (2025-11-07), and has proven to be capable of being Rust's default diagnostic emitter. In the time that it has been on nightly, there have only been four issues related to it:annotate-snippets. This issue was fixed by #149321Given the good track record so far, I would like to propose that
annotate-snippetsbe used as the default emitter on stable. I do not foresee there being many more issues, mainly becauseannotate-snippetsshares much of its internals with Rust's current emitter. If any more problems do come up, they would be at worst an ICE, and would more than likely happen during error reporting, when the compilation is probably failing anyway.Note: This will miss the upcoming branch for
1.93.0, which means it will get another ~6 weeks of testing on nightlyMentors or Reviewers
I (@Muscraft) am currently maintaining
annotate-snippetsand will happily handle any changes/fixes that need to be made.Process
The main points of the Major Change Process are as follows:
@rustbot secondor kickoff a team FCP with@rfcbot fcp $RESOLUTION.You can read more about Major Change Proposals on forge.