chore: release 0.9.0#234
Conversation
There was a problem hiding this comment.
Pull request overview
Release bump updating the Rust crate and published Node package versions, plus lockfile changes to reflect updated workspace state for the npm release process.
Changes:
- Bump crate
rspack_resolverversion to0.9.0(and updateCargo.lockaccordingly). - Bump npm package
@rspack/resolverversion to0.5.0. - Update
pnpm-lock.yaml, including new workspace importer entries underbindings/*.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pnpm-lock.yaml | Adds workspace importer entries for per-platform binding packages (and a wasm dependency entry). |
| npm/package.json | Bumps published npm package version to 0.5.0. |
| Cargo.toml | Bumps Rust crate version to 0.9.0. |
| Cargo.lock | Updates locked package version to 0.9.0. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merging this PR will degrade performance by 4.2%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | resolver[pnp resolve] |
8.4 KB | 8.8 KB | -4.07% |
| ❌ | Memory | resolver[multi-thread] |
11.1 MB | 11.6 MB | -4.33% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing release/0.9.0 (115fa0b) with main (6381639)
|
@codspeedbot explain the memory regression |
|
You’re seeing a small reported memory regression (~4.2%), but the CodSpeed report itself strongly suggests this is likely measurement/environment noise rather than a real code-caused regression. What the report is actually sayingFrom the PR comments:
That warning matters a lot: CodSpeed is explicitly telling you the base and head benchmark runs may have happened on different runtime environments (machine/OS/libc/etc), which can shift allocator behavior and memory accounting enough to look like a few-percent regression. Why this is probably not a real regression in this PRThis PR appears to be a release/version bump PR (Cargo/npm version + lockfile updates), with no substantive resolver algorithm change described in the comments. Given that context, a memory shift can come from:
Practical interpretation
What to do next (quick path)
Commands/Checks I ran
No code changes were made, so no commit or PR creation was required. |
| bindings/darwin-arm64: {} | ||
|
|
||
| bindings/darwin-x64: {} | ||
|
|
||
| bindings/linux-arm64-gnu: {} | ||
|
|
||
| bindings/linux-arm64-musl: {} | ||
|
|
||
| bindings/linux-x64-gnu: {} | ||
|
|
||
| bindings/linux-x64-musl: {} | ||
|
|
||
| bindings/wasm32-wasi: | ||
| dependencies: | ||
| '@napi-rs/wasm-runtime': | ||
| specifier: ^1.1.1 | ||
| version: 1.1.4(@emnapi/core@1.10.0)(@emnapi/runtime@1.10.0) | ||
|
|
||
| bindings/win32-arm64-msvc: {} | ||
|
|
||
| bindings/win32-ia32-msvc: {} | ||
|
|
||
| bindings/win32-x64-msvc: {} | ||
|
|
crate: rspack-resolver@0.9.0
npm: @rspack/resolver@0.5.0