JSX preserve mode depends on ReactDOM

[dkirchhof]

While helping a user in the forum, we caught an compiler error in this situation:

• jsx preserve mode
• no ReactDOM as depdendency
• no custom jsx module
• (rescript 12.0.1)

I am not familiar with his, nor with any other use case, so I don't have a repo ready or the exact error message, but could reproduce it.

For reference: https://forum.rescript-lang.org/t/simple-way-to-convert-jsx-to-dom/7085/2

[nojaf]

Yes, it does. What JSX transform does is convert the

JsxRuntime.jsx("button", {
        children: "Click me",
        onClick: _evt => setCount(prev => prev + 1 | 0)
      }),

back to <button onClick={_evt => setCount(prev => prev + 1 | 0)}>{"Click me"}</button>.

So, we do expect everything to be in place to get at the point of regular JSX processing.
This means the dep on ReactDOM or a custom JSX module.

[dkirchhof]

So if it's intended to throw an error, we can close this issue. Maybe a small hint in the docs could help new devs.

[nojaf]

Happy to accept a PR here.

[dkirchhof]

Unfortunately, I don't know, where to start, so I can't help.