SortNamedParamRector is missing Attribute param

[VincentLanglet]

Bug Report

Subject	Details
Rector version	2.2.8

Minimal PHP Code Causing Issue

When using Rector\CodeQuality\Rector\FuncCall\SortNamedParamRector

Something like

#[SomeAttribute(
    foo: [
        new Bar(
            param2: 'foo',
            param1: 'bar',
        ),
   ]
)]

is correctly fixed to

#[SomeAttribute(
    foo: [
        new Bar(
            param1: 'foo',
            param2: 'bar',
        ),
   ]
)]

since param1, param2 are param from a constructor call.

But something like

#[SomeAttribute(param2: 'foo', param1: 'bar')]

was not reordered.

Expected Behaviour

#[SomeAttribute(param2: 'foo', param1: 'bar')]

should be fixed to

#[SomeAttribute(param1: 'bar', param2: 'foo')]

I dunno if you prefer to update Rector\CodeQuality\Rector\FuncCall\SortNamedParamRector or create a dedicated rule for Attribute.

[samsonasik]

Could you show the different use and expected at https://getrector.com/demo and https://3v4l.org ? Thank you.

[VincentLanglet]

Is it better with https://getrector.com/demo/ad29ec47-42cb-4513-891f-127dd7d2cb60 ?

#[MyAttribute(param2: 'foo', param1: 'bar')]

should be fixed too.

[samsonasik]

Attribute argument usage seems vary, as it based on AttributeGroup, I guess it seems ok as it is, I guess you can create custom rule for it for your use case.

[VincentLanglet]

Attribute argument usage seems vary, as it based on AttributeGroup

I'm not sure to understand this point ?
What do you mean by usage is vary ? And how it impact the fact that param could be ordered ?

[VincentLanglet]

I tried the implementation @samsonasik rectorphp/rector-src#7684 and it seems to work great with the existing rector rule.

[github-actions]

This issue has been automatically locked because it has been closed for 150 days. Please open a new issue if you have a similar problem.