Reprint int values

[Orest-Divintari]

Hi,

We have a rule in our codebase that we use to change integer value format from 1000 to 1_000 and to achieve that we use the following

  $argValue->setAttribute(AttributeKey::RAW_VALUE, $newValue);
   $argValue->setAttribute(AttributeKey::REPRINT_RAW_VALUE, true);
   $argValue->setAttribute(AttributeKey::ORIGINAL_NODE, null);

The code that checks if a re-print was requested though from what i see it is removed here

Could you please let me know if there is an alternative to it ? or is the functionality completely removed ?

I don't see this constant REPRINT_RAW_VALUE being used anywhere anymore

[samsonasik]

@Orest-Divintari I think you can achieve with coding standard tool for that, on php-cs-fixer https://cs.symfony.com/doc/rules/basic/numeric_literal_separator.html via PhpCsFixer\Fixer\Basic\NumericLiteralSeparatorFixer

[Orest-Divintari]

@Orest-Divintari I think you can achieve with coding standard tool for that, on php-cs-fixer https://cs.symfony.com/doc/rules/basic/numeric_literal_separator.html via PhpCsFixer\Fixer\Basic\NumericLiteralSeparatorFixer

Thanks for replying
Sorry I didn't use a good example of what we are trying to achieve

Here is our rule

Basically 1000 becomes 10_00

final class MoneyAmountRector extends AbstractRector
{
    /**
     * @return array<class-string<Node>>
     */
    #[Override]
    public function getNodeTypes() : array
    {
        return [StaticCall::class, New_::class];
    }

    #[Override]
    public function refactor(Node $node) : ?Node
    {
        if ( ! $node instanceof New_ && ! $node instanceof StaticCall) {
            return null;
        }

        if ( ! $node->class instanceof FullyQualified) {
            return null;
        }

        if ($node->class->toString() !== Money::class) {
            return null;
        }

        if ($node instanceof StaticCall) {
            if ( ! $node->name instanceof Identifier) {
                return null;
            }

            if (method_exists(Money::class, $node->name->name)) {
                return null;
            }
        }

        if ($node->args === []) {
            return null;
        }

        if ( ! $node->args[0] instanceof Arg) {
            return null;
        }

        $argValue = $node->args[0]->value;

        if ( ! $argValue instanceof LNumber) {
            return null;
        }

        if ($argValue->getAttribute(AttributeKey::KIND) !== LNumber::KIND_DEC) {
            return null;
        }

        $rawValue = $argValue->getAttribute('rawValue');

        if ( ! is_string($rawValue)) {
            return null;
        }

        $rawValue = str_replace('_', '', $rawValue);

        if (strlen($rawValue) <= 2) {
            return null;
        }

        $newValue = preg_replace('/(?<=\d)(?=(\d{3})*(\d{2})$)/', '_', $rawValue);

        if ($rawValue === $newValue) {
            return null;
        }

        $argValue->setAttribute(AttributeKey::RAW_VALUE, $newValue);
        $argValue->setAttribute(AttributeKey::REPRINT_RAW_VALUE, true);
        $argValue->setAttribute(AttributeKey::ORIGINAL_NODE, null);

        return $node;
    }
}

[TomasVotruba]

@Orest-Divintari Thanks for getting back. We had this workaround in our codebase for a long time and it was rather internal feature. Now we don't use it anymore, and try to push more bugs from our workaround directly to fix/feature in php-parser.

Saying that, this should be supported by php-parser itself. There might a better way, so I propose asking how to change value there.

I haven't tested it yet, but a new \PhpParser\Node\Scalar\Int_(...) node might help, instead of overriding value.

[github-actions]

This issue has been automatically locked because it has been closed for 150 days. Please open a new issue if you have a similar problem.