Parameters was swapped only for source

[afaibyshev]

Bug Report

I am updteing big legacy project ( 2000+ files)

AS results, have a look on changes for 1 class:
because of comment for method, it changed parameters... but code that use this class wasn't update.

As results i have a lot of changes code...

Subject	Details
Rector version	2.1.4

Minimal PHP Code Causing Issue

Expected Behaviour

[calebdw]

Rector doesn't use PHPStan collectors, so it's currently impossible for it to know all of the usages and replace them

[calebdw]

You can either:

1. refactor the order yourself using an LSP that can handle that change across the codebase
2. update $_params to also have a default value = []
3. remove the default value from $_mode
4. manually update all usages

[TomasVotruba]

As @calebdw explains, this is limit of this rule. It's goal to fix all the depraction of using default values before required values.
Another approach might be simply remove the defaults from these arguments, as they're always fliled anyway.

That would be maybe better change without breaking the code 🤔

[samsonasik]

see possible solution PR:

• [CodeQuality] Change behaviour of OptionalParametersAfterRequiredRector to fill null default value when previous param is optional rector-src#7222

[github-actions]

This issue has been automatically locked because it has been closed for 150 days. Please open a new issue if you have a similar problem.