From 7298996937199d28f0e62ba0a9e8a34341205dd9 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Fri, 1 May 2026 16:04:16 +0700 Subject: [PATCH 1/3] [CodeQuality] Skip union type on UseIdenticalOverEqualWithSameTypeRector --- .../Rector/Equal/UseIdenticalOverEqualWithSameTypeRector.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/rules/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector.php b/rules/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector.php index 3c8e87d016f..37f11bc21df 100644 --- a/rules/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector.php +++ b/rules/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector.php @@ -18,6 +18,7 @@ use PHPStan\Type\StringType; use PHPStan\Type\Type; use PHPStan\Type\TypeTraverser; +use PHPStan\Type\UnionType; use Rector\NodeTypeResolver\Node\AttributeKey; use Rector\Rector\AbstractRector; use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample; @@ -96,6 +97,10 @@ public function refactor(Node $node): ?Node return null; } + if ($normalizedLeftType instanceof UnionType) { + return null; + } + return $this->processIdenticalOrNotIdentical($node); } From af3151989080761932149b1f458809cbbdbe0e47 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Fri, 1 May 2026 16:04:20 +0700 Subject: [PATCH 2/3] [CodeQuality] Skip union type on UseIdenticalOverEqualWithSameTypeRector --- .../Fixture/skip_union.php.inc | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 rules-tests/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector/Fixture/skip_union.php.inc diff --git a/rules-tests/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector/Fixture/skip_union.php.inc b/rules-tests/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector/Fixture/skip_union.php.inc new file mode 100644 index 00000000000..83c5dde689a --- /dev/null +++ b/rules-tests/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector/Fixture/skip_union.php.inc @@ -0,0 +1,9 @@ + Date: Fri, 1 May 2026 16:09:01 +0700 Subject: [PATCH 3/3] trigger CI