From ee3546ecaa50ef7bdee8d37fcb45ec818b825331 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Wed, 1 Apr 2026 22:31:21 +0700 Subject: [PATCH 1/3] [CodingStyle] Skip by reference required params on call inside on ArrowFunctionDelegatingCallToFirstClassCallableRector --- .../Fixture/skip_with_reset.php.inc | 12 ++++++++++++ ...rrowFunctionAndClosureFirstClassCallableGuard.php | 9 +++++++++ 2 files changed, 21 insertions(+) create mode 100644 rules-tests/CodingStyle/Rector/ArrowFunction/ArrowFunctionDelegatingCallToFirstClassCallableRector/Fixture/skip_with_reset.php.inc diff --git a/rules-tests/CodingStyle/Rector/ArrowFunction/ArrowFunctionDelegatingCallToFirstClassCallableRector/Fixture/skip_with_reset.php.inc b/rules-tests/CodingStyle/Rector/ArrowFunction/ArrowFunctionDelegatingCallToFirstClassCallableRector/Fixture/skip_with_reset.php.inc new file mode 100644 index 00000000000..86c14f58ded --- /dev/null +++ b/rules-tests/CodingStyle/Rector/ArrowFunction/ArrowFunctionDelegatingCallToFirstClassCallableRector/Fixture/skip_with_reset.php.inc @@ -0,0 +1,12 @@ +getParameters(); + foreach ($parameters as $parameter) { + if ($parameter->passedByReference()->yes()) { + return true; + } + } + $functionLike = $this->astResolver->resolveClassMethodOrFunctionFromCall($callLike); if (! $functionLike instanceof FunctionLike) { return false; From 5f3664f015c185e2092ca881e90b8ad609f18bb5 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Wed, 1 Apr 2026 22:31:45 +0700 Subject: [PATCH 2/3] see --- .../Fixture/skip_with_reset.php.inc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/rules-tests/CodingStyle/Rector/ArrowFunction/ArrowFunctionDelegatingCallToFirstClassCallableRector/Fixture/skip_with_reset.php.inc b/rules-tests/CodingStyle/Rector/ArrowFunction/ArrowFunctionDelegatingCallToFirstClassCallableRector/Fixture/skip_with_reset.php.inc index 86c14f58ded..5090fdf3961 100644 --- a/rules-tests/CodingStyle/Rector/ArrowFunction/ArrowFunctionDelegatingCallToFirstClassCallableRector/Fixture/skip_with_reset.php.inc +++ b/rules-tests/CodingStyle/Rector/ArrowFunction/ArrowFunctionDelegatingCallToFirstClassCallableRector/Fixture/skip_with_reset.php.inc @@ -2,6 +2,9 @@ namespace Rector\Tests\CodingStyle\Rector\ArrowFunction\ArrowFunctionDelegatingCallToFirstClassCallableRector\Fixture; +/** + * @see https://3v4l.org/T4rPe#v8.5.3 + */ final class SkipWithReset { public function run() From e9eac61c50c73d203994187e7004175aef76f211 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Wed, 1 Apr 2026 22:32:09 +0700 Subject: [PATCH 3/3] fix --- .../Fixture/skip_with_reset.php.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules-tests/CodingStyle/Rector/ArrowFunction/ArrowFunctionDelegatingCallToFirstClassCallableRector/Fixture/skip_with_reset.php.inc b/rules-tests/CodingStyle/Rector/ArrowFunction/ArrowFunctionDelegatingCallToFirstClassCallableRector/Fixture/skip_with_reset.php.inc index 5090fdf3961..0a027137fe2 100644 --- a/rules-tests/CodingStyle/Rector/ArrowFunction/ArrowFunctionDelegatingCallToFirstClassCallableRector/Fixture/skip_with_reset.php.inc +++ b/rules-tests/CodingStyle/Rector/ArrowFunction/ArrowFunctionDelegatingCallToFirstClassCallableRector/Fixture/skip_with_reset.php.inc @@ -10,6 +10,6 @@ final class SkipWithReset public function run() { $data = [['a']]; - return array_map(reset(...), $data); + return array_map(fn ($item) => reset($item), $data); } }