Addressed PR comments

Author: tleonhardt

cmd2/cmd2.py

@@ -73,7 +73,7 @@
     filters,
     print_formatted_text,
 )
-from prompt_toolkit.application import get_app
+from prompt_toolkit.application import create_app_session, get_app
 from prompt_toolkit.auto_suggest import AutoSuggestFromHistory
 from prompt_toolkit.completion import Completer, DummyCompleter
 from prompt_toolkit.formatted_text import ANSI, FormattedText
@@ -4399,10 +4399,11 @@ def select(self, opts: str | Iterable[str] | Iterable[tuple[Any, str | None]], p
                 except (IndexError, TypeError):
                     fulloptions.append((opt[0], str(opt[0])))
 
-        if self.stdin.isatty() and self.stdout.isatty():
+        if self._is_tty_session(self.main_session):
             try:
                 while True:
-                    result = choice(message=prompt, options=fulloptions)
+                    with create_app_session(input=self.main_session.input, output=self.main_session.output):
+                        result = choice(message=prompt, options=fulloptions)
                     if result is not None:
                         return result
             except KeyboardInterrupt:

docs/features/misc.md

@@ -34,6 +34,10 @@ Sauce? 2
 wheaties with salty sauce, yum!
 ```
 
+See the `do_eat` method in the
+[read_input.py](https://github.com/python-cmd2/cmd2/blob/main/examples/read_input.py) file for a
+example of how to use `select.
+
 ## Disabling Commands
 
 `cmd2` supports disabling commands during runtime. This is useful if certain commands should only be

examples/read_input.py

@@ -1,5 +1,8 @@
 #!/usr/bin/env python
-"""A simple example demonstrating the various ways to call cmd2.Cmd.read_input() for input history and tab completion."""
+"""A simple example demonstrating the various ways to call cmd2.Cmd.read_input() for input history and tab completion.
+
+It also demonstrates how to use the cmd2.Cmd.select method.
+"""
 
 import contextlib
 
@@ -94,6 +97,16 @@ def do_custom_parser(self, _) -> None:
         else:
             self.custom_history.append(input_str)
 
+    def do_eat(self, arg):
+        """Example of using the select method for reading multiple choice input.
+
+        Usage: eat wheatties
+        """
+        sauce = self.select('sweet salty', 'Sauce? ')
+        result = '{food} with {sauce} sauce, yum!'
+        result = result.format(food=arg, sauce=sauce)
+        self.stdout.write(result + '\n')
+
 
 if __name__ == '__main__':
     import sys

examples/remove_settable.py

@@ -1,8 +1,5 @@
 #!/usr/bin/env python
-"""A sample application for cmd2 demonstrating how to remove one of the built-in runtime settable parameters.
-
-It also demonstrates how to use the cmd2.Cmd.select method.
-"""
+"""A sample application for cmd2 demonstrating how to remove one of the built-in runtime settable parameters."""
 
 import cmd2
 
@@ -12,12 +9,6 @@ def __init__(self) -> None:
         super().__init__()
         self.remove_settable('debug')
 
-    def do_eat(self, arg):
-        sauce = self.select('sweet salty', 'Sauce? ')
-        result = '{food} with {sauce} sauce, yum!'
-        result = result.format(food=arg, sauce=sauce)
-        self.stdout.write(result + '\n')
-
 
 if __name__ == '__main__':
     import sys

tests/test_cmd2.py

@@ -1750,13 +1750,16 @@ def test_select_choice_tty(outsim_app, monkeypatch) -> None:
     choice_mock = mock.MagicMock(name='choice', return_value='sweet')
     monkeypatch.setattr("cmd2.cmd2.choice", choice_mock)
 
-    # Mock isatty to be True for both stdin and stdout
-    monkeypatch.setattr(outsim_app.stdin, "isatty", lambda: True)
-    monkeypatch.setattr(outsim_app.stdout, "isatty", lambda: True)
-
     prompt = 'Sauce? '
     options = ['sweet', 'salty']
-    result = outsim_app.select(options, prompt)
+
+    with create_pipe_input() as pipe_input:
+        outsim_app.main_session = PromptSession(
+            input=pipe_input,
+            output=DummyOutput(),
+        )
+
+        result = outsim_app.select(options, prompt)
 
     assert result == 'sweet'
     choice_mock.assert_called_once_with(message=prompt, options=[('sweet', 'sweet'), ('salty', 'salty')])
@@ -1767,17 +1770,20 @@ def test_select_choice_tty_ctrl_c(outsim_app, monkeypatch) -> None:
     choice_mock = mock.MagicMock(name='choice', side_effect=KeyboardInterrupt)
     monkeypatch.setattr("cmd2.cmd2.choice", choice_mock)
 
-    # Mock isatty to be True for both stdin and stdout
-    monkeypatch.setattr(outsim_app.stdin, "isatty", lambda: True)
-    monkeypatch.setattr(outsim_app.stdout, "isatty", lambda: True)
-
     prompt = 'Sauce? '
     options = ['sweet', 'salty']
 
-    with pytest.raises(KeyboardInterrupt):
-        outsim_app.select(options, prompt)
+    # Mock isatty to be True for both stdin and stdout
+    with create_pipe_input() as pipe_input:
+        outsim_app.main_session = PromptSession(
+            input=pipe_input,
+            output=DummyOutput(),
+        )
 
-    out = outsim_app.stdout.getvalue()
+        with pytest.raises(KeyboardInterrupt):
+            outsim_app.select(options, prompt)
+
+        out = outsim_app.stdout.getvalue()
     assert out.rstrip().endswith('^C')