Override default colours for theme

[wellavelino]

Hi im using github_dark_dimmed and tried to override some of the default colours, however even after trying to "recompile" with GithubThemeCompile it does not work, the colours are the same as the default theming.

I wonder if my config is not correct, even though I followed the documentation.

local specs = {
  -- As with palettes, the values defined under `all` will be applied to every style.
  all = {
    syntax = {
      ["keyword.conditional"] = "magenta.bright",
      ["keyword.conditional.ternary"] = "#d670d6", -- Ternary operators specifically
      ["function.builtin"] = "#ff9500", -- Change to your preferred color
      ["function.method"] = "yellow",
      ["variable.builtin"] = { fg = "#8abeb7" }, -- Built-in variables like 'self', 'this'
      ["keyword.function"] = "#9c0008", -- Function definition keywords:with
      ["punctuation.bracket"] = { fg = "#bcc2cc" }, -- Brackets
    },
    git = {
      -- A color define can also be used
      changed = "#bcc2cc", -- semi white
    },
  },
}

local palettes = {
  github_dark_dimmed = {
    -- comment is the definition of the comment color.
    comment = "#636e7b",
  },
}

return {
  "projekt0n/github-nvim-theme",
  name = "github-theme",
  lazy = false, --

  priority = 2000, --
  config = function()
    require("github-theme").setup({
      options = {
        transparent = true,
        dim_inactive = true,

        styles = {
          comments = "bold", -- Value is any valid attr-list value `:help attr-list`
          functions = "NONE",
          keywords = "bold",
          variables = "NONE",
          types = "italic,bold",
          strings = "italic",
          constants = "bold",
          operators = "bold",
        },
        specs = specs,
        palettes = palettes,
      },
    })

    vim.cmd("colorscheme github_dark_dimmed")
  end,
}

That's how it looks like

[pnsiah]

Yes i have the same issue too. I've tried using my custom colors too but the colors are way off I do not know why. If you have any solution please let me know.

[wellavelino]

didn't had much time to look into it, I will try to debug it myself in the upcoming days..

[tmillr]

You can view the valid keys/indices for specs.*.syntax here (line 140).

I believe it is also possible to define/add new keys to a spec, but there are a couple things to note with this:

1. They are only "defines", and won't have any effect until you use/consume them elsewhere in your config (typically within a highlight group under groups). Think of it like defining a new variable which can be referenced later.
2. This particular feature may have some bugs and edge-cases which don't work currently. It has been the source of a couple bugs in the past, and should perhaps get replaced with something else in the future. There's also no LSP autocompletion for it.

---

In your syntax table, it seems you are trying to override nvim highlight groups such as @keyword.conditional. Those must be put under the key groups, not specs.

require('github-theme').setup({
  options = {
    groups = {
      all = {
        ['@keyword.conditional'] = { fg = 'magenta.bright' },
      },
    },
  },
})