feat(web): implement approved plans in new worktrees

Author: Quentin

apps/server/src/codexAppServerManager.test.ts

@@ -1,4 +1,3 @@
-import { EventEmitter } from "node:events";
 import { describe, expect, it, vi } from "vitest";
 import { randomUUID } from "node:crypto";
 import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
@@ -206,77 +205,6 @@ describe("classifyCodexStderrLine", () => {
       message: line,
     });
   });
-
-  it("emits process/stderr as a notification event", () => {
-    const manager = new CodexAppServerManager();
-    const events: Array<{ method: string; kind: string; message?: string }> = [];
-    manager.on("event", (event) => {
-      events.push({
-        method: event.method,
-        kind: event.kind,
-        ...(event.message ? { message: event.message } : {}),
-      });
-    });
-
-    const output = new EventEmitter();
-    const stderr = new EventEmitter();
-    const child = new EventEmitter() as EventEmitter & { stderr: EventEmitter };
-    child.stderr = stderr;
-
-    type ProcessListenerHarnessContext = {
-      session: {
-        provider: "codex";
-        status: "ready";
-        threadId: ThreadId;
-        runtimeMode: "full-access";
-        createdAt: string;
-        updatedAt: string;
-      };
-      child: EventEmitter & { stderr: EventEmitter };
-      output: EventEmitter;
-      pending: Map<string, unknown>;
-      pendingApprovals: Map<string, unknown>;
-      pendingUserInputs: Map<string, unknown>;
-      nextRequestId: number;
-      stopping: boolean;
-    };
-
-    const context: ProcessListenerHarnessContext = {
-      session: {
-        provider: "codex" as const,
-        status: "ready" as const,
-        threadId: asThreadId("thread-1"),
-        runtimeMode: "full-access" as const,
-        createdAt: "2026-02-10T00:00:00.000Z",
-        updatedAt: "2026-02-10T00:00:00.000Z",
-      },
-      child,
-      output,
-      pending: new Map(),
-      pendingApprovals: new Map(),
-      pendingUserInputs: new Map(),
-      nextRequestId: 1,
-      stopping: false,
-    };
-
-    (
-      manager as unknown as {
-        attachProcessListeners: (context: ProcessListenerHarnessContext) => void;
-      }
-    ).attachProcessListeners(context);
-
-    const line =
-      "2026-03-10T01:03:53.921955Z ERROR codex_core::models_manager::manager: failed to renew cache TTL: EOF while parsing a value at line 1 column 0";
-    stderr.emit("data", Buffer.from(`${line}\n`));
-
-    expect(events).toEqual([
-      {
-        method: "process/stderr",
-        kind: "notification",
-        message: line,
-      },
-    ]);
-  });
 });
 
 describe("process stderr events", () => {

apps/server/src/codexAppServerManager.ts

@@ -1046,7 +1046,7 @@ export class CodexAppServerManager extends EventEmitter<CodexAppServerManagerEve
           continue;
         }
 
-        this.emitNotificationEvent(context, "process/stderr", classified.message);
+        this.emitErrorEvent(context, "process/stderr", classified.message);
       }
     });
 
@@ -1342,22 +1342,6 @@ export class CodexAppServerManager extends EventEmitter<CodexAppServerManagerEve
     });
   }
 
-  private emitNotificationEvent(
-    context: CodexSessionContext,
-    method: string,
-    message: string,
-  ): void {
-    this.emitEvent({
-      id: EventId.makeUnsafe(randomUUID()),
-      kind: "notification",
-      provider: "codex",
-      threadId: context.session.threadId,
-      createdAt: new Date().toISOString(),
-      method,
-      message,
-    });
-  }
-
   private emitErrorEvent(context: CodexSessionContext, method: string, message: string): void {
     this.emitEvent({
       id: EventId.makeUnsafe(randomUUID()),

apps/server/src/provider/Layers/CodexAdapter.test.ts

@@ -651,50 +651,9 @@ lifecycleLayer("CodexAdapterLive lifecycle", (it) => {
         assert.equal(firstEvent.payload.reason, "Sandbox setup failed");
       }
 
-        assert.equal(secondEvent?.type, "runtime.warning");
-        if (secondEvent?.type === "runtime.warning") {
-          assert.equal(secondEvent.payload.message, "Sandbox setup failed");
-        }
-      }),
-  );
-
-  it.effect("maps process/stderr notifications into runtime warnings", () =>
-    Effect.gen(function* () {
-      const adapter = yield* CodexAdapter;
-      const eventsFiber = yield* Stream.runCollect(Stream.take(adapter.streamEvents, 1)).pipe(
-        Effect.timeoutOption(1_000),
-        Effect.forkChild,
-      );
-
-      const event: ProviderEvent = {
-        id: asEventId("evt-process-stderr"),
-        kind: "notification",
-        provider: "codex",
-        threadId: asThreadId("thread-1"),
-        createdAt: new Date().toISOString(),
-        method: "process/stderr",
-        message:
-          "2026-03-10T01:03:53.921955Z ERROR codex_core::models_manager::manager: failed to renew cache TTL: EOF while parsing a value at line 1 column 0",
-      };
-
-      lifecycleManager.emit("event", event);
-      const maybeEvents = yield* Fiber.join(eventsFiber);
-
-      assert.equal(Option.isSome(maybeEvents), true);
-      if (Option.isNone(maybeEvents)) {
-        return;
-      }
-
-      const events = Array.from(maybeEvents.value);
-      assert.equal(events.length, 1);
-
-      const warningEvent = events[0];
-      assert.equal(warningEvent?.type, "runtime.warning");
-      if (warningEvent?.type === "runtime.warning") {
-        assert.equal(
-          warningEvent.payload.message,
-          "2026-03-10T01:03:53.921955Z ERROR codex_core::models_manager::manager: failed to renew cache TTL: EOF while parsing a value at line 1 column 0",
-        );
+      assert.equal(secondEvent?.type, "runtime.warning");
+      if (secondEvent?.type === "runtime.warning") {
+        assert.equal(secondEvent.payload.message, "Sandbox setup failed");
       }
     }),
   );

apps/server/src/provider/Layers/CodexAdapter.ts

@@ -696,23 +696,6 @@ function mapToRuntimeEvents(
     ];
   }
 
-  if (event.method === "process/stderr") {
-    if (!event.message) {
-      return [];
-    }
-
-    return [
-      {
-        type: "runtime.warning",
-        ...runtimeEventBase(event, canonicalThreadId),
-        payload: {
-          message: event.message,
-          ...(event.payload !== undefined ? { detail: event.payload } : {}),
-        },
-      },
-    ];
-  }
-
   if (event.method === "thread/started") {
     const payloadThreadId = asString(asObject(payload?.thread)?.id);
     const providerThreadId = payloadThreadId ?? asString(payload?.threadId);