From be7f985b298816e66d76492b1bc094b93da0aa97 Mon Sep 17 00:00:00 2001 From: neil Date: Mon, 2 Mar 2026 00:28:30 -0800 Subject: [PATCH 1/4] AO3-7302 moved local variable to instance in meta partial --- app/views/chapters/show.html.erb | 2 +- app/views/works/_meta.html.erb | 8 ++++---- app/views/works/preview.html.erb | 2 +- app/views/works/show.html.erb | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/views/chapters/show.html.erb b/app/views/chapters/show.html.erb index 7ceca3b2115..bbf08998979 100644 --- a/app/views/chapters/show.html.erb +++ b/app/views/chapters/show.html.erb @@ -28,7 +28,7 @@ <%= render "works/work_header_navigation" %> - <%= render "works/meta", work: @work %> + <%= render "works/meta" %> <%= render "works/work_skin" %> diff --git a/app/views/works/_meta.html.erb b/app/views/works/_meta.html.erb index a122e897db1..1677d211923 100755 --- a/app/views/works/_meta.html.erb +++ b/app/views/works/_meta.html.erb @@ -1,10 +1,10 @@ -<% cache_unless(@preview_mode, "/v4/#{work.cache_key}-#{Work.work_blurb_version(work.id)}-meta-#{hide_warnings?(work) ? 'nowarn' : 'showwarn'}-#{hide_freeform?(work) ? 'nofreeform' : 'showfreeform'}", skip_digest: true) do %> +<% cache_unless(@preview_mode, "/v4/#{@work.cache_key}-#{Work.work_blurb_version(@work.id)}-meta-#{hide_warnings?(@work) ? 'nowarn' : 'showwarn'}-#{hide_freeform?(@work) ? 'nofreeform' : 'showfreeform'}", skip_digest: true) do %>

<%= ts("Work Header") %>

- <% tag_group = work.tag_groups + <% tag_group = @work.tag_groups Tag::VISIBLE.each do |type| %> <% tags = tag_group[type] %> <% unless tags.blank? %> @@ -21,8 +21,8 @@
    - <% if (type == "ArchiveWarning" && hide_warnings?(work)) || (type == "Freeform" && hide_freeform?(work)) %> - <%= show_hidden_tag_link_list_item(work, type, { suppress_toggle_class: true }) %> + <% if (type == "ArchiveWarning" && hide_warnings?(@work)) || (type == "Freeform" && hide_freeform?(@work)) %> + <%= show_hidden_tag_link_list_item(@work, type, { suppress_toggle_class: true }) %> <% else %> <%= tag_link_list(tags, link_to_works=true) %> <% end %> diff --git a/app/views/works/preview.html.erb b/app/views/works/preview.html.erb index 8745748b983..9957e4c9c5b 100755 --- a/app/views/works/preview.html.erb +++ b/app/views/works/preview.html.erb @@ -6,7 +6,7 @@
    - <%= render "works/meta", work: @work %> + <%= render "works/meta" %> <%= render "works/work_skin" %> diff --git a/app/views/works/show.html.erb b/app/views/works/show.html.erb index c569960dc45..2a1dd6fd631 100755 --- a/app/views/works/show.html.erb +++ b/app/views/works/show.html.erb @@ -30,7 +30,7 @@ <%= render "works/work_header_navigation" %> - <%= render "works/meta", work: @work %> + <%= render "works/meta" %> <%= render "works/work_skin" %> From ab4e9d4ddb061c3ebfcc2e06f5ffa2381fad2f1d Mon Sep 17 00:00:00 2001 From: neil Date: Mon, 2 Mar 2026 00:42:58 -0800 Subject: [PATCH 2/4] AO3-7302 fixed linting errors --- app/views/works/_meta.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/works/_meta.html.erb b/app/views/works/_meta.html.erb index 1677d211923..778d343ab73 100755 --- a/app/views/works/_meta.html.erb +++ b/app/views/works/_meta.html.erb @@ -1,4 +1,4 @@ -<% cache_unless(@preview_mode, "/v4/#{@work.cache_key}-#{Work.work_blurb_version(@work.id)}-meta-#{hide_warnings?(@work) ? 'nowarn' : 'showwarn'}-#{hide_freeform?(@work) ? 'nofreeform' : 'showfreeform'}", skip_digest: true) do %> +<% cache_unless(@preview_mode, "/v4/#{@work.cache_key}-#{Work.work_blurb_version(@work.id)}-meta-#{hide_warnings?(@work) ? 'nowarn' : 'showwarn'}-#{hide_freeform?(@work) ? 'nofreeform' : 'showfreeform'}", skip_digest: true) do %>

    <%= ts("Work Header") %>

    From 6167787949a04b04052270c78e5590e4b5411254 Mon Sep 17 00:00:00 2001 From: neil Date: Tue, 3 Mar 2026 00:44:25 -0800 Subject: [PATCH 3/4] AO3-7302 missed reference to works/meta --- app/views/works/preview_tags.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/works/preview_tags.html.erb b/app/views/works/preview_tags.html.erb index 5954953e7b8..8d54b5c3a63 100644 --- a/app/views/works/preview_tags.html.erb +++ b/app/views/works/preview_tags.html.erb @@ -12,7 +12,7 @@
    - <%= render 'works/meta', work: @work %> + <%= render 'works/meta' %>
    From 452f6834c04920d22f515db581c5740146980d52 Mon Sep 17 00:00:00 2001 From: neil Date: Tue, 3 Mar 2026 00:49:01 -0800 Subject: [PATCH 4/4] AO3-7302 linting errors... again... --- app/views/works/preview_tags.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/works/preview_tags.html.erb b/app/views/works/preview_tags.html.erb index 8d54b5c3a63..b12085b5a7a 100644 --- a/app/views/works/preview_tags.html.erb +++ b/app/views/works/preview_tags.html.erb @@ -12,7 +12,7 @@
    - <%= render 'works/meta' %> + <%= render "works/meta" %>