コードスタディプラグインは廃止されました。
' + . 'このフレームは固定記事に置き換えています。
' + . '必要な情報がある場合は、サイト管理者にお問い合わせください。
'; + } +} diff --git a/database/migrations/2026_02_18_000000_remove_codestudies_from_plugins.php b/database/migrations/2026_02_18_000000_remove_codestudies_from_plugins.php new file mode 100644 index 000000000..1233f6705 --- /dev/null +++ b/database/migrations/2026_02_18_000000_remove_codestudies_from_plugins.php @@ -0,0 +1,29 @@ +whereRaw('LOWER(plugin_name) = ?', ['codestudies']) + ->delete(); + } + + /** + * Reverse the migrations. + * + * @return void + */ + public function down() + { + // 削除済みプラグインの再表示を防ぐため、復元はしない。 + } +} diff --git a/package-lock.json b/package-lock.json index d6a1f5aab..6c52474ee 100644 --- a/package-lock.json +++ b/package-lock.json @@ -8130,9 +8130,9 @@ "license": "MIT" }, "node_modules/minimatch": { - "version": "3.1.2", - "resolved": "https://registry.npmjs.org/minimatch/-/minimatch-3.1.2.tgz", - "integrity": "sha512-J7p63hRiAjw1NDEww1W7i37+ByIrOWO5XQQAzZ3VOcL0PNybwpfmV/N05zFAzwQ9USyEcX6t3UO+K5aqBQOIHw==", + "version": "3.1.5", + "resolved": "https://registry.npmjs.org/minimatch/-/minimatch-3.1.5.tgz", + "integrity": "sha512-VgjWUsnnT6n+NUk6eZq77zeFdpW2LWDzP6zFGrCbHXiYNul5Dzqk2HHQ5uFH2DNW5Xbp8+jVzaeNt94ssEEl4w==", "dev": true, "license": "ISC", "dependencies": { diff --git a/resources/views/plugins/manage/page/migration_order.blade.php b/resources/views/plugins/manage/page/migration_order.blade.php index 5dc00c8c7..a4ff3bd50 100644 --- a/resources/views/plugins/manage/page/migration_order.blade.php +++ b/resources/views/plugins/manage/page/migration_order.blade.php @@ -73,6 +73,22 @@ + @if (config('connect.HTTPPROXYTUNNEL')) +
+
+
+ @endif
+
{{-- UI的に、セレクトボックスは不要だったのでとりあえず、コメントアウト
+
+
+
+
+
+
+ プロキシ使用時は、接続先IP固定（DNS pinning）および接続先IP検証（primary_ip）を行いません。SSRF対策が弱くなるため、必要時のみ使用してください。
+
+ @include('plugins.common.errors_inline', ['name' => 'use_proxy'])
+
diff --git a/resources/views/plugins/mypage/profile/edit_form.blade.php b/resources/views/plugins/mypage/profile/edit_form.blade.php
index a84b9be26..67acfa08f 100644
--- a/resources/views/plugins/mypage/profile/edit_form.blade.php
+++ b/resources/views/plugins/mypage/profile/edit_form.blade.php
@@ -16,7 +16,7 @@
{{-- 登録後メッセージ表示 --}}
@include('plugins.common.flash_message')
-
@php
- $caption = nl2br($form_column->caption);
- $caption = str_ireplace('[[upload_max_filesize]]', ini_get('upload_max_filesize'), $caption);
+ $caption = \App\Plugins\User\Forms\FormsUploadHelper::replaceUploadMaxFilesize($form_column->caption, $form_column);
@endphp
{!! $caption !!}
@@ -140,8 +138,7 @@
@include('plugins.user.forms.default.forms_input_' . $form_column->column_type, ['form_obj' => $form_column, 'label_id' => 'column-'.$form_column->id.'-'.$frame_id])
@php
- $caption = nl2br($form_column->caption);
- $caption = str_ireplace('[[upload_max_filesize]]', ini_get('upload_max_filesize'), $caption);
+ $caption = \App\Plugins\User\Forms\FormsUploadHelper::replaceUploadMaxFilesize($form_column->caption, $form_column);
@endphp
diff --git a/resources/views/plugins/user/forms/default/forms_edit_row_detail.blade.php b/resources/views/plugins/user/forms/default/forms_edit_row_detail.blade.php
index 77f9c04a7..763ca17b6 100644
--- a/resources/views/plugins/user/forms/default/forms_edit_row_detail.blade.php
+++ b/resources/views/plugins/user/forms/default/forms_edit_row_detail.blade.php
@@ -71,9 +71,51 @@ function submit_update_column_detail() {
form_column_detail.submit();
}
+ /**
+ * ファイル拡張子の分類単位で一括チェック/一括解除する
+ */
+ function toggleFileExtensionGroup(group_index, trigger) {
+ const checked = !!(trigger && trigger.checked);
+ const selector = 'input[name="rule_file_extensions[]"][data-extension-group="' + group_index + '"]';
+ document.querySelectorAll(selector).forEach(function (checkbox) {
+ checkbox.checked = checked;
+ });
+ syncFileExtensionGroupMaster(group_index);
+ }
+
+ /**
+ * ファイル拡張子の分類単位で「全てチェック」状態を同期する
+ */
+ function syncFileExtensionGroupMaster(group_index) {
+ const master = document.getElementById('rule_file_extensions_group_check_' + group_index);
+ if (!master) {
+ return;
+ }
+
+ const selector = 'input[name="rule_file_extensions[]"][data-extension-group="' + group_index + '"]';
+ const children = Array.from(document.querySelectorAll(selector));
+ if (children.length === 0) {
+ master.checked = false;
+ return;
+ }
+
+ master.checked = children.every(function (checkbox) {
+ return checkbox.checked;
+ });
+ }
+
$(function () {
// ツールチップ有効化
$('[data-toggle="tooltip"]').tooltip()
+
+ // 初期表示時に「全てチェック」状態を同期
+ const group_indexes = new Set();
+ document.querySelectorAll('input[name="rule_file_extensions[]"][data-extension-group]').forEach(function (checkbox) {
+ group_indexes.add(checkbox.getAttribute('data-extension-group'));
+ });
+ group_indexes.forEach(function (group_index) {
+ syncFileExtensionGroupMaster(group_index);
+ });
})
@@ -430,6 +472,119 @@ class="btn btn-danger cc-font-90 text-nowrap"
{!! $caption !!}
@endif + @if ($column->column_type == FormColumnType::file) + @php + $file_extension_options = \App\Plugins\User\Forms\FormsUploadHelper::normalizeExtensions( + config('forms.upload.allowed_extensions', []) + ); + $selected_extensions = \App\Plugins\User\Forms\FormsUploadHelper::resolveSelectedExtensionsForEdit( + old('rule_file_extensions'), + old('rule_file_extensions_submitted'), + $column->rule_file_extensions, + $file_extension_options + ); + $categorized_extension_groups = \App\Plugins\User\Forms\FormsUploadHelper::buildCategorizedExtensionGroups( + $file_extension_options, + config('forms.upload.extension_categories', []) + ); + $php_upload_max_filesize = \App\Plugins\User\Forms\FormsUploadHelper::getPhpUploadMaxFilesizeCaption(); + $max_size_options = \App\Plugins\User\Forms\FormsUploadHelper::buildMaxSizeOptions( + \App\Plugins\User\Forms\FormsUploadHelper::getPhpUploadMaxKb() + ); + $selected_file_max_kb = \App\Plugins\User\Forms\FormsUploadHelper::normalizeSelectedFileMaxKb( + old('rule_file_max_kb', $column->rule_file_max_kb) + ); + @endphp + +
+
+ ファイルアップロード設定
+
+ {{-- 許可拡張子 --}}
+
+
+
+
+
+ {{-- 最大ファイルサイズ --}}
+
+
+ @foreach ($categorized_extension_groups as $group_index => $extension_group)
+
+
+
+ @endforeach
+ @if ($errors && $errors->has('rule_file_extensions'))
+
+ @if (! empty($extension_group['description']))
+ {{$extension_group['description']}}
+ @endif
+ {{$extension_group['label']}}
+
+
+
+
+
+
+
+ @foreach ($extension_group['extensions'] as $extension)
+ @php
+ $checkbox_id = 'rule_file_extensions_' . $group_index . '_' . $extension;
+ @endphp
+
+
+
+ @endforeach
+
+
+
+
+ {{$errors->first('rule_file_extensions')}}
@endif
+
+
+
+
+ {{-- ボタンエリア --}}
+
+
+ ※ サーバの設定によるため、サイズを変更しても反映されない場合があります。
+ @if (! empty($php_upload_max_filesize))
+ ※ サーバ設定：アップロードできる最大サイズ {{$php_upload_max_filesize}}
+ @endif
+ @if ($errors && $errors->has('rule_file_max_kb'))
+ {{$errors->first('rule_file_max_kb')}}
@endif
+
+
+
+ + @endif {{-- キャプション設定 --}}
diff --git a/resources/views/plugins/user/forms/default/forms_input_file.blade.php b/resources/views/plugins/user/forms/default/forms_input_file.blade.php
index 5c191c77e..0800d3ff1 100644
--- a/resources/views/plugins/user/forms/default/forms_input_file.blade.php
+++ b/resources/views/plugins/user/forms/default/forms_input_file.blade.php
@@ -1,5 +1,15 @@
{{--
* 登録画面(input file)テンプレート。
--}}
-
+@php
+ $default_extensions = \App\Plugins\User\Forms\FormsUploadHelper::normalizeExtensions(
+ config('forms.upload.allowed_extensions', [])
+ );
+ $allowed_extensions = \App\Plugins\User\Forms\FormsUploadHelper::resolveAllowedExtensions(
+ $default_extensions,
+ $form_obj->rule_file_extensions
+ );
+ $accept_attr = \App\Plugins\User\Forms\FormsUploadHelper::toAcceptAttribute($allowed_extensions);
+@endphp
+
@include('plugins.common.errors_inline', ['name' => "forms_columns_value.$form_obj->id"])
diff --git a/resources/views/plugins/user/forms/default/index_tandem.blade.php b/resources/views/plugins/user/forms/default/index_tandem.blade.php
index 7ca165e68..30b86688f 100644
--- a/resources/views/plugins/user/forms/default/index_tandem.blade.php
+++ b/resources/views/plugins/user/forms/default/index_tandem.blade.php
@@ -75,8 +75,7 @@
{{-- 項目 ※まとめ設定行 --}}
@include('plugins.user.forms.default.forms_input_' . $group_row->column_type, ['form_obj' => $group_row, 'label_id' => 'column-'.$group_row->id.'-'.$frame_id])
@php
- $caption = nl2br($group_row->caption);
- $caption = str_ireplace('[[upload_max_filesize]]', ini_get('upload_max_filesize'), $caption);
+ $caption = \App\Plugins\User\Forms\FormsUploadHelper::replaceUploadMaxFilesize($group_row->caption, $group_row);
@endphp
@@ -84,8 +83,7 @@
@endforeach
@php
- $caption = nl2br($form_column->caption);
- $caption = str_ireplace('[[upload_max_filesize]]', ini_get('upload_max_filesize'), $caption);
+ $caption = \App\Plugins\User\Forms\FormsUploadHelper::replaceUploadMaxFilesize($form_column->caption, $form_column);
@endphp
{!! $caption !!}
{!! $caption !!}
@@ -109,8 +107,7 @@
@include('plugins.user.forms.default.forms_input_' . $form_column->column_type, ['form_obj' => $form_column, 'label_id' => 'column-'.$form_column->id.'-'.$frame_id])
@php
- $caption = nl2br($form_column->caption);
- $caption = str_ireplace('[[upload_max_filesize]]', ini_get('upload_max_filesize'), $caption);
+ $caption = \App\Plugins\User\Forms\FormsUploadHelper::replaceUploadMaxFilesize($form_column->caption, $form_column);
@endphp
diff --git a/tests/Feature/Core/UploadFileResponseTest.php b/tests/Feature/Core/UploadFileResponseTest.php
new file mode 100644
index 000000000..cbc67673b
--- /dev/null
+++ b/tests/Feature/Core/UploadFileResponseTest.php
@@ -0,0 +1,74 @@
+seed();
+ }
+
+ private function putUploadFile(Uploads $upload, string $content = 'dummy'): void
+ {
+ $path = $this->getDirectory($upload->id) . '/' . $upload->id . '.' . $upload->extension;
+ Storage::disk('local')->put($path, $content);
+ }
+
+ /**
+ * /file/{id} では html が attachment で返ること（インライン禁止）。
+ */
+ public function testGetFileReturnsAttachmentForHtml(): void
+ {
+ $upload = Uploads::factory()->create([
+ 'client_original_name' => 'sample.html',
+ 'mimetype' => 'text/html',
+ 'extension' => 'html',
+ 'plugin_name' => 'forms',
+ 'page_id' => 0,
+ 'temporary_flag' => 0,
+ ]);
+
+ $this->putUploadFile($upload, 'test');
+
+ $response = $this->get("/file/{$upload->id}");
+
+ $response->assertStatus(200);
+ $this->assertStringContainsString('attachment', (string) $response->headers->get('Content-Disposition'));
+ }
+
+ /**
+ * /file/user/{dir}/{filename} では html のインライン表示を維持すること。
+ */
+ public function testGetUserFileKeepsInlineForHtml(): void
+ {
+ $dir = 'feature_userdir';
+ $filename = 'sample.html';
+ Storage::disk('user')->put($dir . '/' . $filename, 'test');
+
+ Configs::create([
+ 'category' => 'userdir_allow',
+ 'name' => $dir,
+ 'value' => 'allow_all',
+ ]);
+
+ $response = $this->get("/file/user/{$dir}/{$filename}");
+
+ $response->assertStatus(200);
+ $this->assertStringContainsString('inline', (string) $response->headers->get('Content-Disposition'));
+ }
+}
diff --git a/tests/Feature/Mypage/ProfileMypageUpdateTest.php b/tests/Feature/Mypage/ProfileMypageUpdateTest.php
new file mode 100644
index 000000000..7d1a09b11
--- /dev/null
+++ b/tests/Feature/Mypage/ProfileMypageUpdateTest.php
@@ -0,0 +1,80 @@
+seed();
+ }
+
+ /**
+ * URL引数のIDを指定しても、ログインユーザー以外のプロフィールは更新できない。
+ */
+ public function testProfileUpdatePathIdCannotUpdateAnotherUser(): void
+ {
+ $attacker = User::factory()->create([
+ 'name' => 'attacker',
+ 'userid' => 'attacker-userid',
+ 'email' => 'attacker@example.com',
+ 'columns_set_id' => 1,
+ ]);
+
+ $victim = User::factory()->create([
+ 'name' => 'victim',
+ 'userid' => 'victim-userid',
+ 'email' => 'victim@example.com',
+ 'columns_set_id' => 1,
+ ]);
+
+ $response = $this->actingAs($attacker)->post("/mypage/profile/update/{$victim->id}", [
+ 'name' => $attacker->name,
+ 'userid' => $attacker->userid,
+ 'email' => 'attacker-updated@example.com',
+ ]);
+
+ $response->assertStatus(302);
+ $response->assertRedirect(url('/mypage/profile'));
+ $response->assertSessionHas('flash_message', '更新しました。');
+
+ $this->assertSame('attacker-updated@example.com', $attacker->fresh()->email);
+ $this->assertSame('victim@example.com', $victim->fresh()->email);
+ }
+
+ /**
+ * フォーム送信先（IDなし）でもログインユーザーのプロフィールを更新できる。
+ */
+ public function testProfileUpdateWithoutPathIdUpdatesLoggedInUser(): void
+ {
+ $user = User::factory()->create([
+ 'name' => 'self-user',
+ 'userid' => 'self-userid',
+ 'email' => 'self@example.com',
+ 'columns_set_id' => 1,
+ ]);
+
+ $response = $this->actingAs($user)->post('/mypage/profile/update', [
+ 'name' => $user->name,
+ 'userid' => $user->userid,
+ 'email' => 'self-updated@example.com',
+ ]);
+
+ $response->assertStatus(302);
+ $response->assertRedirect(url('/mypage/profile'));
+ $response->assertSessionHas('flash_message', '更新しました。');
+
+ $this->assertSame('self-updated@example.com', $user->fresh()->email);
+ }
+}
diff --git a/tests/Feature/Plugins/Manage/PageManage/PageManageMigrationGetSecurityTest.php b/tests/Feature/Plugins/Manage/PageManage/PageManageMigrationGetSecurityTest.php
new file mode 100644
index 000000000..e43b83694
--- /dev/null
+++ b/tests/Feature/Plugins/Manage/PageManage/PageManageMigrationGetSecurityTest.php
@@ -0,0 +1,87 @@
+seed();
+ }
+
+ /**
+ * admin_page権限を持つユーザーを作成する。
+ */
+ private function createPageAdminUser(): User
+ {
+ $user = User::factory()->create();
+ UsersRoles::factory()->create([
+ 'users_id' => $user->id,
+ 'target' => 'manage',
+ 'role_name' => 'admin_page',
+ 'role_value' => 1,
+ ]);
+
+ return $user;
+ }
+
+ /**
+ * SSRFに悪用されうる内部/予約IP URLは取り込み前に拒否されること。
+ *
+ * @test
+ * @dataProvider blockedMigrationSourceUrlProvider
+ */
+ public function internalOrReservedSourceUrlIsRejectedBeforeFetching(string $source_system, string $url): void
+ {
+ Storage::fake();
+
+ $admin = $this->createPageAdminUser();
+ $page = Page::query()->firstOrFail();
+
+ $response = $this->actingAs($admin)->post("/manage/page/migrationGet/{$page->id}", [
+ 'source_system' => $source_system,
+ 'url' => $url,
+ 'destination_page_id' => $page->id,
+ ]);
+
+ $response->assertStatus(302);
+ $response->assertRedirect("/manage/page/migrationOrder/{$page->id}");
+ $response->assertSessionHasErrors(['url']);
+
+ Storage::disk(config('filesystems.default'))->assertMissing('migration/import/migration_last_request_time.txt');
+ Storage::disk(config('filesystems.default'))->assertMissing("migration/import/pages/{$page->id}/frame_0001.html");
+ }
+
+ /**
+ * @return array{!! $caption !!}
ok
', + 'http_code' => 200, + 'location' => '', + 'content_disposition' => '', + ]); + + $url = 'http://8.8.8.8/source/index.html'; + $page_id = 1002; + $target->runMigrationHtmlPage($url, $page_id); + + $this->assertSame([$url], $target->requestedGetUrls()); + $this->assertFrameSavedContains($page_id, 'ok
'); + } + + /** + * DOMDocumentの解析警告が発生するHTMLでも取り込みを継続して保存すること + * + * @return void + */ + public function testImportContinuesWhenDomDocumentEmitsHtmlParseWarnings() + { + $this->fakeMigrationStorage(); + + $target = new TestableMigrationExportHtmlPageTraitTarget(); + $target->queueGetResponse([ + 'body' => 'before &nobr; after
ok
', + 'http_code' => 200, + 'location' => '', + 'content_disposition' => '', + ]); + + $url = 'http://8.8.8.8/source/invalid-entity.html'; + $page_id = 1006; + + $target->runMigrationHtmlPage($url, $page_id); + + $this->assertSame([$url], $target->requestedGetUrls()); + $this->assertFrameSavedContains($page_id, 'ok
'); + } + + /** + * リダイレクト先が非グローバルURLなら保存せずに中断すること + * + * @return void + */ + public function testImportStopsWhenRedirectDestinationIsNonGlobal() + { + $this->fakeMigrationStorage(); + + $target = new TestableMigrationExportHtmlPageTraitTarget(); + $target->queueGetResponse([ + 'body' => '', + 'http_code' => 302, + 'location' => 'http://127.0.0.1/internal/index.html', + 'content_disposition' => '', + ]); + + $url = 'http://8.8.8.8/start/index.html'; + $page_id = 1003; + $target->runMigrationHtmlPage($url, $page_id); + + $this->assertSame([$url], $target->requestedGetUrls()); + $this->assertFrameNotSaved($page_id); + } + + /** + * グローバルなリダイレクト先には追従してHTMLを保存すること + * + * @return void + */ + public function testImportFollowsGlobalRedirectAndSavesHtml() + { + $this->fakeMigrationStorage(); + + $target = new TestableMigrationExportHtmlPageTraitTarget(); + $target->queueGetResponse([ + 'body' => '', + 'http_code' => 302, + 'location' => '/moved/index.html', + 'content_disposition' => '', + ]); + $target->queueGetResponse([ + 'body' => 'redirected
', + 'http_code' => 200, + 'location' => '', + 'content_disposition' => '', + ]); + + $start_url = 'http://8.8.8.8/start/index.html'; + $page_id = 1004; + $target->runMigrationHtmlPage($start_url, $page_id); + + $this->assertSame([ + 'http://8.8.8.8/start/index.html', + 'http://8.8.8.8/moved/index.html', + ], $target->requestedGetUrls()); + $this->assertFrameSavedContains($page_id, 'redirected
'); + } + + /** + * 画像ダウンロード失敗時は画像をスキップし、本文の保存は継続すること + * + * @return void + */ + public function testImportSkipsImageWhenImageDownloadFailsAndStillSavesBody() + { + $this->fakeMigrationStorage(); + + $target = new TestableMigrationExportHtmlPageTraitTarget(); + $image_url = 'http://8.8.8.8/files/missing.png'; + $target->queueGetResponse([ + 'body' => 'KeepBody
', + 'http_code' => 200, + 'location' => '', + 'content_disposition' => '', + ]); + $target->queueDownloadException(new \RuntimeException('image download failed')); + + $page_id = 1005; + $target->runMigrationHtmlPage('http://8.8.8.8/source/image-fail.html', $page_id); + + $this->assertSame(['http://8.8.8.8/source/image-fail.html'], $target->requestedGetUrls()); + $this->assertSame([$image_url], $target->requestedDownloadUrls()); + + $html = Storage::get("migration/import/pages/{$page_id}/frame_0001.html"); + $ini = Storage::get("migration/import/pages/{$page_id}/frame_0001.ini"); + + $this->assertStringContainsString('KeepBody', $html); + $this->assertStringContainsString($image_url, $html); + $this->assertStringNotContainsString('frame_0001_1.', $html); + $this->assertStringContainsString('[image_names]', $ini); + $this->assertStringNotContainsString('frame_0001_1', $ini); + } + + /** + * 移行用ストレージをfake化する + * + * @return void + */ + private function fakeMigrationStorage(): void + { + Storage::fake(config('filesystems.default', 'local')); + } + + /** + * フレームHTML/INIが保存されていないことを検証する + * + * @param int $page_id + * @return void + */ + private function assertFrameNotSaved(int $page_id): void + { + Storage::assertMissing("migration/import/pages/{$page_id}/frame_0001.html"); + Storage::assertMissing("migration/import/pages/{$page_id}/frame_0001.ini"); + } + + /** + * フレームHTML/INIが保存され、HTML内に期待文字列を含むことを検証する + * + * @param int $page_id + * @param string $expected_fragment + * @return void + */ + private function assertFrameSavedContains(int $page_id, string $expected_fragment): void + { + Storage::assertExists("migration/import/pages/{$page_id}/frame_0001.html"); + Storage::assertExists("migration/import/pages/{$page_id}/frame_0001.ini"); + $this->assertStringContainsString($expected_fragment, Storage::get("migration/import/pages/{$page_id}/frame_0001.html")); + } +} + +// phpcs:ignore PSR1.Classes.ClassDeclaration.MultipleClasses -- Test double is intentionally colocated with the test. +class TestableMigrationExportHtmlPageTraitTarget +{ + use MigrationExportHtmlPageTrait { + migrationHtmlPage as private traitMigrationHtmlPage; + } + + /** @var array */ + private $http_get_calls = []; + + /** @var array */ + private $queued_get_responses = []; + + /** @var array */ + private $download_calls = []; + + /** @var array */ + private $queued_download_results = []; + + public function runMigrationHtmlPage(string $url, int $page_id): void + { + $this->traitMigrationHtmlPage($url, $page_id); + } + + public function queueGetResponse(array $response): void + { + $this->queued_get_responses[] = $response; + } + + /** + * ダウンロード例外をキューに積む + * + * @param \RuntimeException $exception + * @return void + */ + public function queueDownloadException(\RuntimeException $exception): void + { + $this->queued_download_results[] = ['type' => 'exception', 'value' => $exception]; + } + + /** + * GETリクエストされたURL一覧を返す + * + * @return array + */ + public function requestedGetUrls(): array + { + return $this->http_get_calls; + } + + /** + * ダウンロードURL一覧を返す + * + * @return array + */ + public function requestedDownloadUrls(): array + { + return $this->download_calls; + } + + protected function migrationHttpCreateClient(array $http_options = []): Client + { + return new Client(); + } + + protected function migrationHttpGet(Client $http_client, string $url, array $http_options = []): array + { + $this->http_get_calls[] = $url; + + if (empty($this->queued_get_responses)) { + throw new \RuntimeException('No queued migrationHttpGet response.'); + } + + return array_shift($this->queued_get_responses); + } + + protected function migrationHttpDownloadToFile(Client $http_client, string $url, string $sink_path, array $http_options = []): array + { + $this->download_calls[] = $url; + + if (empty($this->queued_download_results)) { + throw new \RuntimeException('Unexpected migrationHttpDownloadToFile call in this test.'); + } + + $queued = array_shift($this->queued_download_results); + if ($queued['type'] === 'exception') { + throw $queued['value']; + } + + throw new \RuntimeException('Unsupported queued download result type.'); + } +} diff --git a/tests/Unit/Traits/Migration/MigrationExportNc3PageTraitTest.php b/tests/Unit/Traits/Migration/MigrationExportNc3PageTraitTest.php new file mode 100644 index 000000000..9fd2a5eff --- /dev/null +++ b/tests/Unit/Traits/Migration/MigrationExportNc3PageTraitTest.php @@ -0,0 +1,555 @@ +real_storage_page_ids_to_cleanup as $page_id) { + File::deleteDirectory(storage_path("app/migration/import/pages/{$page_id}")); + } + + parent::tearDown(); + } + + /** + * 非グローバルURLは事前検証で拒否し、インポートしないこと + * + * @return void + */ + public function testNonGlobalUrlIsNotImported() + { + $this->fakeMigrationStorage(); + + $target = new TestableMigrationExportNc3PageTraitTarget(); + + $target->runMigrationNc3Page('http://127.0.0.1/nc3/index.html', 2001); + + $this->assertSame([], $target->requestedGetUrls()); + $this->assertFrameNotSaved(2001, 1); + } + + /** + * ページ取得失敗時は中断し、フレームを保存しないこと + * + * @return void + */ + public function testImportStopsWhenPageFetchFails() + { + $this->fakeMigrationStorage(); + + $target = new TestableMigrationExportNc3PageTraitTarget(); + $target->queueGetException(new RuntimeException('network failed')); + + $url = 'http://8.8.8.8/nc3/index.html'; + $target->runMigrationNc3Page($url, 2002); + + $this->assertSame([$url], $target->requestedGetUrls()); + $this->assertFrameNotSaved(2002, 1); + } + + /** + * NC3の1フレームをConnect-CMS形式として保存できること + * + * @return void + */ + public function testSingleNc3SectionIsImportedAsSingleFrame() + { + $this->fakeMigrationStorage(); + + $target = new TestableMigrationExportNc3PageTraitTarget(); + $target->queueGetResponse([ + 'body' => $this->buildNc3Html([ + [ + 'id' => 'frame-101', + 'class' => 'panel panel-primary', + 'title' => 'Notice', + 'content' => 'BodyA
', + ], + ]), + 'http_code' => 200, + 'location' => '', + 'content_disposition' => '', + ]); + + $url = 'http://8.8.8.8/nc3/index.html'; + $page_id = 2003; + $target->runMigrationNc3Page($url, $page_id); + + $this->assertSame([$url], $target->requestedGetUrls()); + $this->assertNc3FrameSavedContains($page_id, 1, 'BodyA
'); + $this->assertStringContainsString('frame_title = "Notice"', Storage::get("migration/import/pages/{$page_id}/frame_0001.ini")); + $this->assertStringContainsString('source_key = "101"', Storage::get("migration/import/pages/{$page_id}/frame_0001.ini")); + } + + /** + * DOMDocumentの解析警告が発生するNC3 HTMLでも取り込みを継続して保存すること + * + * @return void + */ + public function testImportContinuesWhenDomDocumentEmitsHtmlParseWarnings() + { + $this->fakeMigrationStorage(); + + $target = new TestableMigrationExportNc3PageTraitTarget(); + $target->queueGetResponse([ + 'body' => $this->buildNc3Html([ + [ + 'id' => 'frame-111', + 'class' => 'panel panel-primary', + 'title' => 'WarnHtml', + 'content' => 'before &nobr; after
BodyWarn
', + ], + ]), + 'http_code' => 200, + 'location' => '', + 'content_disposition' => '', + ]); + + $url = 'http://8.8.8.8/nc3/warn.html'; + $page_id = 2009; + $target->runMigrationNc3Page($url, $page_id); + + $this->assertSame([$url], $target->requestedGetUrls()); + $this->assertNc3FrameSavedContains($page_id, 1, 'BodyWarn
'); + } + + /** + * 複数セクションを複数フレームとして保存できること + * + * @return void + */ + public function testMultipleNc3SectionsAreImportedAsMultipleFrames() + { + $this->fakeMigrationStorage(); + + $target = new TestableMigrationExportNc3PageTraitTarget(); + $target->queueGetResponse([ + 'body' => $this->buildNc3Html([ + [ + 'id' => 'frame-201', + 'class' => 'panel panel-info', + 'title' => 'Frame1', + 'content' => 'Body1
', + ], + [ + 'id' => 'frame-202', + 'class' => 'panel panel-success', + 'title' => 'Frame2', + 'content' => 'Body2
', + ], + ]), + 'http_code' => 200, + 'location' => '', + 'content_disposition' => '', + ]); + + $page_id = 2004; + $target->runMigrationNc3Page('http://8.8.8.8/nc3/multi.html', $page_id); + + $this->assertNc3FrameSavedContains($page_id, 1, 'Body1
'); + $this->assertNc3FrameSavedContains($page_id, 2, 'Body2
'); + $this->assertStringContainsString('frame_title = "Frame1"', Storage::get("migration/import/pages/{$page_id}/frame_0001.ini")); + $this->assertStringContainsString('frame_title = "Frame2"', Storage::get("migration/import/pages/{$page_id}/frame_0002.ini")); + } + + /** + * 画像ダウンロードを経由して画像参照をローカルファイル名へ置換すること + * + * @return void + */ + public function testImageDownloadIsImportedAndReferencedByLocalFileName() + { + $this->fakeMigrationStorage(); + + $target = new TestableMigrationExportNc3PageTraitTarget(); + $image_url = 'http://8.8.8.8/files/image.png'; + $target->queueGetResponse([ + 'body' => $this->buildNc3Html([ + [ + 'id' => 'frame-301', + 'class' => 'panel panel-primary', + 'title' => 'WithImage', + 'content' => 'KeepBody
', + ], + ]), + 'http_code' => 200, + 'location' => '', + 'content_disposition' => '', + ]); + $target->queueDownloadException(new RuntimeException('image download failed')); + + $page_id = 2007; + $target->runMigrationNc3Page('http://8.8.8.8/nc3/image-fail.html', $page_id); + + $this->assertSame([$image_url], $target->requestedDownloadUrls()); + $html = Storage::get("migration/import/pages/{$page_id}/frame_0001.html"); + $ini = Storage::get("migration/import/pages/{$page_id}/frame_0001.ini"); + + $this->assertStringContainsString('KeepBody', $html); + $this->assertStringContainsString($image_url, $html); + $this->assertStringNotContainsString('frame_0001_1.png', $html); + $this->assertStringContainsString('[image_names]', $ini); + $this->assertStringNotContainsString('frame_0001_1.png =', $ini); + } + + /** + * 添付ダウンロード失敗時は添付をスキップし、本文の保存は継続すること + * + * @return void + */ + public function testImportSkipsAttachmentWhenAttachmentDownloadFailsAndStillSavesBody() + { + $this->fakeMigrationStorage(); + + $target = new TestableMigrationExportNc3PageTraitTarget(); + $file_url = 'http://8.8.8.8/cabinet_files/download/999'; + $target->queueGetResponse([ + 'body' => $this->buildNc3Html([ + [ + 'id' => 'frame-601', + 'class' => 'panel panel-info', + 'title' => 'FileFail', + 'content' => 'KeepBody
', + ], + ]), + 'http_code' => 200, + 'location' => '', + 'content_disposition' => '', + ]); + $target->queueDownloadException(new RuntimeException('attachment download failed')); + + $page_id = 2008; + $target->runMigrationNc3Page('http://8.8.8.8/nc3/file-fail.html', $page_id); + + $this->assertSame([$file_url], $target->requestedDownloadUrls()); + $html = Storage::get("migration/import/pages/{$page_id}/frame_0001.html"); + $ini = Storage::get("migration/import/pages/{$page_id}/frame_0001.ini"); + + $this->assertStringContainsString('KeepBody', $html); + $this->assertStringContainsString($file_url, $html); + $this->assertStringNotContainsString('frame_0001_file_1.txt', $html); + $this->assertStringContainsString('[file_names]', $ini); + $this->assertStringNotContainsString('frame_0001_file_1.txt =', $ini); + } + + /** + * 移行用ストレージをfake化する + * + * @return void + */ + private function fakeMigrationStorage(): void + { + Storage::fake(config('filesystems.default', 'local')); + } + + /** + * 指定フレームのHTML/INIが保存されていないことを検証する + * + * @param int $page_id + * @param int $frame_index + * @return void + */ + private function assertFrameNotSaved(int $page_id, int $frame_index): void + { + $frame = sprintf('%04d', $frame_index); + Storage::assertMissing("migration/import/pages/{$page_id}/frame_{$frame}.html"); + Storage::assertMissing("migration/import/pages/{$page_id}/frame_{$frame}.ini"); + } + + /** + * 指定フレームのHTML/INIが保存され、HTMLに期待文字列を含むことを検証する + * + * @param int $page_id + * @param int $frame_index + * @param string $expected_fragment + * @return void + */ + private function assertNc3FrameSavedContains(int $page_id, int $frame_index, string $expected_fragment): void + { + $frame = sprintf('%04d', $frame_index); + Storage::assertExists("migration/import/pages/{$page_id}/frame_{$frame}.html"); + Storage::assertExists("migration/import/pages/{$page_id}/frame_{$frame}.ini"); + $this->assertStringContainsString($expected_fragment, Storage::get("migration/import/pages/{$page_id}/frame_{$frame}.html")); + } + + /** + * テスト用の最小NC3 HTMLを生成する + * + * @param array $sections + * @return string + */ + private function buildNc3Html(array $sections): string + { + $section_html = ''; + foreach ($sections as $section) { + $section_html .= '' . $section['title'] . '
';
+ $section_html .= '' . $section_html . '
';
+ }
+
+ /**
+ * 1x1 PNGのバイナリを返す
+ *
+ * @return string
+ */
+ private function tinyPngBinary(): string
+ {
+ return base64_decode('iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/x8AAwMCAO7Z0r8AAAAASUVORK5CYII=');
+ }
+}
+
+// phpcs:ignore PSR1.Classes.ClassDeclaration.MultipleClasses -- Test double is intentionally colocated with the test.
+class TestableMigrationExportNc3PageTraitTarget
+{
+ use MigrationExportNc3PageTrait {
+ migrationNC3Page as private traitMigrationNc3Page;
+ }
+
+ /** @var array */
+ private $http_get_calls = [];
+
+ /** @var array */
+ private $queued_get_results = [];
+
+ /** @var array */
+ private $download_calls = [];
+
+ /** @var array */
+ private $queued_download_results = [];
+
+ public function runMigrationNc3Page(string $url, int $page_id): void
+ {
+ $this->traitMigrationNc3Page($url, $page_id);
+ }
+
+ /**
+ * GETリクエストされたURL一覧を返す
+ *
+ * @return array
+ */
+ public function requestedGetUrls(): array
+ {
+ return $this->http_get_calls;
+ }
+
+ /**
+ * ページ取得レスポンスをキューに積む
+ *
+ * @param array $response
+ * @return void
+ */
+ public function queueGetResponse(array $response): void
+ {
+ $this->queued_get_results[] = ['type' => 'response', 'value' => $response];
+ }
+
+ /**
+ * ページ取得例外をキューに積む
+ *
+ * @param \RuntimeException $exception
+ * @return void
+ */
+ public function queueGetException(RuntimeException $exception): void
+ {
+ $this->queued_get_results[] = ['type' => 'exception', 'value' => $exception];
+ }
+
+ /**
+ * ダウンロード応答をキューに積む
+ *
+ * @param array $response
+ * @return void
+ */
+ public function queueDownloadResponse(array $response): void
+ {
+ $this->queued_download_results[] = ['type' => 'response', 'value' => $response];
+ }
+
+ /**
+ * ダウンロード例外をキューに積む
+ *
+ * @param \RuntimeException $exception
+ * @return void
+ */
+ public function queueDownloadException(RuntimeException $exception): void
+ {
+ $this->queued_download_results[] = ['type' => 'exception', 'value' => $exception];
+ }
+
+ /**
+ * ダウンロードURL一覧を返す
+ *
+ * @return array
+ */
+ public function requestedDownloadUrls(): array
+ {
+ return $this->download_calls;
+ }
+
+ protected function migrationHttpCreateClientForNc3(array $http_options = [])
+ {
+ return new Client();
+ }
+
+ protected function migrationHttpGetForNc3($http_client, string $url, array $http_options = []): array
+ {
+ $this->http_get_calls[] = $url;
+
+ if (empty($this->queued_get_results)) {
+ throw new RuntimeException('No queued migrationHttpGetForNc3 result.');
+ }
+
+ $queued = array_shift($this->queued_get_results);
+ if ($queued['type'] === 'exception') {
+ throw $queued['value'];
+ }
+
+ return $queued['value'];
+ }
+
+ protected function migrationHttpDownloadToFileForNc3($http_client, string $url, string $sink_path, array $http_options = []): array
+ {
+ $this->download_calls[] = $url;
+
+ if (empty($this->queued_download_results)) {
+ throw new RuntimeException('No queued migrationHttpDownloadToFileForNc3 result.');
+ }
+
+ $queued = array_shift($this->queued_download_results);
+ if ($queued['type'] === 'exception') {
+ throw $queued['value'];
+ }
+
+ $response = $queued['value'];
+ if (isset($response['url']) && $response['url'] !== $url) {
+ throw new RuntimeException('Unexpected download URL. expected=' . $response['url'] . ' actual=' . $url);
+ }
+
+ $bytes = (string) ($response['bytes'] ?? '');
+
+ // trait内のgetimagesize()用に実ファイルも作成する（storage_path/app直参照のため）
+ $directory = dirname($sink_path);
+ if (!is_dir($directory)) {
+ mkdir($directory, 0777, true);
+ }
+ file_put_contents($sink_path, $bytes);
+
+ // Storage::fake() 側のファイル操作（exists/move/delete）でも見えるように同時に保存する
+ $storage_app_prefix = storage_path('app') . DIRECTORY_SEPARATOR;
+ if (strpos($sink_path, $storage_app_prefix) === 0) {
+ $relative_path = str_replace(DIRECTORY_SEPARATOR, '/', substr($sink_path, strlen($storage_app_prefix)));
+ Storage::put($relative_path, $bytes);
+ }
+
+ return [
+ 'body' => '',
+ 'http_code' => (int) ($response['http_code'] ?? 200),
+ 'location' => (string) ($response['location'] ?? ''),
+ 'content_disposition' => (string) ($response['content_disposition'] ?? ''),
+ ];
+ }
+}
diff --git a/tests/Unit/Utilities/Migration/MigrationHttpClientUtilsTest.php b/tests/Unit/Utilities/Migration/MigrationHttpClientUtilsTest.php
new file mode 100644
index 000000000..3cccf1506
--- /dev/null
+++ b/tests/Unit/Utilities/Migration/MigrationHttpClientUtilsTest.php
@@ -0,0 +1,470 @@
+ 7,
+ 'connect.HTTPPROXYTUNNEL' => true,
+ 'connect.PROXY' => 'proxy.example.local',
+ 'connect.PROXYPORT' => '8080',
+ 'connect.PROXYUSERPWD' => 'user:pass',
+ ]);
+
+ $options = MigrationHttpClientUtils::buildClientOptions();
+
+ $this->assertSame(false, $options['http_errors']);
+ $this->assertSame(false, $options['allow_redirects']);
+ $this->assertSame(7.0, $options['timeout']);
+ $this->assertSame('http://user:pass@proxy.example.local:8080', $options['proxy']);
+ }
+
+ /**
+ * ランタイム指定でプロキシを無効化できること
+ *
+ * @return void
+ */
+ public function testClientOptionsCanDisableProxyWithRuntimeOption()
+ {
+ config([
+ 'connect.CURL_TIMEOUT' => 7,
+ 'connect.HTTPPROXYTUNNEL' => true,
+ 'connect.PROXY' => 'proxy.example.local',
+ 'connect.PROXYPORT' => '8080',
+ 'connect.PROXYUSERPWD' => 'user:pass',
+ ]);
+
+ $options = MigrationHttpClientUtils::buildClientOptions(['use_proxy' => false]);
+
+ $this->assertSame(false, $options['http_errors']);
+ $this->assertSame(false, $options['allow_redirects']);
+ $this->assertSame(7.0, $options['timeout']);
+ $this->assertArrayNotHasKey('proxy', $options);
+ }
+
+ /**
+ * HTTPクライアントを生成できること
+ *
+ * @return void
+ */
+ public function testHttpClientCanBeCreated()
+ {
+ config(['connect.HTTPPROXYTUNNEL' => false]);
+
+ $client = MigrationHttpClientUtils::createClient();
+
+ $this->assertInstanceOf(Client::class, $client);
+ }
+
+ /**
+ * 文字列GETでレスポンス情報が返ること
+ *
+ * @return void
+ */
+ public function testGetReturnsResponseInformation()
+ {
+ config(['connect.HTTPPROXYTUNNEL' => false]);
+
+ $captured_request = [];
+ $client = $this->createMock(Client::class);
+ $client->expects($this->once())
+ ->method('request')
+ ->willReturnCallback(function ($method, $url, $options) use (&$captured_request) {
+ $captured_request = compact('method', 'url', 'options');
+ $options['on_stats']($this->fakeStats(['primary_ip' => '8.8.8.8']));
+
+ return new Response(200, ['Location' => '/next'], 'hello');
+ });
+
+ $response = MigrationHttpClientUtils::get($client, 'https://8.8.8.8');
+
+ $this->assertSame('GET', $captured_request['method']);
+ $this->assertSame('https://8.8.8.8', $captured_request['url']);
+ $this->assertArrayHasKey('on_stats', $captured_request['options']);
+ $this->assertTrue(is_callable($captured_request['options']['on_stats']));
+ $this->assertSame('hello', $response['body']);
+ $this->assertSame(200, $response['http_code']);
+ $this->assertSame('/next', $response['location']);
+ $this->assertSame('', $response['content_disposition']);
+ }
+
+ /**
+ * DNS pinning では dual-stack の解決結果をまとめて固定し、IPv4/IPv6 の片方へ強制しないこと
+ *
+ * @return void
+ */
+ public function testGetAppliesDnsPinningWithAllGlobalResolvedAddresses()
+ {
+ if (!defined('CURLOPT_RESOLVE')) {
+ $this->markTestSkipped('CURLOPT_RESOLVE が利用できません。');
+ }
+
+ config(['connect.HTTPPROXYTUNNEL' => false]);
+
+ MigrationHttpClientUtilsDnsFunctionMocks::setDnsGetRecordCallback(function ($host, $type) {
+ $this->assertSame('example.com', $host);
+ $this->assertSame(DNS_A + DNS_AAAA, $type);
+
+ return [
+ ['ipv6' => '2001:4860:4860::8888'],
+ ['ip' => '8.8.8.8'],
+ ];
+ });
+ MigrationHttpClientUtilsDnsFunctionMocks::setGethostbynamelCallback(function ($host) {
+ $this->fail('dns_get_record() 成功時に gethostbynamel() は呼ばれない想定です。');
+ return false;
+ });
+
+ $captured_request = [];
+ $client = $this->createMock(Client::class);
+ $client->expects($this->once())
+ ->method('request')
+ ->willReturnCallback(function ($method, $url, $options) use (&$captured_request) {
+ $captured_request = compact('method', 'url', 'options');
+ $options['on_stats']($this->fakeStats(['primary_ip' => '2001:4860:4860::8888']));
+
+ return new Response(200, [], 'hello');
+ });
+
+ $response = MigrationHttpClientUtils::get($client, 'https://example.com/path');
+
+ $this->assertSame('hello', $response['body']);
+ $this->assertArrayHasKey('curl', $captured_request['options']);
+ $this->assertArrayHasKey(CURLOPT_RESOLVE, $captured_request['options']['curl']);
+ $this->assertContains(
+ 'example.com:443:[2001:4860:4860::8888],8.8.8.8',
+ $captured_request['options']['curl'][CURLOPT_RESOLVE]
+ );
+ }
+
+ /**
+ * IDN URL は DNS pinning 用にも punycode ホスト名へ正規化されること
+ *
+ * @return void
+ */
+ public function testGetNormalizesIdnHostnameForDnsPinning()
+ {
+ if (!defined('CURLOPT_RESOLVE')) {
+ $this->markTestSkipped('CURLOPT_RESOLVE が利用できません。');
+ }
+ if (!function_exists('idn_to_ascii')) {
+ $this->markTestSkipped('idn_to_ascii() が利用できません。');
+ }
+
+ config(['connect.HTTPPROXYTUNNEL' => false]);
+
+ $unicode_host = '例え.テスト';
+ $idn_flags = defined('IDNA_DEFAULT') ? IDNA_DEFAULT : 0;
+ $idn_variant = defined('INTL_IDNA_VARIANT_UTS46') ? INTL_IDNA_VARIANT_UTS46 : 0;
+ $ascii_host = idn_to_ascii($unicode_host, $idn_flags, $idn_variant);
+ $this->assertNotFalse($ascii_host);
+ $ascii_host = strtolower($ascii_host);
+
+ $captured_dns_host = '';
+ MigrationHttpClientUtilsDnsFunctionMocks::setDnsGetRecordCallback(function ($host, $type) use (&$captured_dns_host, $ascii_host) {
+ $captured_dns_host = $host;
+ $this->assertSame($ascii_host, $host);
+ $this->assertSame(DNS_A + DNS_AAAA, $type);
+
+ return [
+ ['ip' => '8.8.8.8'],
+ ];
+ });
+
+ $captured_request = [];
+ $client = $this->createMock(Client::class);
+ $client->expects($this->once())
+ ->method('request')
+ ->willReturnCallback(function ($method, $url, $options) use (&$captured_request) {
+ $captured_request = compact('method', 'url', 'options');
+ $options['on_stats']($this->fakeStats(['primary_ip' => '8.8.8.8']));
+
+ return new Response(200, [], 'hello');
+ });
+
+ $response = MigrationHttpClientUtils::get($client, 'https://' . $unicode_host . '/path');
+
+ $this->assertSame('hello', $response['body']);
+ $this->assertSame($ascii_host, $captured_dns_host);
+ $this->assertContains(
+ $ascii_host . ':443:8.8.8.8',
+ $captured_request['options']['curl'][CURLOPT_RESOLVE]
+ );
+ }
+
+ /**
+ * ファイルダウンロード時にsinkが利用され、Content-Dispositionが既存互換形式で返ること
+ *
+ * @return void
+ */
+ public function testDownloadToFileReturnsCompatibleContentDisposition()
+ {
+ config(['connect.HTTPPROXYTUNNEL' => false]);
+
+ $sink_path = '/tmp/migration-http-client-utils-test.bin';
+ $captured_request = [];
+ $client = $this->createMock(Client::class);
+ $client->expects($this->once())
+ ->method('request')
+ ->willReturnCallback(function ($method, $url, $options) use ($sink_path, &$captured_request) {
+ $captured_request = compact('method', 'url', 'options');
+ $options['on_stats']($this->fakeStats(['primary_ip' => '1.1.1.1']));
+
+ return new Response(200, [
+ 'Content-Disposition' => "attachment;filename*=UTF-8''sample.txt",
+ ], 'ignored-body');
+ });
+
+ $response = MigrationHttpClientUtils::downloadToFile($client, 'https://8.8.8.8/file', $sink_path);
+
+ $this->assertSame('GET', $captured_request['method']);
+ $this->assertSame('https://8.8.8.8/file', $captured_request['url']);
+ $this->assertSame($sink_path, $captured_request['options']['sink']);
+ $this->assertArrayHasKey('on_stats', $captured_request['options']);
+ $this->assertSame('', $response['body']);
+ $this->assertSame(200, $response['http_code']);
+ $this->assertSame('', $response['location']);
+ $this->assertSame("Content-Disposition: attachment;filename*=UTF-8''sample.txt", $response['content_disposition']);
+ }
+
+ /**
+ * 非グローバルIPへ接続された場合は例外にすること
+ *
+ * @return void
+ */
+ public function testGetFailsWhenConnectedToNonGlobalIp()
+ {
+ config(['connect.HTTPPROXYTUNNEL' => false]);
+
+ $client = $this->createMock(Client::class);
+ $client->method('request')
+ ->willReturnCallback(function ($method, $url, $options) {
+ $options['on_stats']($this->fakeStats(['primary_ip' => '127.0.0.1']));
+ return new Response(200, [], 'hello');
+ });
+
+ $this->expectException(RuntimeException::class);
+ $this->expectExceptionMessage('Rejected non-global primary_ip');
+
+ MigrationHttpClientUtils::get($client, 'https://8.8.8.8');
+ }
+
+ /**
+ * DNSリバインディング相当（検証時OK/接続時NG）の状態を拒否すること
+ *
+ * 実際のDNS操作は行わず、TOCTOUの本質である
+ * 「事前検証ではグローバル、実接続では内部IP」を擬似的に再現する。
+ *
+ * @return void
+ */
+ public function testGetRejectsDnsRebindingStylePrimaryIpChange()
+ {
+ config(['connect.HTTPPROXYTUNNEL' => false]);
+
+ $url = 'http://8.8.8.8/example';
+ $this->assertTrue(UrlUtils::isGlobalHttpUrl($url), '事前URL検証は通る前提');
+
+ $captured_request = [];
+ $client = $this->createMock(Client::class);
+ $client->method('request')
+ ->willReturnCallback(function ($method, $request_url, $options) use ($url, &$captured_request) {
+ $captured_request = [
+ 'method' => $method,
+ 'url' => $request_url,
+ 'options' => $options,
+ ];
+ // 実接続時に内部IPへ変化した状態を再現（DNSリバインディング相当）
+ $options['on_stats']($this->fakeStats(['primary_ip' => '169.254.169.254']));
+
+ return new Response(200, [], 'hello');
+ });
+
+ $this->expectException(RuntimeException::class);
+ $this->expectExceptionMessage('Rejected non-global primary_ip');
+
+ try {
+ MigrationHttpClientUtils::get($client, $url);
+ } finally {
+ $this->assertSame('GET', $captured_request['method']);
+ $this->assertSame($url, $captured_request['url']);
+ $this->assertArrayHasKey('on_stats', $captured_request['options']);
+ }
+ }
+
+ /**
+ * HTTPPROXYTUNNEL=true でも実際にproxy未設定ならprimary_ip再検証を行うこと
+ *
+ * @return void
+ */
+ public function testGetFailsWhenProxyTunnelEnabledButProxyIsNotConfigured()
+ {
+ config([
+ 'connect.HTTPPROXYTUNNEL' => true,
+ 'connect.PROXY' => '',
+ ]);
+
+ $client = $this->createMock(Client::class);
+ $client->method('request')
+ ->willReturnCallback(function ($method, $url, $options) {
+ // primary_ip を渡さない（直結通信かつ on_stats 未取得相当）
+ $options['on_stats']($this->fakeStats([]));
+ return new Response(200, [], 'direct');
+ });
+
+ $this->expectException(RuntimeException::class);
+ $this->expectExceptionMessage('Failed to verify primary_ip');
+
+ MigrationHttpClientUtils::get($client, 'https://8.8.8.8');
+ }
+
+ /**
+ * IPv4-mapped IPv6形式のprimary_ipでも元のIPv4がグローバルなら許可すること
+ *
+ * @return void
+ */
+ public function testGetAcceptsIpv4MappedIpv6PrimaryIpWhenMappedIpv4IsGlobal()
+ {
+ config(['connect.HTTPPROXYTUNNEL' => false]);
+
+ $client = $this->createMock(Client::class);
+ $client->method('request')
+ ->willReturnCallback(function ($method, $url, $options) {
+ $options['on_stats']($this->fakeStats(['primary_ip' => '::ffff:8.8.8.8']));
+ return new Response(200, [], 'hello');
+ });
+
+ $response = MigrationHttpClientUtils::get($client, 'https://8.8.8.8');
+
+ $this->assertSame('hello', $response['body']);
+ $this->assertSame(200, $response['http_code']);
+ }
+
+ /**
+ * プロキシ設定が有効な経由時はprimary_ip再検証をスキップすること
+ *
+ * @return void
+ */
+ public function testGetAllowsMissingPrimaryIpWhenUsingProxyTunnel()
+ {
+ config([
+ 'connect.HTTPPROXYTUNNEL' => true,
+ 'connect.PROXY' => 'proxy.example.local:8080',
+ ]);
+
+ $client = $this->createMock(Client::class);
+ $client->method('request')
+ ->willReturnCallback(function ($method, $url, $options) {
+ // primary_ip を渡さない（プロキシ経由時想定）
+ $options['on_stats']($this->fakeStats([]));
+ return new Response(200, [], 'proxied');
+ });
+
+ $response = MigrationHttpClientUtils::get($client, 'https://8.8.8.8');
+
+ $this->assertSame('proxied', $response['body']);
+ $this->assertSame(200, $response['http_code']);
+ }
+
+ /**
+ * ランタイム指定でプロキシを無効化した場合はprimary_ip再検証を行うこと
+ *
+ * @return void
+ */
+ public function testGetFailsWhenRuntimeOptionDisablesProxyEvenIfProxyConfigExists()
+ {
+ config([
+ 'connect.HTTPPROXYTUNNEL' => true,
+ 'connect.PROXY' => 'proxy.example.local:8080',
+ ]);
+
+ $client = $this->createMock(Client::class);
+ $client->method('request')
+ ->willReturnCallback(function ($method, $url, $options) {
+ // use_proxy=false では直結相当として primary_ip 検証対象
+ $options['on_stats']($this->fakeStats([]));
+ return new Response(200, [], 'direct-runtime');
+ });
+
+ $this->expectException(RuntimeException::class);
+ $this->expectExceptionMessage('Failed to verify primary_ip');
+
+ MigrationHttpClientUtils::get($client, 'https://8.8.8.8', ['use_proxy' => false]);
+ }
+
+ /**
+ * ランタイム指定でプロキシ利用時はprimary_ip再検証をスキップすること
+ *
+ * @return void
+ */
+ public function testGetAllowsMissingPrimaryIpWhenRuntimeUseProxyIsTrue()
+ {
+ config([
+ 'connect.HTTPPROXYTUNNEL' => true,
+ 'connect.PROXY' => 'proxy.example.local:8080',
+ ]);
+
+ $client = $this->createMock(Client::class);
+ $client->method('request')
+ ->willReturnCallback(function ($method, $url, $options) {
+ $options['on_stats']($this->fakeStats([]));
+ return new Response(200, [], 'proxied-runtime');
+ });
+
+ $response = MigrationHttpClientUtils::get($client, 'https://8.8.8.8', ['use_proxy' => true]);
+
+ $this->assertSame('proxied-runtime', $response['body']);
+ $this->assertSame(200, $response['http_code']);
+ }
+
+ /**
+ * on_stats へ渡す疑似statsオブジェクトを生成する
+ *
+ * @param array $handler_stats
+ * @return object
+ */
+ private function fakeStats(array $handler_stats)
+ {
+ return new class ($handler_stats) {
+ /** @var array */
+ private $handler_stats;
+
+ public function __construct(array $handler_stats)
+ {
+ $this->handler_stats = $handler_stats;
+ }
+
+ public function getHandlerStats(): array
+ {
+ return $this->handler_stats;
+ }
+ };
+ }
+}
diff --git a/tests/Unit/Utilities/Url/UrlUtilsTest.php b/tests/Unit/Utilities/Url/UrlUtilsTest.php
new file mode 100644
index 000000000..118ed7f1c
--- /dev/null
+++ b/tests/Unit/Utilities/Url/UrlUtilsTest.php
@@ -0,0 +1,49 @@
+assertSame($expected, UrlUtils::isGlobalHttpUrl($url), $url);
+ }
+
+ public function globalHttpUrlProvider(): array
+ {
+ return [
+ 'allow_global_ipv4_http' => ['http://8.8.8.8', true],
+ 'allow_global_ipv4_https' => ['https://1.1.1.1/path', true],
+ 'allow_global_domain' => ['https://example.com', true],
+ 'deny_non_http_scheme' => ['ftp://8.8.8.8', false],
+ 'deny_localhost' => ['http://localhost', false],
+ 'deny_localhost_subdomain' => ['http://foo.localhost', false],
+ 'deny_localhost_trailing_dot' => ['http://localhost./', false],
+ 'deny_loopback_ipv4' => ['http://127.0.0.1', false],
+ 'deny_private_ipv4' => ['http://10.0.0.1', false],
+ 'deny_private_172_ipv4' => ['http://172.16.0.1', false],
+ 'deny_private_192_ipv4' => ['http://192.168.1.1', false],
+ 'deny_unspecified_ipv4' => ['http://0.0.0.0', false],
+ 'deny_link_local_ipv4' => ['http://169.254.169.254/latest/meta-data', false],
+ 'deny_decimal_ipv4_notation' => ['http://2130706433', false],
+ 'deny_octal_ipv4_notation' => ['http://0177.0.0.1', false],
+ 'deny_loopback_ipv6' => ['http://[::1]/', false],
+ 'deny_private_ipv6_ula' => ['http://[fd00::1]/', false],
+ 'deny_ipv4_mapped_loopback_ipv6' => ['http://[::ffff:127.0.0.1]/', false],
+ 'deny_ipv4_mapped_link_local_ipv6' => ['http://[::ffff:169.254.169.254]/', false],
+ 'deny_ipv4_mapped_expanded_ipv6' => ['http://[0:0:0:0:0:ffff:7f00:1]/', false],
+ 'deny_empty_string' => ['', false],
+ 'deny_scheme_only' => ['http://', false],
+ 'deny_protocol_relative_url' => ['//example.com', false],
+ 'deny_data_scheme' => ['data:text/html,