You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My understanding is this repository leverages the yaml semantic conventions defined by the community to generate Python files, and prior to that PR, generally just constants.
From what I see, scripts/semconv/templates/semantic_metrics.j2 was modified to include helper functions to actually create different Instruments. Shouldn't this be an API concern?
I've checked the Golang and JS repos and those jinja templates do not generate API level invocations.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
I'd like to understand the choice to make the semantic conventions library depend on the API library.
This was introduced in #3586
My understanding is this repository leverages the yaml semantic conventions defined by the community to generate Python files, and prior to that PR, generally just constants.
From what I see,
scripts/semconv/templates/semantic_metrics.j2was modified to include helper functions to actually create different Instruments. Shouldn't this be an API concern?I've checked the Golang and JS repos and those jinja templates do not generate API level invocations.
See also: open-telemetry/semantic-conventions#551
Beta Was this translation helpful? Give feedback.
All reactions