Skip to content

S3: Constructor Should Validate Critical Parameters #34

@liobrasil

Description

@liobrasil

Auditor Suggestion

Files Affected

  • solidity/src/FlowYieldVaultsRequests.sol

Description

  1. The constructor accepts coaAddress without validating it's non-zero. While the owner can fix this via setAuthorizedCOA() (which does validate), deploying with coaAddress = address(0) creates a temporarily broken contract where all COA-gated functions revert until fixed.

  2. Similarly, minimumBalance could be validated to be > 0 to prevent dust spam.

Recommendation

Add the recommended validations to the constructor.


Parent Issue: #15

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions