Add a label to note “this is good for CI”

[mcollina]

Currently, only approved PRs can trigger CI. However, this is unpractical because I often LGTM things to see what’s the state in CI (sorry, I’m lazy).

Is it possible to improve our automation to know on which commit the request-ci label was applied to, and if this was applied by a collaborator, trust it?

[jasnell]

For this I would usually just launch the ci job manually.

[panva]

If you can be bothered to do this from a console

request-ci () {
	if [ $# -eq 0 ]
	then
		echo "Usage: request-ci <PR_NUMBER>"
		echo "Example: request-ci 123"
		return 1
	fi
	local pr_number=$1 
	echo "Getting last commit SHA for PR #${pr_number}..."
	local last_commit_sha=$(gh pr view $pr_number --json commits --jq '.commits[-1].oid') 
	if [ -z "$last_commit_sha" ]
	then
		echo "Error: Could not retrieve commit SHA for PR #${pr_number}"
		return 1
	fi
	echo "Last commit SHA: $last_commit_sha"
	echo "About to run: ncu-ci run $pr_number --certify-safe $last_commit_sha"
	echo -n "Do you want to proceed? (y/N): "
	read -r confirmation
	if [[ "$confirmation" =~ ^[Yy]$ ]]
	then
		echo "Running CI..."
		ncu-ci run $pr_number --certify-safe $last_commit_sha
	else
		echo "CI request cancelled."
		return 0
	fi
}

[joyeecheung]

I think I suggested somewhere in https://github.com/nodejs/node-core-utils/issues that we could just allow it in the CI if the commit to test was pushed by a collaborator. In any case the logic needs to happen in there..

[aduh95]

To start a CI from the CLI, ncu-ci run <url-of-the-commit-to-test> does the job, e.g. ncu-ci run https://github.com/nodejs/node/pull/62379/commits/ccc837f89e282530e44348d5e6ec3f32058fcd44

[aduh95]

Is it possible to improve our automation to know on which commit the request-ci label was applied to

No it's not possible, GH API does not give us that information.

In nodejs/node-core-utils#920, I have worked on making it work by parsing comments (so if a collaborator comments @nodejs-github-bot test ccc837f89e282530e44348d5e6ec3f32058fcd44, the CI would know to trust that commit), but it's actually more work for the collaborator than using the CLI, and using GH comments is not very elegant (sends notifications to everyone subscribed, can be edited, no auto-complete so easy to mess up syntax, etc)

[aduh95]

I've opened #62524 which should already improve the UX