From b269cabf5e79871713ff992b7f9176582b9809f0 Mon Sep 17 00:00:00 2001 From: nfebe Date: Thu, 23 Apr 2026 05:57:52 +0100 Subject: [PATCH 1/2] fix(files_sharing): Drop trailing '?' from public download redirect URL Public share download links now redirect to the public DAV endpoint cleanly when no additional query parameters are present. Previously the redirect always appended a trailing '?' to the target URL, which caused an Internal Server Error for clients that called the legacy download endpoint without query parameters (e.g. the Thunderbird FileLink extension). Links shared before this change are resolvable again. Signed-off-by: nfebe --- apps/files_sharing/lib/Controller/ShareController.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/apps/files_sharing/lib/Controller/ShareController.php b/apps/files_sharing/lib/Controller/ShareController.php index 6f5693a26d25c..e25f299375781 100644 --- a/apps/files_sharing/lib/Controller/ShareController.php +++ b/apps/files_sharing/lib/Controller/ShareController.php @@ -405,7 +405,9 @@ public function downloadShare($token, $files = null, $path = '') { } $davUrl = '/public.php/dav/files/' . $token . $davPath; - $davUrl .= '?' . http_build_query($params); + if (!empty($params)) { + $davUrl .= '?' . http_build_query($params); + } return new RedirectResponse($this->urlGenerator->getAbsoluteURL($davUrl)); } } From 97798a37268426f366a62952c233a413d43289bb Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 23 Apr 2026 23:34:58 +0000 Subject: [PATCH 2/2] chore: re-trigger CI (transient infrastructure failures) Co-authored-by: joshtrichards <1731941+joshtrichards@users.noreply.github.com>