From f509569223b242a78a69d3470141123c73dd74f8 Mon Sep 17 00:00:00 2001 From: unknown Date: Tue, 20 Jan 2026 10:54:45 +0100 Subject: [PATCH 01/18] added yml file for testing PRs on LTX runner --- .github/workflows/PRTesting.yml | 152 ++++++++++++++++++++++++++++++++ 1 file changed, 152 insertions(+) create mode 100644 .github/workflows/PRTesting.yml diff --git a/.github/workflows/PRTesting.yml b/.github/workflows/PRTesting.yml new file mode 100644 index 0000000000..53ec457a6b --- /dev/null +++ b/.github/workflows/PRTesting.yml @@ -0,0 +1,152 @@ +# This is a basic workflow to help you get started with Actions + +name: PR_testing + +# Controls when the workflow will run +on: + # Triggers the workflow on push or pull request events but only for the "main" branch + pull_request: + + # Allows you to run this workflow manually from the Actions tab + workflow_dispatch: + +# A workflow run is made up of one or more jobs that can run sequentially or in parallel +jobs: + prepare: + runs-on: self-hosted + outputs: + GITHUB_HASH: ${{ steps.get_hashes.outputs.GITHUB_HASH }} + GITHUB_OLDHASH: ${{ steps.get_hashes.outputs.GITHUB_OLDHASH }} + + steps: + - uses: actions/checkout@v4 + - name: compile_msl_binaries + run: | + docker run --name compile_msl --rm -u 0 --volume ${{ github.workspace }}\\..:/msl --entrypoint=/msl/run_scripts/compile_msl.sh dymola_image + - name: get_hashes + id: get_hashes + shell: powershell + run: | + $gitout = git show -s --format=%s + $_, $hash, $_,$oldhash = $gitout.split(" ") + echo "GITHUB_HASH=$(echo $hash.subString(0,8))" >> $env:GITHUB_OUTPUT + echo "GITHUB_OLDHASH=$(echo $oldhash.subString(0,8))" >> $env:GITHUB_OUTPUT + - name: delete_old_data + run: docker run --name compile_msl --rm -u 0 --volume shared_data:/shared_data --volume ${{ github.workspace }}\\..:/msl --entrypoint "/msl/run_scripts/delete_old_pr.sh ${{ github.event.number }}" dymola_image + # This workflow contains a single job called "build" + testrun_dymola_modelica: + # The type of runner that the job will run on + needs: prepare + runs-on: self-hosted + env: + GITHUB_HASH: ${{ needs.prepare.outputs.GITHUB_HASH }} + GITHUB_OLDHASH: ${{ needs.prepare.outputs.GITHUB_OLDHASH }} + # Steps represent a sequence of tasks that will be executed as part of the job + steps: + - name: run the docker image + run: docker run --name dymola_pr_compare_${{ github.event.number }} --volume shared_data:/shared_data --volume ${{ github.workspace }}\\..:/msl --volume ${{ github.workspace }}\\..\\..\\..\\..\\Output:/master dymola_image python /msl/run_scripts/Dymola_PR_compare.py $($env:GITHUB_OLDHASH) ${{ github.event.number }} Modelica + - name: tidy up + if: always() + run: docker rm dymola_pr_compare_${{ github.event.number }} + + # This workflow contains a single job called "build" + testrun_om_modelica: + # The type of runner that the job will run on + needs: prepare + runs-on: self-hosted + env: + GITHUB_HASH: ${{ needs.prepare.outputs.GITHUB_HASH }} + GITHUB_OLDHASH: ${{ needs.prepare.outputs.GITHUB_OLDHASH }} + # Steps represent a sequence of tasks that will be executed as part of the job + steps: + - name: print envs + run: echo 4 "$($env:GITHUB_HASH)" + + - name: run the docker image + run: docker run --name om_pr_compare_${{ github.event.number }} --volume shared_data:/shared_data --volume ${{ github.workspace }}\\..:/msl --volume ${{ github.workspace }}\\..\\..\\..\\..\\Output:/master om_image python /msl/run_scripts/OM_PR_compare.py $($env:GITHUB_OLDHASH) ${{ github.event.number }} Modelica + + - name: tidy up + if: always() + run: docker rm om_pr_compare_${{ github.event.number }} + #docker run --name testrun_om_modelica_$($env:GITHUB_HASH) --volume shared_data:/shared_data --volume ${{ github.workspace }}\\..:/msl om_image python /msl/run_scripts/start_om_docker_modelica.py $($env:GITHUB_HASH) $($env:GITHUB_OLDHASH) + + create_overview_modelica: + needs: [testrun_dymola_modelica, testrun_om_modelica] + runs-on: self-hosted + if: always() + steps: + - name: run the docker image + run: docker run --name create_overview --volume shared_data:/shared_data --volume ${{ github.workspace }}\\..:/msl om_image python /msl/run_scripts/overview_report.py ${{ github.event.number }} Modelica + + - name: copy back report + if: always() + run: | + docker cp create_overview:/shared_data/resim_output/PRs/PR_${{ github.event.number }}/Modelica/report.zip ${{ github.workspace }}\\..\\..\\ReSim_Output\\PR_${{ github.event.number }}_report_Modelica.zip + + - name: tidy up + if: always() + run: docker rm create_overview + + - uses: actions/upload-artifact@v4.4.0 + if: always() + with: + name: report_PR_${{ github.event.number }}_Modelica + path: D:\\MSL_Nightly\\ActionRunner\\work\\ReSim_Output\\PR_${{ github.event.number }}_report_Modelica.zip # or path/to/artifact + + testrun_dymola_modelicatest: + # The type of runner that the job will run on + needs: prepare + runs-on: self-hosted + env: + GITHUB_HASH: ${{ needs.prepare.outputs.GITHUB_HASH }} + GITHUB_OLDHASH: ${{ needs.prepare.outputs.GITHUB_OLDHASH }} + # Steps represent a sequence of tasks that will be executed as part of the job + steps: + - name: run the docker image + run: docker run --name dymola_pr_compare_${{ github.event.number }} --volume shared_data:/shared_data --volume ${{ github.workspace }}\\..:/msl --volume ${{ github.workspace }}\\..\\..\\..\\..\\Output:/master dymola_image python /msl/run_scripts/Dymola_PR_compare.py $($env:GITHUB_OLDHASH) ${{ github.event.number }} ModelicaTest + - name: tidy up + if: always() + run: docker rm dymola_pr_compare_${{ github.event.number }} + + testrun_om_modelicatest: + # The type of runner that the job will run on + needs: prepare + runs-on: self-hosted + env: + GITHUB_HASH: ${{ needs.prepare.outputs.GITHUB_HASH }} + GITHUB_OLDHASH: ${{ needs.prepare.outputs.GITHUB_OLDHASH }} + # Steps represent a sequence of tasks that will be executed as part of the job + steps: + - name: print envs + run: echo 4 "$($env:GITHUB_HASH)" + + - name: run the docker image + run: docker run --name om_pr_compare_${{ github.event.number }} --volume shared_data:/shared_data --volume ${{ github.workspace }}\\..:/msl --volume ${{ github.workspace }}\\..\\..\\..\\..\\Output:/master om_image python /msl/run_scripts/OM_PR_compare.py $($env:GITHUB_OLDHASH) ${{ github.event.number }} ModelicaTest + + - name: tidy up + if: always() + run: docker rm om_pr_compare_${{ github.event.number }} + + create_overview_modelicatest: + needs: [testrun_dymola_modelicatest, testrun_om_modelicatest] + runs-on: self-hosted + if: always() + steps: + - name: run the docker image + run: docker run --name create_overview --volume shared_data:/shared_data --volume ${{ github.workspace }}\\..:/msl om_image python /msl/run_scripts/overview_report.py ${{ github.event.number }} ModelicaTest + + - name: copy back report + if: always() + run: | + docker cp create_overview:/shared_data/resim_output/PRs/PR_${{ github.event.number }}/ModelicaTest/report.zip ${{ github.workspace }}\\..\\..\\ReSim_Output\\PR_${{ github.event.number }}_report_ModelicaTest.zip + + - name: tidy up + if: always() + run: docker rm create_overview + + - uses: actions/upload-artifact@v4.4.0 + if: always() + with: + name: report_PR_${{ github.event.number }}_ModelicaTest + path: D:\\MSL_Nightly\\ActionRunner\\work\\ReSim_Output\\PR_${{ github.event.number }}_report_ModelicaTest.zip # or path/to/artifact + \ No newline at end of file From 2bab916a0482de5884bbcfeb63a2dedee1b1d1ce Mon Sep 17 00:00:00 2001 From: unknown Date: Tue, 20 Jan 2026 11:19:50 +0100 Subject: [PATCH 02/18] initialize PR_testing on LTX devices --- .github/workflows/PRTesting.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/PRTesting.yml b/.github/workflows/PRTesting.yml index 53ec457a6b..c05c208b30 100644 --- a/.github/workflows/PRTesting.yml +++ b/.github/workflows/PRTesting.yml @@ -32,7 +32,7 @@ jobs: echo "GITHUB_HASH=$(echo $hash.subString(0,8))" >> $env:GITHUB_OUTPUT echo "GITHUB_OLDHASH=$(echo $oldhash.subString(0,8))" >> $env:GITHUB_OUTPUT - name: delete_old_data - run: docker run --name compile_msl --rm -u 0 --volume shared_data:/shared_data --volume ${{ github.workspace }}\\..:/msl --entrypoint "/msl/run_scripts/delete_old_pr.sh ${{ github.event.number }}" dymola_image + run: docker run --name compile_msl --rm -u 0 --volume shared_data:/shared_data --volume ${{ github.workspace }}\\..:/msl --entrypoint=/msl/run_scripts/delete_old_PRs.sh dymola_image ${{ github.event.number }} # This workflow contains a single job called "build" testrun_dymola_modelica: # The type of runner that the job will run on From 45b4fbc1d1fb5db5bdc8620e28c594148bf18410 Mon Sep 17 00:00:00 2001 From: unknown Date: Tue, 20 Jan 2026 11:58:25 +0100 Subject: [PATCH 03/18] DUMMY: Only4PRTesting: add whitespaces to CombiTimeTable --- Modelica/Blocks/Sources.mo | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Modelica/Blocks/Sources.mo b/Modelica/Blocks/Sources.mo index 8fbd5f270a..efc97809c3 100644 --- a/Modelica/Blocks/Sources.mo +++ b/Modelica/Blocks/Sources.mo @@ -1635,7 +1635,7 @@ parameter Real table[:, 2]=[0, 0; 1, 1; 2, 4]; parameter SI.Time shiftTime=startTime "Shift time of first table column" annotation (Dialog(group="Table data interpretation")); - parameter Modelica.Blocks.Types.TimeEvents timeEvents=Modelica.Blocks.Types.TimeEvents.Always + parameter Modelica.Blocks.Types.TimeEvents timeEvents = Modelica.Blocks.Types.TimeEvents.Always "Time event handling of table interpolation" annotation (Dialog(group="Table data interpretation", enable=smoothness == Modelica.Blocks.Types.Smoothness.LinearSegments)); parameter Boolean verboseExtrapolation=false @@ -1650,7 +1650,7 @@ parameter Real table[:, 2]=[0, 0; 1, 1; 2, 4]; final parameter Real t_maxScaled=Internal.getTimeTableTmax(tableID) "Maximum (scaled) abscissa value defined in table"; protected - final parameter Real p_offset[nout]=(if size(offset, 1) == 1 then ones(nout)*offset[1] else offset) + final parameter Real p_offset[nout] = (if size(offset, 1) == 1 then ones(nout)*offset[1] else offset) "Offsets of output signals"; parameter Modelica.Blocks.Types.ExternalCombiTimeTable tableID= Modelica.Blocks.Types.ExternalCombiTimeTable( From daf4de94c82f36fe6135746d30d8de3259b03d36 Mon Sep 17 00:00:00 2001 From: Matthias Schaefer <86839591+MatthiasBSchaefer@users.noreply.github.com> Date: Fri, 23 Jan 2026 15:05:55 +0100 Subject: [PATCH 04/18] Update PRTesting.yml fetching 5 commits hopefully we are then able to compare with the branch to be merged with --- .github/workflows/PRTesting.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/PRTesting.yml b/.github/workflows/PRTesting.yml index c05c208b30..1af9418550 100644 --- a/.github/workflows/PRTesting.yml +++ b/.github/workflows/PRTesting.yml @@ -19,7 +19,9 @@ jobs: GITHUB_OLDHASH: ${{ steps.get_hashes.outputs.GITHUB_OLDHASH }} steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v6 + with: + fetch-depth: 5 - name: compile_msl_binaries run: | docker run --name compile_msl --rm -u 0 --volume ${{ github.workspace }}\\..:/msl --entrypoint=/msl/run_scripts/compile_msl.sh dymola_image @@ -149,4 +151,4 @@ jobs: with: name: report_PR_${{ github.event.number }}_ModelicaTest path: D:\\MSL_Nightly\\ActionRunner\\work\\ReSim_Output\\PR_${{ github.event.number }}_report_ModelicaTest.zip # or path/to/artifact - \ No newline at end of file + From 3a4586b9b789fdc5cb760778f670f7a485f9b841 Mon Sep 17 00:00:00 2001 From: Matthias Schaefer Date: Thu, 5 Mar 2026 14:56:05 +0100 Subject: [PATCH 05/18] Adapt yml file for pr testing on linux server --- .github/workflows/PRTesting.yml | 153 ++++---------------------------- 1 file changed, 17 insertions(+), 136 deletions(-) diff --git a/.github/workflows/PRTesting.yml b/.github/workflows/PRTesting.yml index 1af9418550..e4de541550 100644 --- a/.github/workflows/PRTesting.yml +++ b/.github/workflows/PRTesting.yml @@ -1,8 +1,4 @@ -# This is a basic workflow to help you get started with Actions - name: PR_testing - -# Controls when the workflow will run on: # Triggers the workflow on push or pull request events but only for the "main" branch pull_request: @@ -13,142 +9,27 @@ on: # A workflow run is made up of one or more jobs that can run sequentially or in parallel jobs: prepare: - runs-on: self-hosted - outputs: - GITHUB_HASH: ${{ steps.get_hashes.outputs.GITHUB_HASH }} - GITHUB_OLDHASH: ${{ steps.get_hashes.outputs.GITHUB_OLDHASH }} - + runs-on: self-hosted steps: - - uses: actions/checkout@v6 - with: - fetch-depth: 5 - - name: compile_msl_binaries - run: | - docker run --name compile_msl --rm -u 0 --volume ${{ github.workspace }}\\..:/msl --entrypoint=/msl/run_scripts/compile_msl.sh dymola_image - - name: get_hashes - id: get_hashes - shell: powershell - run: | - $gitout = git show -s --format=%s - $_, $hash, $_,$oldhash = $gitout.split(" ") - echo "GITHUB_HASH=$(echo $hash.subString(0,8))" >> $env:GITHUB_OUTPUT - echo "GITHUB_OLDHASH=$(echo $oldhash.subString(0,8))" >> $env:GITHUB_OUTPUT - - name: delete_old_data - run: docker run --name compile_msl --rm -u 0 --volume shared_data:/shared_data --volume ${{ github.workspace }}\\..:/msl --entrypoint=/msl/run_scripts/delete_old_PRs.sh dymola_image ${{ github.event.number }} - # This workflow contains a single job called "build" - testrun_dymola_modelica: - # The type of runner that the job will run on - needs: prepare - runs-on: self-hosted - env: - GITHUB_HASH: ${{ needs.prepare.outputs.GITHUB_HASH }} - GITHUB_OLDHASH: ${{ needs.prepare.outputs.GITHUB_OLDHASH }} - # Steps represent a sequence of tasks that will be executed as part of the job - steps: - - name: run the docker image - run: docker run --name dymola_pr_compare_${{ github.event.number }} --volume shared_data:/shared_data --volume ${{ github.workspace }}\\..:/msl --volume ${{ github.workspace }}\\..\\..\\..\\..\\Output:/master dymola_image python /msl/run_scripts/Dymola_PR_compare.py $($env:GITHUB_OLDHASH) ${{ github.event.number }} Modelica - - name: tidy up - if: always() - run: docker rm dymola_pr_compare_${{ github.event.number }} + - name: checkout_pr_repo + run: /shared_data/run_scripts/prepare_pr.sh ${{ github.event.number }} - # This workflow contains a single job called "build" - testrun_om_modelica: - # The type of runner that the job will run on - needs: prepare - runs-on: self-hosted - env: - GITHUB_HASH: ${{ needs.prepare.outputs.GITHUB_HASH }} - GITHUB_OLDHASH: ${{ needs.prepare.outputs.GITHUB_OLDHASH }} - # Steps represent a sequence of tasks that will be executed as part of the job - steps: - - name: print envs - run: echo 4 "$($env:GITHUB_HASH)" - - - name: run the docker image - run: docker run --name om_pr_compare_${{ github.event.number }} --volume shared_data:/shared_data --volume ${{ github.workspace }}\\..:/msl --volume ${{ github.workspace }}\\..\\..\\..\\..\\Output:/master om_image python /msl/run_scripts/OM_PR_compare.py $($env:GITHUB_OLDHASH) ${{ github.event.number }} Modelica - - - name: tidy up - if: always() - run: docker rm om_pr_compare_${{ github.event.number }} - #docker run --name testrun_om_modelica_$($env:GITHUB_HASH) --volume shared_data:/shared_data --volume ${{ github.workspace }}\\..:/msl om_image python /msl/run_scripts/start_om_docker_modelica.py $($env:GITHUB_HASH) $($env:GITHUB_OLDHASH) - - create_overview_modelica: - needs: [testrun_dymola_modelica, testrun_om_modelica] - runs-on: self-hosted - if: always() - steps: - - name: run the docker image - run: docker run --name create_overview --volume shared_data:/shared_data --volume ${{ github.workspace }}\\..:/msl om_image python /msl/run_scripts/overview_report.py ${{ github.event.number }} Modelica - - - name: copy back report - if: always() - run: | - docker cp create_overview:/shared_data/resim_output/PRs/PR_${{ github.event.number }}/Modelica/report.zip ${{ github.workspace }}\\..\\..\\ReSim_Output\\PR_${{ github.event.number }}_report_Modelica.zip - - - name: tidy up - if: always() - run: docker rm create_overview - - - uses: actions/upload-artifact@v4.4.0 - if: always() - with: - name: report_PR_${{ github.event.number }}_Modelica - path: D:\\MSL_Nightly\\ActionRunner\\work\\ReSim_Output\\PR_${{ github.event.number }}_report_Modelica.zip # or path/to/artifact - - testrun_dymola_modelicatest: - # The type of runner that the job will run on + testrun_modelica: needs: prepare runs-on: self-hosted - env: - GITHUB_HASH: ${{ needs.prepare.outputs.GITHUB_HASH }} - GITHUB_OLDHASH: ${{ needs.prepare.outputs.GITHUB_OLDHASH }} - # Steps represent a sequence of tasks that will be executed as part of the job - steps: - - name: run the docker image - run: docker run --name dymola_pr_compare_${{ github.event.number }} --volume shared_data:/shared_data --volume ${{ github.workspace }}\\..:/msl --volume ${{ github.workspace }}\\..\\..\\..\\..\\Output:/master dymola_image python /msl/run_scripts/Dymola_PR_compare.py $($env:GITHUB_OLDHASH) ${{ github.event.number }} ModelicaTest - - name: tidy up - if: always() - run: docker rm dymola_pr_compare_${{ github.event.number }} - - testrun_om_modelicatest: - # The type of runner that the job will run on + environment: + name: test + url: https://serv.ltx.de/prs/${{ github.event.number }}/Modelica/PR_comparison_report.html + steps: + - name: run modelica + run: /shared_data/run_pr.sh ${{ github.event.number }} ${{ github.event.pull_request.base.sha }} Modelica + + testrun_modelicatest: needs: prepare runs-on: self-hosted - env: - GITHUB_HASH: ${{ needs.prepare.outputs.GITHUB_HASH }} - GITHUB_OLDHASH: ${{ needs.prepare.outputs.GITHUB_OLDHASH }} - # Steps represent a sequence of tasks that will be executed as part of the job + environment: + name: test + url: https://serv.ltx.de/prs/${{ github.event.number }}/ModelicaTest/PR_comparison_report.html steps: - - name: print envs - run: echo 4 "$($env:GITHUB_HASH)" - - - name: run the docker image - run: docker run --name om_pr_compare_${{ github.event.number }} --volume shared_data:/shared_data --volume ${{ github.workspace }}\\..:/msl --volume ${{ github.workspace }}\\..\\..\\..\\..\\Output:/master om_image python /msl/run_scripts/OM_PR_compare.py $($env:GITHUB_OLDHASH) ${{ github.event.number }} ModelicaTest - - - name: tidy up - if: always() - run: docker rm om_pr_compare_${{ github.event.number }} - - create_overview_modelicatest: - needs: [testrun_dymola_modelicatest, testrun_om_modelicatest] - runs-on: self-hosted - if: always() - steps: - - name: run the docker image - run: docker run --name create_overview --volume shared_data:/shared_data --volume ${{ github.workspace }}\\..:/msl om_image python /msl/run_scripts/overview_report.py ${{ github.event.number }} ModelicaTest - - - name: copy back report - if: always() - run: | - docker cp create_overview:/shared_data/resim_output/PRs/PR_${{ github.event.number }}/ModelicaTest/report.zip ${{ github.workspace }}\\..\\..\\ReSim_Output\\PR_${{ github.event.number }}_report_ModelicaTest.zip - - - name: tidy up - if: always() - run: docker rm create_overview - - - uses: actions/upload-artifact@v4.4.0 - if: always() - with: - name: report_PR_${{ github.event.number }}_ModelicaTest - path: D:\\MSL_Nightly\\ActionRunner\\work\\ReSim_Output\\PR_${{ github.event.number }}_report_ModelicaTest.zip # or path/to/artifact - + - name: run modelicatest + run: /shared_data/run_pr.sh ${{ github.event.number }} ${{ github.event.pull_request.base.sha }} ModelicaTest From ade1b0cac8127ca4cb7f2d16ec0cbea1ac4878f8 Mon Sep 17 00:00:00 2001 From: Matthias Schaefer <86839591+MatthiasBSchaefer@users.noreply.github.com> Date: Thu, 5 Mar 2026 15:39:23 +0100 Subject: [PATCH 06/18] Update PRTesting.yml : correct paths --- .github/workflows/PRTesting.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/PRTesting.yml b/.github/workflows/PRTesting.yml index e4de541550..699c5ef1f9 100644 --- a/.github/workflows/PRTesting.yml +++ b/.github/workflows/PRTesting.yml @@ -12,7 +12,7 @@ jobs: runs-on: self-hosted steps: - name: checkout_pr_repo - run: /shared_data/run_scripts/prepare_pr.sh ${{ github.event.number }} + run: /home/resimuser/regression_testing/docker/work/run_scripts/prepare_pr.sh ${{ github.event.number }} testrun_modelica: needs: prepare @@ -22,7 +22,7 @@ jobs: url: https://serv.ltx.de/prs/${{ github.event.number }}/Modelica/PR_comparison_report.html steps: - name: run modelica - run: /shared_data/run_pr.sh ${{ github.event.number }} ${{ github.event.pull_request.base.sha }} Modelica + run: /home/resimuser/regression_testing/docker/work/run_scripts/run_pr.sh ${{ github.event.number }} ${{ github.event.pull_request.base.sha }} Modelica testrun_modelicatest: needs: prepare @@ -32,4 +32,4 @@ jobs: url: https://serv.ltx.de/prs/${{ github.event.number }}/ModelicaTest/PR_comparison_report.html steps: - name: run modelicatest - run: /shared_data/run_pr.sh ${{ github.event.number }} ${{ github.event.pull_request.base.sha }} ModelicaTest + run: /home/resimuser/regression_testing/docker/work/run_scripts/run_pr.sh ${{ github.event.number }} ${{ github.event.pull_request.base.sha }} ModelicaTest From 3787f03cb44a97feb83939b77add62e29d389d1d Mon Sep 17 00:00:00 2001 From: Matthias Schaefer <86839591+MatthiasBSchaefer@users.noreply.github.com> Date: Thu, 5 Mar 2026 15:46:21 +0100 Subject: [PATCH 07/18] adding spaces in Sources.mo --- Modelica/Blocks/Sources.mo | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Modelica/Blocks/Sources.mo b/Modelica/Blocks/Sources.mo index efc97809c3..718977bebb 100644 --- a/Modelica/Blocks/Sources.mo +++ b/Modelica/Blocks/Sources.mo @@ -1595,16 +1595,16 @@ parameter Real table[:, 2]=[0, 0; 1, 1; 2, 4]; parameter Real table[:, :] = fill(0.0, 0, 2) "Table matrix (time = first column; e.g., table=[0, 0; 1, 1; 2, 4])" annotation (Dialog(group="Table data definition",enable=not tableOnFile)); - parameter String tableName="NoName" + parameter String tableName = "NoName" "Table name on file or in function usertab (see docu)" annotation (Dialog(group="Table data definition",enable=tableOnFile)); - parameter String fileName="NoName" "File where matrix is stored" + parameter String fileName = "NoName" "File where matrix is stored" annotation (Dialog( group="Table data definition", enable=tableOnFile, loadSelector(filter="Text files (*.txt);;MATLAB MAT-files (*.mat);;Comma-separated values files (*.csv)", caption="Open file in which table is present"))); - parameter String delimiter="," "Column delimiter character for CSV file" + parameter String delimiter = "," "Column delimiter character for CSV file" annotation (Dialog( group="Table data definition", enable=tableOnFile and isCsvExt), @@ -1618,10 +1618,10 @@ parameter Real table[:, 2]=[0, 0; 1, 1; 2, 4]; "Columns of table to be interpolated" annotation (Dialog(group="Table data interpretation", groupImage="modelica://Modelica/Resources/Images/Blocks/Sources/CombiTimeTable.png")); - parameter Modelica.Blocks.Types.Smoothness smoothness=Modelica.Blocks.Types.Smoothness.LinearSegments + parameter Modelica.Blocks.Types.Smoothness smoothness = Modelica.Blocks.Types.Smoothness.LinearSegments "Smoothness of table interpolation" annotation (Dialog(group="Table data interpretation")); - parameter Modelica.Blocks.Types.Extrapolation extrapolation=Modelica.Blocks.Types.Extrapolation.LastTwoPoints + parameter Modelica.Blocks.Types.Extrapolation extrapolation = Modelica.Blocks.Types.Extrapolation.LastTwoPoints "Extrapolation of data outside the definition range" annotation (Dialog(group="Table data interpretation")); parameter SI.Time timeScale( From 5d0440ce218688707fd5042ad3325634dca2251b Mon Sep 17 00:00:00 2001 From: Matthias Schaefer <86839591+MatthiasBSchaefer@users.noreply.github.com> Date: Sat, 7 Mar 2026 10:20:33 +0100 Subject: [PATCH 08/18] Update PRTesting.yml correct url to reports --- .github/workflows/PRTesting.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/PRTesting.yml b/.github/workflows/PRTesting.yml index 699c5ef1f9..9e40218ed0 100644 --- a/.github/workflows/PRTesting.yml +++ b/.github/workflows/PRTesting.yml @@ -19,7 +19,7 @@ jobs: runs-on: self-hosted environment: name: test - url: https://serv.ltx.de/prs/${{ github.event.number }}/Modelica/PR_comparison_report.html + url: https://serv.ltx.de/prs/${{ github.event.number }}/report/Modelica/PR_comparison_report.html steps: - name: run modelica run: /home/resimuser/regression_testing/docker/work/run_scripts/run_pr.sh ${{ github.event.number }} ${{ github.event.pull_request.base.sha }} Modelica @@ -29,7 +29,7 @@ jobs: runs-on: self-hosted environment: name: test - url: https://serv.ltx.de/prs/${{ github.event.number }}/ModelicaTest/PR_comparison_report.html + url: https://serv.ltx.de/prs/${{ github.event.number }}/ModelicaTest/report/PR_comparison_report.html steps: - name: run modelicatest run: /home/resimuser/regression_testing/docker/work/run_scripts/run_pr.sh ${{ github.event.number }} ${{ github.event.pull_request.base.sha }} ModelicaTest From 66e8dc463a7b2b3ad75630b6f233cf32f8f981e1 Mon Sep 17 00:00:00 2001 From: Matthias Schaefer <86839591+MatthiasBSchaefer@users.noreply.github.com> Date: Sat, 7 Mar 2026 10:21:06 +0100 Subject: [PATCH 09/18] Update PRTesting.yml correct url to reports 2.0 --- .github/workflows/PRTesting.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/PRTesting.yml b/.github/workflows/PRTesting.yml index 9e40218ed0..b10947facf 100644 --- a/.github/workflows/PRTesting.yml +++ b/.github/workflows/PRTesting.yml @@ -19,7 +19,7 @@ jobs: runs-on: self-hosted environment: name: test - url: https://serv.ltx.de/prs/${{ github.event.number }}/report/Modelica/PR_comparison_report.html + url: https://serv.ltx.de/prs/${{ github.event.number }}/Modelica/report/PR_comparison_report.html steps: - name: run modelica run: /home/resimuser/regression_testing/docker/work/run_scripts/run_pr.sh ${{ github.event.number }} ${{ github.event.pull_request.base.sha }} Modelica From daf479fb2ae0c00db63c4321861a4f79be16697a Mon Sep 17 00:00:00 2001 From: Matthias Schaefer <86839591+MatthiasBSchaefer@users.noreply.github.com> Date: Thu, 12 Mar 2026 15:38:10 +0100 Subject: [PATCH 10/18] Update Continuous.mo removing empty spaces in Modelica.Blocks.Continuous.LimPID --- Modelica/Blocks/Continuous.mo | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modelica/Blocks/Continuous.mo b/Modelica/Blocks/Continuous.mo index bd3b79f9f1..fc168e718a 100644 --- a/Modelica/Blocks/Continuous.mo +++ b/Modelica/Blocks/Continuous.mo @@ -765,7 +765,7 @@ to compute u by an algebraic equation. "Control error (set point - measurement)"; parameter .Modelica.Blocks.Types.SimpleController controllerType= .Modelica.Blocks.Types.SimpleController.PID "Type of controller"; - parameter Real k = 1 "Gain of controller, must be non-zero"; + parameter Real k=1 "Gain of controller, must be non-zero"; parameter SI.Time Ti(min=Modelica.Constants.small)=0.5 "Time constant of Integrator block" annotation (Dialog(enable= controllerType == .Modelica.Blocks.Types.SimpleController.PI or From fbae83c73610169c801b53060efd96a2d7814efb Mon Sep 17 00:00:00 2001 From: Matthias Schaefer Date: Thu, 19 Mar 2026 12:22:02 +0100 Subject: [PATCH 11/18] Initialize CI for PullRequest Testing --- .github/workflows/PRTesting.yml | 35 +++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 .github/workflows/PRTesting.yml diff --git a/.github/workflows/PRTesting.yml b/.github/workflows/PRTesting.yml new file mode 100644 index 0000000000..57d3fca05e --- /dev/null +++ b/.github/workflows/PRTesting.yml @@ -0,0 +1,35 @@ +name: PR_testing +on: + # Triggers the workflow on push or pull request events but only for the "main" branch + pull_request: + + # Allows you to run this workflow manually from the Actions tab + workflow_dispatch: + +# A workflow run is made up of one or more jobs that can run sequentially or in parallel +jobs: + prepare: + runs-on: self-hosted + steps: + - name: checkout_pr_repo + run: /home/resimuser/regression_testing/docker/work/run_scripts/prepare_pr.sh ${{ github.event.number }} + + testrun_modelica: + needs: prepare + runs-on: self-hosted + environment: + name: link_modelica + url: https://serv.ltx.de/prs/${{ github.event.number }}/Modelica/report/PR_comparison_report.html + steps: + - name: run modelica + run: /home/resimuser/regression_testing/docker/work/run_scripts/run_pr.sh ${{ github.event.number }} ${{ github.event.pull_request.base.sha }} Modelica + + testrun_modelicatest: + needs: prepare + runs-on: self-hosted + environment: + name: link_modelicatest + url: https://serv.ltx.de/prs/${{ github.event.number }}/ModelicaTest/report/PR_comparison_report.html + steps: + - name: run modelicatest + run: /home/resimuser/regression_testing/docker/work/run_scripts/run_pr.sh ${{ github.event.number }} ${{ github.event.pull_request.base.sha }} ModelicaTest From 48a0f196262681df3fe83662d424cf077a37359d Mon Sep 17 00:00:00 2001 From: Matthias Schaefer Date: Tue, 31 Mar 2026 08:17:22 +0200 Subject: [PATCH 12/18] Add trigger workflow for PR testing to get access to variables and secrets --- .github/workflows/CI_ReSim_trigger.yml | 18 ++++++++ .github/workflows/PRTesting.yml | 60 +++++++++++++++----------- 2 files changed, 54 insertions(+), 24 deletions(-) create mode 100644 .github/workflows/CI_ReSim_trigger.yml diff --git a/.github/workflows/CI_ReSim_trigger.yml b/.github/workflows/CI_ReSim_trigger.yml new file mode 100644 index 0000000000..f6fdfc7c58 --- /dev/null +++ b/.github/workflows/CI_ReSim_trigger.yml @@ -0,0 +1,18 @@ +name: CI ReSim Trigger + +on: + pull_request: + workflow_dispatch: + +env: + EVENT_NUMBER: ${{ github.event.number }} + PR_SHA: ${{ github.event.pull_request.base.sha }} + +jobs: + get PR data: + runs-on: ubuntu-latest + steps: + - name: print vars + run: + echo "Event Number: ${{ github.env.EVENT_NUMBER }}" + echo "PR Base Hash: ${{ github.env.PR_SHA }}" \ No newline at end of file diff --git a/.github/workflows/PRTesting.yml b/.github/workflows/PRTesting.yml index 57d3fca05e..fd0992bc3e 100644 --- a/.github/workflows/PRTesting.yml +++ b/.github/workflows/PRTesting.yml @@ -1,35 +1,47 @@ -name: PR_testing +name: CI ReSim on: - # Triggers the workflow on push or pull request events but only for the "main" branch - pull_request: - - # Allows you to run this workflow manually from the Actions tab - workflow_dispatch: + workflow_run: + workflows: ["Trigger CI ReSim"] + types: + - completed -# A workflow run is made up of one or more jobs that can run sequentially or in parallel +env: + PR_SERVER: ${{ vars.LTX_PR_SERVER }} + TESTING_TOOLS: ${{ vars.LTX_TESTING_TOOLS }} + EVENT_NUMBER: ${{ github.event.workflow_run.env.EVENT_NUMBER }} + PR_SHA: ${{ github.event.workflow_run.env.PR_SHA }} jobs: prepare: - runs-on: self-hosted + runs-on: [ self-hosted, Linux, regression_testing ] steps: - - name: checkout_pr_repo - run: /home/resimuser/regression_testing/docker/work/run_scripts/prepare_pr.sh ${{ github.event.number }} - + - uses: actions/checkout@v6 + with: + sparse-checkout: './.CI/ReSim' + + - name: Checkout code in docker + run: ./.CI/ReSim/prepare_pr.sh ${{ github.env.EVENT_NUMBER }} + testrun_modelica: needs: prepare - runs-on: self-hosted - environment: - name: link_modelica - url: https://serv.ltx.de/prs/${{ github.event.number }}/Modelica/report/PR_comparison_report.html + runs-on: [ self-hosted, Linux, regression_testing ] + #environment: + # name: Report modelica + # url: $PR_SERVER/${{ github.env.EVENT_NUMBER }}/Modelica/report/PR_comparison_report.html steps: - - name: run modelica - run: /home/resimuser/regression_testing/docker/work/run_scripts/run_pr.sh ${{ github.event.number }} ${{ github.event.pull_request.base.sha }} Modelica - + - name: print envs + run: echo "TESTING_TOOLS=$TESTING_TOOLS" + env: + TESTING_TOOLS: ${{ vars.LTX_TESTING_TOOLS }} + - name: Run tests modelica + run: ./.CI/ReSim/run_pr.sh ${{ github.env.EVENT_NUMBER }} ${{ github.env.PR_SHA }} Modelica ${{ github.env.TESTING_TOOLS }} + + testrun_modelicatest: needs: prepare - runs-on: self-hosted - environment: - name: link_modelicatest - url: https://serv.ltx.de/prs/${{ github.event.number }}/ModelicaTest/report/PR_comparison_report.html + runs-on: [ self-hosted, Linux, regression_testing ] + #environment: + # name: Report modelicatest + # url: $PR_SERVER/${{ github.env.EVENT_NUMBER }}/ModelicaTest/report/PR_comparison_report.html steps: - - name: run modelicatest - run: /home/resimuser/regression_testing/docker/work/run_scripts/run_pr.sh ${{ github.event.number }} ${{ github.event.pull_request.base.sha }} ModelicaTest + - name: Run tests modelicatest + run: ./.CI/ReSim/run_pr.sh ${{ github.env.EVENT_NUMBER }} ${{ github.env.PR_SHA }} ModelicaTest ${{ github.env.TESTING_TOOLS }} \ No newline at end of file From 5cdacb9e026394e53d38c613bfba2dc585a18a8b Mon Sep 17 00:00:00 2001 From: Matthias Schaefer Date: Thu, 2 Apr 2026 14:49:09 +0200 Subject: [PATCH 13/18] Add main scripts for CI PRTesting and adapt yml --- .CI/ReSim/prepare_pr.sh | 7 +++++++ .CI/ReSim/run_pr.sh | 33 +++++++++++++++++++++++++++++++++ .github/workflows/PRTesting.yml | 30 +++++++++++++++--------------- 3 files changed, 55 insertions(+), 15 deletions(-) create mode 100644 .CI/ReSim/prepare_pr.sh create mode 100644 .CI/ReSim/run_pr.sh diff --git a/.CI/ReSim/prepare_pr.sh b/.CI/ReSim/prepare_pr.sh new file mode 100644 index 0000000000..c2bb77c958 --- /dev/null +++ b/.CI/ReSim/prepare_pr.sh @@ -0,0 +1,7 @@ +event_number=$1 +# checkout the pull request +docker run --name compile_msl --rm --volume shared_data:/shared_data wsm_image /shared_data/run_scripts/git_pr_pull.sh $event_number +# compile msl binaries +docker run --name compile_msl --rm --volume shared_data:/shared_data wsm_image /shared_data/run_scripts/compile_msl.sh /shared_data/repos/pr_testing/ModelicaStandardLibrary +# delete old PRs with same number (in case of a new commit on a PR) +docker run --name compile_msl --rm --volume shared_data:/shared_data dymola_image /shared_data/run_scripts/delete_old_PRs.sh $event_number \ No newline at end of file diff --git a/.CI/ReSim/run_pr.sh b/.CI/ReSim/run_pr.sh new file mode 100644 index 0000000000..deb92e9655 --- /dev/null +++ b/.CI/ReSim/run_pr.sh @@ -0,0 +1,33 @@ +event_number=$1 +master_hash=$2 +pkg_name=$3 + +# Run Modelica in all tools +tools=$4 + +for tool in $tools +do + uppertool=$tool | tr 'a-z' 'A-Z' + docker run --rm --name $tool\_pr_compare_$event_number\_$pkg_name --volume shared_data:/shared_data $tool\_image python /shared_data/run_scripts/$uppertool\_PR_compare.py $master_hash $event_number $pkg_name +done + +#docker run --rm --name dymola_pr_compare_$event_number\_$pkg_name --volume shared_data:/shared_data dymola_image python /shared_data/run_scripts/Dymola_PR_compare.py $master_hash $event_number $pkg_name +#docker run --rm --name om_pr_compare_$event_number\_$pkg_name --volume shared_data:/shared_data om_image python /shared_data/run_scripts/OM_PR_compare.py $master_hash $event_number $pkg_name +#docker run --rm --name wsm_pr_compare_$event_number\_$pkg_name --volume shared_data:/shared_data wsm_image python /shared_data/run_scripts/WSM_PR_compare.py $master_hash $event_number $pkg_name + +# create an overview over all tools +docker run --name create_overview_$event_number\_$pkg_name --volume shared_data:/shared_data om_image python /shared_data/run_scripts/overview_report.py $event_number $pkg_name + +# clear published directory (web server) +if [ -d "/var/www/html/prs/$event_number/$pkg_name" ]; then + rm -rf "/var/www/html/prs/$event_number/$pkg_name" +fi +if [ ! -d "/var/www/html/prs/$event_number" ]; then + mkdir /var/www/html/prs/$event_number +fi +mkdir /var/www/html/prs/$event_number/$pkg_name + +# copy data to webserver directory +docker cp create_overview_$event_number\_$pkg_name:/shared_data/resim_output/PRs/PR_$event_number/$pkg_name/report /var/www/html/prs/$event_number/$pkg_name +docker rm create_overview_$event_number\_$pkg_name +exit $(head -n 1 /var/www/html/prs/$event_number/$pkg_name/status.txt) \ No newline at end of file diff --git a/.github/workflows/PRTesting.yml b/.github/workflows/PRTesting.yml index fd0992bc3e..0e58c8dbd1 100644 --- a/.github/workflows/PRTesting.yml +++ b/.github/workflows/PRTesting.yml @@ -1,15 +1,15 @@ name: CI ReSim + on: - workflow_run: - workflows: ["Trigger CI ReSim"] - types: - - completed + pull_request_target: + workflow_dispatch: env: PR_SERVER: ${{ vars.LTX_PR_SERVER }} TESTING_TOOLS: ${{ vars.LTX_TESTING_TOOLS }} - EVENT_NUMBER: ${{ github.event.workflow_run.env.EVENT_NUMBER }} - PR_SHA: ${{ github.event.workflow_run.env.PR_SHA }} + EVENT_NUMBER: ${{ github.event.number }} + PR_SHA: ${{ github.event.pull_request.base.sha }} + jobs: prepare: runs-on: [ self-hosted, Linux, regression_testing ] @@ -19,29 +19,29 @@ jobs: sparse-checkout: './.CI/ReSim' - name: Checkout code in docker - run: ./.CI/ReSim/prepare_pr.sh ${{ github.env.EVENT_NUMBER }} + run: ./.CI/ReSim/prepare_pr.sh ${{ env.EVENT_NUMBER }} testrun_modelica: needs: prepare runs-on: [ self-hosted, Linux, regression_testing ] - #environment: - # name: Report modelica - # url: $PR_SERVER/${{ github.env.EVENT_NUMBER }}/Modelica/report/PR_comparison_report.html + environment: + name: Report modelica + url: ${{ env.PR_SERVER }}/${{ env.EVENT_NUMBER }}/Modelica/report/PR_comparison_report.html steps: - name: print envs run: echo "TESTING_TOOLS=$TESTING_TOOLS" env: TESTING_TOOLS: ${{ vars.LTX_TESTING_TOOLS }} - name: Run tests modelica - run: ./.CI/ReSim/run_pr.sh ${{ github.env.EVENT_NUMBER }} ${{ github.env.PR_SHA }} Modelica ${{ github.env.TESTING_TOOLS }} + run: ./.CI/ReSim/run_pr.sh ${{ env.EVENT_NUMBER }} ${{ env.PR_SHA }} Modelica ${{ env.TESTING_TOOLS }} testrun_modelicatest: needs: prepare runs-on: [ self-hosted, Linux, regression_testing ] - #environment: - # name: Report modelicatest - # url: $PR_SERVER/${{ github.env.EVENT_NUMBER }}/ModelicaTest/report/PR_comparison_report.html + environment: + name: Report modelicatest + url: ${{ env.PR_SERVER }}/${{ env.EVENT_NUMBER }}/ModelicaTest/report/PR_comparison_report.html steps: - name: Run tests modelicatest - run: ./.CI/ReSim/run_pr.sh ${{ github.env.EVENT_NUMBER }} ${{ github.env.PR_SHA }} ModelicaTest ${{ github.env.TESTING_TOOLS }} \ No newline at end of file + run: ./.CI/ReSim/run_pr.sh ${{ env.EVENT_NUMBER }} ${{ env.PR_SHA }} ModelicaTest ${{ env.TESTING_TOOLS }} \ No newline at end of file From b9afba61c9bc2c182dba5770c16692a918f62147 Mon Sep 17 00:00:00 2001 From: Matthias Schaefer <86839591+MatthiasBSchaefer@users.noreply.github.com> Date: Thu, 2 Apr 2026 15:03:18 +0200 Subject: [PATCH 14/18] bugifx in CI_ReSim_trigger.yml --- .github/workflows/CI_ReSim_trigger.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/CI_ReSim_trigger.yml b/.github/workflows/CI_ReSim_trigger.yml index f6fdfc7c58..0435f75f9f 100644 --- a/.github/workflows/CI_ReSim_trigger.yml +++ b/.github/workflows/CI_ReSim_trigger.yml @@ -13,6 +13,6 @@ jobs: runs-on: ubuntu-latest steps: - name: print vars - run: + run: | echo "Event Number: ${{ github.env.EVENT_NUMBER }}" - echo "PR Base Hash: ${{ github.env.PR_SHA }}" \ No newline at end of file + echo "PR Base Hash: ${{ github.env.PR_SHA }}" From c7922aed43192ddf5330a7741f44415fbe4cc1ce Mon Sep 17 00:00:00 2001 From: Matthias Schaefer <86839591+MatthiasBSchaefer@users.noreply.github.com> Date: Thu, 2 Apr 2026 15:05:21 +0200 Subject: [PATCH 15/18] Bugfix in CI_ReSim_trigger.yml --- .github/workflows/CI_ReSim_trigger.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI_ReSim_trigger.yml b/.github/workflows/CI_ReSim_trigger.yml index 0435f75f9f..33b5cc1f24 100644 --- a/.github/workflows/CI_ReSim_trigger.yml +++ b/.github/workflows/CI_ReSim_trigger.yml @@ -9,7 +9,7 @@ env: PR_SHA: ${{ github.event.pull_request.base.sha }} jobs: - get PR data: + get_PR_data: runs-on: ubuntu-latest steps: - name: print vars From 27b6eea10c50ca2bd442ef15cdcd4ceca245d819 Mon Sep 17 00:00:00 2001 From: Matthias Schaefer <86839591+MatthiasBSchaefer@users.noreply.github.com> Date: Thu, 2 Apr 2026 16:18:24 +0200 Subject: [PATCH 16/18] remove print step in PRTesting.yml --- .github/workflows/PRTesting.yml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/PRTesting.yml b/.github/workflows/PRTesting.yml index 0e58c8dbd1..d3ac4c1cee 100644 --- a/.github/workflows/PRTesting.yml +++ b/.github/workflows/PRTesting.yml @@ -27,11 +27,7 @@ jobs: environment: name: Report modelica url: ${{ env.PR_SERVER }}/${{ env.EVENT_NUMBER }}/Modelica/report/PR_comparison_report.html - steps: - - name: print envs - run: echo "TESTING_TOOLS=$TESTING_TOOLS" - env: - TESTING_TOOLS: ${{ vars.LTX_TESTING_TOOLS }} + steps: - name: Run tests modelica run: ./.CI/ReSim/run_pr.sh ${{ env.EVENT_NUMBER }} ${{ env.PR_SHA }} Modelica ${{ env.TESTING_TOOLS }} @@ -44,4 +40,4 @@ jobs: url: ${{ env.PR_SERVER }}/${{ env.EVENT_NUMBER }}/ModelicaTest/report/PR_comparison_report.html steps: - name: Run tests modelicatest - run: ./.CI/ReSim/run_pr.sh ${{ env.EVENT_NUMBER }} ${{ env.PR_SHA }} ModelicaTest ${{ env.TESTING_TOOLS }} \ No newline at end of file + run: ./.CI/ReSim/run_pr.sh ${{ env.EVENT_NUMBER }} ${{ env.PR_SHA }} ModelicaTest ${{ env.TESTING_TOOLS }} From 7b2861a37bf0413d6d0f521e45ab159afa75289b Mon Sep 17 00:00:00 2001 From: Matthias Schaefer Date: Thu, 2 Apr 2026 16:23:49 +0200 Subject: [PATCH 17/18] PRTesting.yml without target --- .github/workflows/PRTesting.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/PRTesting.yml b/.github/workflows/PRTesting.yml index d3ac4c1cee..bb0f182e7d 100644 --- a/.github/workflows/PRTesting.yml +++ b/.github/workflows/PRTesting.yml @@ -1,7 +1,7 @@ name: CI ReSim on: - pull_request_target: + pull_request: workflow_dispatch: env: From 826763a2addee7067b1b867584a161e79a1d1a39 Mon Sep 17 00:00:00 2001 From: Matthias Schaefer Date: Thu, 2 Apr 2026 16:26:04 +0200 Subject: [PATCH 18/18] PRTesting.yml with labeled target --- .github/workflows/PRTesting.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/PRTesting.yml b/.github/workflows/PRTesting.yml index bb0f182e7d..07753dbbfb 100644 --- a/.github/workflows/PRTesting.yml +++ b/.github/workflows/PRTesting.yml @@ -1,7 +1,8 @@ name: CI ReSim on: - pull_request: + pull_request_target: + types: [labeled] workflow_dispatch: env: