From 96b4dc50436326d1312b5ee85c48a11bd7b7a062 Mon Sep 17 00:00:00 2001 From: peterstone2017 <12449837+YunchuWang@users.noreply.github.com> Date: Thu, 26 Feb 2026 20:30:46 -0800 Subject: [PATCH] Fix build warnings and clean up exception message - Remove duplicate BenchmarkDotNet 0.14.0 entry in Directory.Packages.props (fixes NU1506) - Upgrade ExportHistoryWebApp from net6.0 to net8.0 (fixes NETSDK1138) - Remove 'TODO' prefix from exception message in TaskHubGrpcServer --- Directory.Packages.props | 1 - samples/ExportHistoryWebApp/ExportHistoryWebApp.csproj | 2 +- src/InProcessTestHost/Sidecar/Grpc/TaskHubGrpcServer.cs | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Directory.Packages.props b/Directory.Packages.props index 76c4dd51d..aff8b6de0 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -65,7 +65,6 @@ - diff --git a/samples/ExportHistoryWebApp/ExportHistoryWebApp.csproj b/samples/ExportHistoryWebApp/ExportHistoryWebApp.csproj index 884da7e8b..6c63020af 100644 --- a/samples/ExportHistoryWebApp/ExportHistoryWebApp.csproj +++ b/samples/ExportHistoryWebApp/ExportHistoryWebApp.csproj @@ -1,7 +1,7 @@ - net6.0 + net8.0 enable enable true diff --git a/src/InProcessTestHost/Sidecar/Grpc/TaskHubGrpcServer.cs b/src/InProcessTestHost/Sidecar/Grpc/TaskHubGrpcServer.cs index 43603ffac..50f1fe155 100644 --- a/src/InProcessTestHost/Sidecar/Grpc/TaskHubGrpcServer.cs +++ b/src/InProcessTestHost/Sidecar/Grpc/TaskHubGrpcServer.cs @@ -902,7 +902,7 @@ async Task SendWorkItemToClientAsync(P.WorkItem workItem) { outputStream = this.workerToClientStream ?? // CA2201: Use specific exception types - throw new InvalidOperationException("TODO: No client is connected! Need to wait until a client connects before executing!"); + throw new InvalidOperationException("No client is connected. Need to wait until a client connects before executing."); } // The gRPC channel can only handle one message at a time, so we need to serialize access to it.