Skip to content

chore(docs): added button group examples (#DS-4559)#1426

Merged
NikGurev merged 23 commits intomainfrom
feat/DS-4559
Mar 25, 2026
Merged

chore(docs): added button group examples (#DS-4559)#1426
NikGurev merged 23 commits intomainfrom
feat/DS-4559

Conversation

@NikGurev
Copy link
Copy Markdown
Contributor

@NikGurev NikGurev commented Mar 17, 2026 •
edited
Loading

Summary

  • Splitter

@NikGurev NikGurev self-assigned this Mar 17, 2026
@NikGurev NikGurev added the enhancement New feature or request label Mar 17, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 17, 2026 •
edited
Loading

Visit the preview URL for this PR (updated for commit 68faa68):

https://koobiq-next--prs-1426-69zrxxc5.web.app

(expires Sun, 29 Mar 2026 15:03:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@NikGurev NikGurev marked this pull request as ready for review March 18, 2026 15:22
@NikGurev NikGurev requested a review from lskramarov as a code owner March 18, 2026 15:22
@NikGurev NikGurev requested review from artembelik and rmnturov March 19, 2026 07:14
@NikGurev NikGurev changed the title feat(button): added button group (#DS-4559) chore(docs): added button group examples (#DS-4559) Mar 19, 2026
@NikGurev NikGurev added documentation Improvements or additions to documentation and removed enhancement New feature or request labels Mar 19, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 19, 2026

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@NikGurev
Copy link
Copy Markdown
Contributor Author

NikGurev commented Mar 19, 2026

/approve-snapshots

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 19, 2026

🔄 Updating snapshots.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 19, 2026

✅ Snapshots updated!

lskramarov
lskramarov reviewed Mar 23, 2026
View reviewed changes
Comment thread apps/docs/src/app/structure.ts Outdated
Comment thread packages/components/button/__screenshots__/04-dark.png
Comment thread packages/components/button/e2e.ts Outdated
Comment thread packages/components/button/button-group.ts Outdated
Comment thread packages/components/button/button-group.ts Outdated
Comment thread packages/components/button/button.module.ts
artembelik
artembelik reviewed Mar 23, 2026
View reviewed changes
Comment thread packages/components/button/button.scss Outdated
@rmnturov
Copy link
Copy Markdown
Contributor

rmnturov commented Mar 24, 2026 •
edited
Loading

У кнопок-дропдаунов нужны другие отступы у стрелочки. Стрелка должна располагаться более близко к тексту.

Сейчас неправильно
image

Правильный пример

https://koobiq-next--prs-1426-69zrxxc5.web.app/ru/components/dropdown/overview

image

@rmnturov
Copy link
Copy Markdown
Contributor

rmnturov commented Mar 24, 2026

В серых кнопках неправильный цвет линии-разделителя
image

@NikGurev
Copy link
Copy Markdown
Contributor Author

NikGurev commented Mar 24, 2026

У кнопок-дропдаунов нужны другие отступы у стрелочки. Стрелка должна располагаться более близко к тексту.

Сейчас неправильно

@rmnturov это дефолтное поведение, я ничего не менял, надо смотреть

@rmnturov
Copy link
Copy Markdown
Contributor

rmnturov commented Mar 24, 2026

Фикс цвета полосок можно сделать отдельно

@NikGurev
Copy link
Copy Markdown
Contributor Author

NikGurev commented Mar 24, 2026 •
edited
Loading

Фикс цвета полосок можно сделать отдельно

добавил ссылку на таску и поправил стили кнопки дропдауна

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 24, 2026

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 24, 2026

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@NikGurev
Copy link
Copy Markdown
Contributor Author

NikGurev commented Mar 25, 2026

/approve-snapshots

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2026

🔄 Updating snapshots.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2026

✅ Snapshots updated!

@NikGurev NikGurev merged commit 654a520 into main Mar 25, 2026
@NikGurev NikGurev deleted the feat/DS-4559 branch March 25, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lskramarov lskramarov lskramarov approved these changes

@artembelik artembelik artembelik approved these changes

@rmnturov rmnturov rmnturov approved these changes

Assignees

@NikGurev NikGurev

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NikGurev @rmnturov @lskramarov @artembelik