KeenQueryClientException seems to have been created as the exception that should be thrown out of KeenQueryClient and the comment says that even includes errors reported by the server:
Exceptions thrown by KeenQueryClient. This includes errors reported by the server.
But, there are several places where we throw ServerException out of KeenQueryClient instead. Is there a reason for this, or was it just an oversight? What should we throw in those cases?
What about for new code like Saved/Cached Query code in PR #96? That's not technically KeenQueryClient so is a new exception class desirable?
KeenQueryClientExceptionseems to have been created as the exception that should be thrown out ofKeenQueryClientand the comment says that even includes errors reported by the server:Exceptions thrown by KeenQueryClient. This includes errors reported by the server.But, there are several places where we throw
ServerExceptionout ofKeenQueryClientinstead. Is there a reason for this, or was it just an oversight? What should we throw in those cases?What about for new code like Saved/Cached Query code in PR #96? That's not technically
KeenQueryClientso is a new exception class desirable?