forked from BetterCloud/vault-java-driver
-
Notifications
You must be signed in to change notification settings - Fork 25
Open
Labels
enhancementNew feature or requestNew feature or request
Description
As the current implementation stands, calling withRetries on the Vault object modifies the retry logic for all subsequent calls to Vault, unless they specifically override it using withRetries in their own call.
I'd like it if withRetries would only affect the call being made and not any other ones that follow after.
It also is a bit of a code smell that the VaultConfig final object gets manipulated using the withRetries call. I propose withRetries returns a new RetryingVault (or similar) interface, and move that holds the parameters for a retry in it's own implementation, and passes a copy of Vault Config extended with the retry parameters to the Logical, Auth, and other dsl classes that would rely on it.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request