[BUG]: edit task page invalid rgb value warning

[jessevz]

Version Information

dev

Hashcat

No response

Description

At the edit task page, there is the following warning:

The specified value "" does not conform to the required format. The format is "#rrggbb" where rr, gg, bb are two-digit hexadecimal numbers.

The reason for this is that the default color value is an empty string "", instead it should be the color white (#FFFFFF). And it should also, when the task color from the backend is set to null, parse it to #FFFFFF

[s3inlc]

But there is a difference between an empty string (or NULL if you prefer) and the color white. Because if you switch to dark mode, if no color is set, you would expect that everything white probably changes to the dark theme colors, but if it's set to white, it will not?

[jessevz]

@s3inlc I think this part of the code is only to put a value into the color picker. I think having white as a default value can make sense in dark mode aswell. If not the indeed it should also take which mode is selected in account

[s3inlc]

but what happens if I update the task in some other field (e.g. task name) and then press save? this then would cause to change the color of the task from no color to white.

[jessevz]

@s3inlc Ah yes, you are right about that

[correct-horse-battery-bench]

@jessevz @s3inlc I saw that in PR: hashtopolis/web-ui#546 the issue with the error message has been resolved but I think reading the comments I am not sure if this is the intended outcome.

Currently white is always shown as color there but no color "" empty string is sent to the backend (should probably be null in this case instead of empty string). So white is shown in both light and dark mode instead of the true value (transparent).

In the dark mode it currently shows white (#FFFFFF) as default even though it still sends to the backend no color so this at least should be modified.

Solution:

If no color is still a requirement then show something like 'No Color' or 'Transparent' instead of #FFFFFF and send to the backend null instead of empty string (have to check whether backend accepts this).

If a default color should always be set then probably use one from the randomizer directly or from a set of pleasing colors that match the theme (light and dark).