bump to 1.88

extrawurst · extrawurst · commit 4cd510cdcd08 · 2026-03-19T15:53:41.000Z
diff --git a/.clippy.toml b/.clippy.toml
@@ -1,2 +1,2 @@
-msrv = "1.85.0"
+msrv = "1.88.0"
 cognitive-complexity-threshold = 18
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -17,7 +17,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        rust: [nightly, stable, "1.85"]
+        rust: [nightly, stable, "1.88"]
     runs-on: ${{ matrix.os }}
     continue-on-error: ${{ matrix.rust == 'nightly' }}
 
@@ -94,7 +94,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        rust: [nightly, stable, "1.85"]
+        rust: [nightly, stable, "1.88"]
     continue-on-error: ${{ matrix.rust == 'nightly' }}
     steps:
       - uses: actions/checkout@v4
@@ -148,7 +148,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        rust: [nightly, stable, "1.85"]
+        rust: [nightly, stable, "1.88"]
     continue-on-error: ${{ matrix.rust == 'nightly' }}
     steps:
       - uses: actions/checkout@v4
@@ -199,7 +199,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        rust: [nightly, stable, "1.85"]
+        rust: [nightly, stable, "1.88"]
     continue-on-error: ${{ matrix.rust == 'nightly' }}
     steps:
       - uses: actions/checkout@v4
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## Unreleased
 
 ### Changed
-* rust msrv bumped to `1.85`
+* rust msrv bumped to `1.88`
 
 ## [0.28.0] - 2025-12-14
 
diff --git a/Cargo.toml b/Cargo.toml
@@ -4,14 +4,14 @@ version = "0.28.0"
 authors = ["extrawurst <mail@rusticorn.com>"]
 description = "blazing fast terminal-ui for git"
 edition = "2021"
-rust-version = "1.85"
+rust-version = "1.88"
 exclude = [".github/*", ".vscode/*", "assets/*"]
 homepage = "https://github.com/gitui-org/gitui"
 repository = "https://github.com/gitui-org/gitui"
 readme = "README.md"
 license = "MIT"
 categories = ["command-line-utilities"]
-keywords = ["git", "gui", "cli", "terminal", "ui"]
+keywords = ["cli", "git", "gui", "terminal", "ui"]
 build = "build.rs"
 
 [workspace]
@@ -43,7 +43,7 @@ bugreport = "0.5.1"
 bwrap = { version = "1.3", features = ["use_std"] }
 bytesize = { version = "2.3", default-features = false }
 chrono = { version = "0.4", default-features = false, features = ["clock"] }
-clap = { version = "4.5", features = ["env", "cargo"] }
+clap = { version = "4.5", features = ["cargo", "env"] }
 crossbeam-channel = "0.5"
 crossterm = { version = "0.28", features = ["serde"] }
 dirs = "6.0"
@@ -59,8 +59,8 @@ notify-debouncer-mini = "0.7"
 once_cell = "1"
 parking_lot_core = "0.9"
 ratatui = { version = "0.29", default-features = false, features = [
-    'crossterm',
-    'serde',
+  "crossterm",
+  "serde",
 ] }
 rayon-core = "1.13"
 ron = "0.12"
@@ -71,11 +71,11 @@ shellexpand = "3.1"
 simplelog = { version = "0.12", default-features = false }
 struct-patch = "0.10"
 syntect = { version = "5.3", default-features = false, features = [
-    "parsing",
-    "default-syntaxes",
-    "default-themes",
-    "plist-load",
-    "html",
+  "default-syntaxes",
+  "default-themes",
+  "html",
+  "parsing",
+  "plist-load",
 ] }
 tui-textarea = "0.7"
 two-face = { version = "0.4.4", default-features = false }
@@ -95,14 +95,14 @@ tempfile = "3"
 [badges]
 maintenance = { status = "actively-developed" }
 
-[profile.release]
-lto = true
-opt-level = 'z'     # Optimize for size.
-codegen-units = 1
-strip = "debuginfo"
-
 # make debug build as fast as release
 # usage of utf8 encoding inside tui
 # makes their debug profile slow
 [profile.dev.package."ratatui"]
 opt-level = 3
+
+[profile.release]
+opt-level = "z"  # Optimize for size.
+strip = "debuginfo"
+lto = true
+codegen-units = 1
diff --git a/README.md b/README.md
@@ -220,7 +220,7 @@ see [NIGHTLIES.md](./NIGHTLIES.md)
 
 ### Requirements
 
-- Minimum supported `rust`/`cargo` version: `1.85`
+- Minimum supported `rust`/`cargo` version: `1.88`
   - See [Install Rust](https://www.rust-lang.org/tools/install)
 
 - To build openssl dependency (see https://docs.rs/openssl/latest/openssl/)
diff --git a/filetreelist/src/filetreeitems.rs b/filetreelist/src/filetreeitems.rs
@@ -59,7 +59,7 @@ impl FileTreeItems {
 	}
 
 	/// how many individual items (files/paths) are in the list
-	pub fn len(&self) -> usize {
+	pub const fn len(&self) -> usize {
 		self.tree_items.len()
 	}
 
diff --git a/src/components/changes.rs b/src/components/changes.rs
@@ -67,7 +67,7 @@ impl ChangesComponent {
 	}
 
 	/// returns true if list is empty
-	pub fn is_empty(&self) -> bool {
+	pub const fn is_empty(&self) -> bool {
 		self.files.is_empty()
 	}
 
diff --git a/src/components/commitlist.rs b/src/components/commitlist.rs
@@ -113,7 +113,7 @@ impl CommitList {
 	}
 
 	///
-	pub fn marked_count(&self) -> usize {
+	pub const fn marked_count(&self) -> usize {
 		self.marked.len()
 	}
 
@@ -284,7 +284,7 @@ impl CommitList {
 	}
 
 	/// will return view size or None before the first render
-	fn current_size(&self) -> Option<(u16, u16)> {
+	const fn current_size(&self) -> Option<(u16, u16)> {
 		self.current_size.get()
 	}
 
diff --git a/src/components/status_tree.rs b/src/components/status_tree.rs
@@ -97,7 +97,7 @@ impl StatusTreeComponent {
 	}
 
 	/// returns true if list is empty
-	pub fn is_empty(&self) -> bool {
+	pub const fn is_empty(&self) -> bool {
 		self.tree.is_empty()
 	}
 
diff --git a/src/components/textinput.rs b/src/components/textinput.rs
@@ -122,7 +122,7 @@ impl TextInputComponent {
 	}
 
 	/// screen area (last time we got drawn)
-	pub fn get_area(&self) -> Rect {
+	pub const fn get_area(&self) -> Rect {
 		self.current_area.get()
 	}
 
diff --git a/src/components/utils/filetree.rs b/src/components/utils/filetree.rs
@@ -172,7 +172,7 @@ impl FileTreeItems {
 	}
 
 	///
-	pub(crate) fn len(&self) -> usize {
+	pub(crate) const fn len(&self) -> usize {
 		self.items.len()
 	}
 
diff --git a/src/components/utils/scroll_horizontal.rs b/src/components/utils/scroll_horizontal.rs
@@ -18,7 +18,7 @@ impl HorizontalScroll {
 		}
 	}
 
-	pub fn get_right(&self) -> usize {
+	pub const fn get_right(&self) -> usize {
 		self.right.get()
 	}
 
diff --git a/src/components/utils/scroll_vertical.rs b/src/components/utils/scroll_vertical.rs
@@ -20,7 +20,7 @@ impl VerticalScroll {
 		}
 	}
 
-	pub fn get_top(&self) -> usize {
+	pub const fn get_top(&self) -> usize {
 		self.top.get()
 	}
 
diff --git a/src/components/utils/statustree.rs b/src/components/utils/statustree.rs
@@ -173,7 +173,7 @@ impl StatusTree {
 	}
 
 	///
-	pub fn is_empty(&self) -> bool {
+	pub const fn is_empty(&self) -> bool {
 		self.tree.items().is_empty()
 	}
 
diff --git a/src/options.rs b/src/options.rs
@@ -116,7 +116,7 @@ impl Options {
 		self.save();
 	}
 
-	pub fn has_commit_msg_history(&self) -> bool {
+	pub const fn has_commit_msg_history(&self) -> bool {
 		!self.data.commit_msgs.is_empty()
 	}
 
diff --git a/src/popups/branchlist.rs b/src/popups/branchlist.rs
@@ -341,7 +341,7 @@ impl BranchListPopup {
 		Ok(())
 	}
 
-	fn valid_selection(&self) -> bool {
+	const fn valid_selection(&self) -> bool {
 		!self.branches.is_empty()
 	}
 
diff --git a/src/popups/remotelist.rs b/src/popups/remotelist.rs
@@ -411,7 +411,7 @@ impl RemoteListPopup {
 		Ok(true)
 	}
 
-	fn valid_selection(&self) -> bool {
+	const fn valid_selection(&self) -> bool {
 		!self.remote_names.is_empty()
 			&& self.remote_names.len() >= self.selection as usize
 	}

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`		`-msrv = "1.85.0"`
	`1`	`+msrv = "1.88.0"`
`2`	`2`	`cognitive-complexity-threshold = 18`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ impl FileTreeItems {`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`/// how many individual items (files/paths) are in the list`
`62`		`- pub fn len(&self) -> usize {`
	`62`	`+ pub const fn len(&self) -> usize {`
`63`	`63`	`self.tree_items.len()`
`64`	`64`	`}`
`65`	`65`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ impl ChangesComponent {`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`/// returns true if list is empty`
`70`		`- pub fn is_empty(&self) -> bool {`
	`70`	`+ pub const fn is_empty(&self) -> bool {`
`71`	`71`	`self.files.is_empty()`
`72`	`72`	`}`
`73`	`73`
Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ impl CommitList {`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`///`
`116`		`- pub fn marked_count(&self) -> usize {`
	`116`	`+ pub const fn marked_count(&self) -> usize {`
`117`	`117`	`self.marked.len()`
`118`	`118`	`}`
`119`	`119`
`@@ -284,7 +284,7 @@ impl CommitList {`
`284`	`284`	`}`
`285`	`285`
`286`	`286`	`/// will return view size or None before the first render`
`287`		`- fn current_size(&self) -> Option<(u16, u16)> {`
	`287`	`+ const fn current_size(&self) -> Option<(u16, u16)> {`
`288`	`288`	`self.current_size.get()`
`289`	`289`	`}`
`290`	`290`
Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ impl StatusTreeComponent {`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`/// returns true if list is empty`
`100`		`- pub fn is_empty(&self) -> bool {`
	`100`	`+ pub const fn is_empty(&self) -> bool {`
`101`	`101`	`self.tree.is_empty()`
`102`	`102`	`}`
`103`	`103`
Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ impl TextInputComponent {`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`/// screen area (last time we got drawn)`
`125`		`- pub fn get_area(&self) -> Rect {`
	`125`	`+ pub const fn get_area(&self) -> Rect {`
`126`	`126`	`self.current_area.get()`
`127`	`127`	`}`
`128`	`128`