Shorten shared query name

Author: jeongsoolee09

cpp/autosar/src/rules/A9-6-2/BitFieldsShouldNotBeDeclaredAutosarCpp.ql

@@ -10,19 +10,18 @@
  * @problem.severity recommendation
  * @tags external/autosar/id/a9-6-2
  *       maintainability
+ *       portability
  *       external/autosar/allocated-target/design
  *       external/autosar/enforcement/partially-automated
  *       external/autosar/obligation/required
  */
 
 import cpp
 import codingstandards.cpp.autosar
-import codingstandards.cpp.rules.bitfieldsshallbeusedonlywheninterfacingtohardwareorconformingtocommunicationprotocols.BitFieldsShallBeUsedOnlyWhenInterfacingToHardwareOrConformingToCommunicationProtocols
+import codingstandards.cpp.rules.bitfieldsshouldnotbedeclared.BitFieldsShouldNotBeDeclared
 
-module BitFieldsShouldNotBeDeclaredAutosarCppConfig implements
-  BitFieldsShallBeUsedOnlyWhenInterfacingToHardwareOrConformingToCommunicationProtocolsConfigSig
-{
+module BitFieldsShouldNotBeDeclaredAutosarCppConfig implements BitFieldsShouldNotBeDeclaredConfigSig {
   Query getQuery() { result = RepresentationPackage::bitFieldsShouldNotBeDeclaredAutosarCppQuery() }
 }
 
-import BitFieldsShallBeUsedOnlyWhenInterfacingToHardwareOrConformingToCommunicationProtocols<BitFieldsShouldNotBeDeclaredAutosarCppConfig>
+import BitFieldsShouldNotBeDeclared<BitFieldsShouldNotBeDeclaredAutosarCppConfig>

cpp/autosar/test/rules/A9-6-2/AuditPossibleHardwareInterfaceDueToBitFieldUsageInDataTypeDefinition.expected

@@ -1 +1 @@
-cpp/common/test/rules/bitfieldsshallbeusedonlywheninterfacingtohardwareorconformingtocommunicationprotocols/BitFieldsShallBeUsedOnlyWhenInterfacingToHardwareOrConformingToCommunicationProtocols.ql
+cpp/common/test/rules/bitfieldsshouldnotbedeclared/BitFieldsShouldNotBeDeclared.ql

cpp/autosar/test/rules/A9-6-2/BitFieldsShouldNotBeDeclaredAutosarCpp.testref

@@ -0,0 +1,22 @@
+/**
+ * Provides a configurable module BitFieldsShouldNotBeDeclared with a `problems` predicate
+ * for the following issue:
+ * The usage of bit-fields increases code complexity and certain aspects of bit-field
+ * manipulation can be error prone and implementation defined. Hence a bit-field usage
+ * is reserved only when interfacing to hardware or conformance to communication
+ * protocols.
+ */
+
+import cpp
+import codingstandards.cpp.Customizations
+import codingstandards.cpp.Exclusions
+
+signature module BitFieldsShouldNotBeDeclaredConfigSig {
+  Query getQuery();
+}
+
+module BitFieldsShouldNotBeDeclared<BitFieldsShouldNotBeDeclaredConfigSig Config> {
+  query predicate problems(Element e, string message) {
+    not isExcluded(e, Config::getQuery()) and message = "<replace with problem alert message for >"
+  }
+}

cpp/common/src/codingstandards/cpp/rules/bitfieldsshallbeusedonlywheninterfacingtohardwareorconformingtocommunicationprotocols/BitFieldsShallBeUsedOnlyWhenInterfacingToHardwareOrConformingToCommunicationProtocols.qll

@@ -0,0 +1,8 @@
+// GENERATED FILE - DO NOT MODIFY
+import codingstandards.cpp.rules.bitfieldsshouldnotbedeclared.BitFieldsShouldNotBeDeclared
+
+module TestFileConfig implements BitFieldsShouldNotBeDeclaredConfigSig {
+  Query getQuery() { result instanceof TestQuery }
+}
+
+import BitFieldsShouldNotBeDeclared<TestFileConfig>

cpp/common/src/codingstandards/cpp/rules/bitfieldsshouldnotbedeclared/BitFieldsShouldNotBeDeclared.qll

@@ -9,18 +9,17 @@
  * @tags external/misra/id/rule-12-2-1
  *       scope/single-translation-unit
  *       correctness
+ *       portability
  *       external/misra/enforcement/decidable
  *       external/misra/obligation/advisory
  */
 
 import cpp
 import codingstandards.cpp.misra
-import codingstandards.cpp.rules.bitfieldsshallbeusedonlywheninterfacingtohardwareorconformingtocommunicationprotocols.BitFieldsShallBeUsedOnlyWhenInterfacingToHardwareOrConformingToCommunicationProtocols
+import codingstandards.cpp.rules.bitfieldsshouldnotbedeclared.BitFieldsShouldNotBeDeclared
 
-module BitFieldsShouldNotBeDeclaredMisraCppConfig implements
-  BitFieldsShallBeUsedOnlyWhenInterfacingToHardwareOrConformingToCommunicationProtocolsConfigSig
-{
+module BitFieldsShouldNotBeDeclaredMisraCppConfig implements BitFieldsShouldNotBeDeclaredConfigSig {
   Query getQuery() { result = Banned5Package::bitFieldsShouldNotBeDeclaredMisraCppQuery() }
 }
 
-import BitFieldsShallBeUsedOnlyWhenInterfacingToHardwareOrConformingToCommunicationProtocols<BitFieldsShouldNotBeDeclaredMisraCppConfig>
+import BitFieldsShouldNotBeDeclared<BitFieldsShouldNotBeDeclaredMisraCppConfig>