Skip to content

fix(build): stop running automatic package-manager bootstrap commands on host #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ganesh47 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(build): stop running automatic package-manager bootstrap commands on host #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 6 additions & 15 deletions src/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,16 +417,11 @@ async function resolveBuildEnvironmentAssessment(cwd: string): Promise<BuildEnvi
requiredTools.add("node");
evidence.push("Detected a Node workspace from package.json / pnpm lockfiles.");
if ((packageManager ?? "").startsWith("pnpm@") || (await pathExists(path.join(cwd, "pnpm-lock.yaml")))) {
requiredTools.add("pnpm");
requiredTools.add("corepack");
evidence.push(`Root package manager: ${packageManager ?? "pnpm (inferred from lockfile)"}.`);
if (!(await pathExists(path.join(cwd, "node_modules")))) {
bootstrapActions.push({
label: "bootstrap root pnpm workspace",
cwd,
command: "corepack pnpm install --frozen-lockfile",
rationale: "The workspace uses pnpm and has not been bootstrapped yet."
});
notes.push(
"Skipped automatic pnpm bootstrap because package-manager installs are not executed outside the Codex sandbox."
);
}
}
}
Expand All @@ -440,16 +435,12 @@ async function resolveBuildEnvironmentAssessment(cwd: string): Promise<BuildEnvi
)
).slice(0, 3);
if (pyprojectDirs.length > 0) {
requiredTools.add("uv");
evidence.push(`Detected ${pyprojectDirs.length} uv-managed Python workspace${pyprojectDirs.length > 1 ? "s" : ""}.`);
for (const dir of pyprojectDirs) {
if (!(await pathExists(path.join(dir, ".venv")))) {
bootstrapActions.push({
label: `bootstrap uv environment (${path.relative(cwd, dir) || "."})`,
cwd: dir,
command: "uv sync --frozen",
rationale: "The Python workspace uses uv and does not have a local environment yet."
});
notes.push(
`Skipped automatic uv bootstrap for ${path.relative(cwd, dir) || "."} because package-manager installs are not executed outside the Codex sandbox.`
);
}
}
}
Expand Down
Loading