functions/internal

[LanderBeeuwsaert]

Operating System

any

Environment (if applicable)

any

Firebase SDK Version

12.9.0

Firebase SDK Product(s)

Functions

Project Tooling

angular application
with firebase functions

Detailed Problem Description

For every user experiencing a crash, we log this crash and also send an email to our support team mailbox.
The email is sent by calling from the client browser a google cloud function "sendMail" with the relevant data.
However, for quite a lot of these users, we get a second crash in our front-end application that gets logged:

this approximately happens in 30% of the crashes; which is weird because in our other function calls we have much less error percentage. If we go to google cloud logging, we don't see that the function ever started; and not even that a pre-flight 204 took place.

Steps and code to reproduce issue

no idea, just have clients that call functions a lot of time I would guess

[hsubox76]

Not sure there's much we can do based on the information so far, let us know if there are any more details you can provide. What is "472"? Is that an http code or just an internal value in your system?

Is there any other text for the error? Do you log error.message? Looking at the code, there are 4 possible instances of this error being thrown. In each case it is accompanied by different error message text. 3 explicit instances here: https://github.com/search?q=repo%3Afirebase%2Ffirebase-js-sdk%20FunctionsError(%27internal%27&type=code

The cases are (you can see in the code):

• There's no response.json (error.message would say "Response is not valid JSON object")
• No "data" field (would say "Response is missing data field")
• JSON is parsed and has an "error" field, but the status isn't one of the ones in this switch https://github.com/firebase/firebase-js-sdk/blob/main/packages/functions/src/error.ts#L95 (error.message would say "internal")

The final case is harder to see from the code but if code is "internal" at the end of this function, it would throw with code functions/internal, possibly with no error.message, if the status of the response was 0 or 500. https://github.com/firebase/firebase-js-sdk/blob/main/packages/functions/src/error.ts#L178

I think that's the best I can do with the information provided. If that 472 is a http code that would probably do it, though.

[LanderBeeuwsaert]

Thank you @hsubox76 for the detailed answer.
472 is our internal app version that we increment when we deploy a new version of our application. So it will not help here.

Our service that forwards any function call looks like this:

So we package the error coming back from the firebase functions code into the cause and rethrow it.

Later on, our logging code will log out the whole error to our logging in the real-time database and also log out the cause error:

"transformed undefined" just means that the property was undefined and we transformed it before logging it to the real-time database.

so as you can see, there is no message in the error.
So the most likely culprit, according to your reply, would be this place then =>
https://github.com/firebase/firebase-js-sdk/blob/main/packages/functions/src/error.ts#L178
would it be possible to provide more details in that part of the code what actually went wrong?