DhlShipmentRequest.ValueAddedServices.DhlRetoure requires a ReturnAddress which is missing in DhlRetoureService

[Bernhard231]

Description

Hello,

in DhlApiRetoure the ReturnAddress is prepared, just missing in DhlRetoureService. Could you please expand it.

Thank you.

Steps to Reproduce

ValitaionResult will show the requested missing address:

ServiceCollection serviceCollection = new ServiceCollection();

serviceCollection.AddDhl(options =>
{
options.ApiKey = "XXX";
options.ApiSecret = "XXX";

options.Username = "user-valid";
options.Password = "SandboxPasswort2023!";
options.UseSandbox = true;

})
.AddDhlShipping();

await using ServiceProvider serviceProvider = serviceCollection.BuildServiceProvider();
IDhlShippingClient dhlShippingClient = serviceProvider.GetRequiredService();

bool ReturnLabel = true;

var dhlShipmentRequest = new DhlShipmentRequest
{
Profile = "STANDARD_GRUPPENPROFIL",
BillingNumber = "33333333330101",
Product = DhlProduct.V01PAK,
Shipper = new Address
{
Name = "Max Mustermann",
Street = "Wolfener Str.",
HouseNumber = "32",
PostalCode = "12681",
City = "Berlin",
CountryCode = "DEU"
},
Consignee = new Address
{
Name = "Erika Musterfrau",
Street = "Berliner Straße",
HouseNumber = "42",
PostalCode = "10117",
City = "Berlin",
CountryCode = "DEU"
},
Packages =
[
new Package
{
Weight = 2.5,
Dimensions = new Dimensions { Length = 35, Width = 25, Height = 10 }
}
],
ValueAddedServices = !ReturnLabel ? null : new DhlValueAddedServices
{
DhlRetoure = new DhlRetoureService
{
BillingNumber = "33333333330101",
},
},
Reference = "ORDER-12345",
ShipDate = DateOnly.FromDateTime(DateTime.Today.AddDays(1))
};

Parcel.NET.Dhl.Shipping.Models.ValidationResult validationResult = await dhlShippingClient.ValidateShipmentAsync(dhlShipmentRequest);

if (validationResult.Valid)
{
string sDebug = "sasa";
}
else
{
string sDebug = "sasa";
}

Expected Behavior

XXX

Actual Behavior

XXX

Package

Parcel.NET.Dhl.Shipping

Carrier

DHL

.NET Version

.NET 9

Package Version

1.0.1

Additional Context

No response

[Bernhard231]

Hello again :-) could made a workaround, but if you could add the returnaddress in your amazing project would be better, thank you

as Workaround added DhlApiShipper shipper to MapServices

private static DhlApiServices? MapServices(DhlValueAddedServices? vas, DhlApiShipper shipper)
{
    if (vas is null)
        return null;

    return new DhlApiServices
    {
        PreferredDay = vas.PreferredDay,
        PreferredLocation = vas.PreferredLocation,
        PreferredNeighbour = vas.PreferredNeighbour,
        BulkyGoods = vas.BulkyGoods ? true : null,
        NamedPersonOnly = vas.NamedPersonOnly ? true : null,
        NoNeighbourDelivery = vas.NoNeighbourDelivery ? true : null,
        SignedForByRecipient = vas.SignedForByRecipient ? true : null,
        Premium = vas.Premium ? true : null,
        ClosestDropPoint = vas.ClosestDropPoint ? true : null,
        PostalDeliveryDutyPaid = vas.PostalDeliveryDutyPaid ? true : null,
        Endorsement = vas.Endorsement,
        VisualCheckOfAge = vas.VisualCheckOfAge,
        ParcelOutletRouting = vas.ParcelOutletRouting,
        AdditionalInsurance = vas.InsuredValue.HasValue
            ? new DhlApiMonetaryValue { Currency = vas.InsuredValueCurrency ?? "EUR", Value = vas.InsuredValue.Value }
            : null,
        CashOnDelivery = vas.CashOnDelivery is not null
            ? new DhlApiCashOnDelivery
            {
                Amount = new DhlApiMonetaryValue
                {
                    Currency = vas.CashOnDelivery.Currency,
                    Value = vas.CashOnDelivery.Amount
                },
                BankAccount = vas.CashOnDelivery.Iban is not null
                    ? new DhlApiBankAccount
                    {
                        AccountHolder = vas.CashOnDelivery.AccountHolder ?? "",
                        Iban = vas.CashOnDelivery.Iban,
                        Bic = vas.CashOnDelivery.Bic
                    }
                    : null,
                AccountReference = vas.CashOnDelivery.AccountReference,
                TransferNote1 = vas.CashOnDelivery.TransferNote1,
                TransferNote2 = vas.CashOnDelivery.TransferNote2
            }
            : null,
        IdentCheck = vas.IdentCheck is not null
            ? new DhlApiIdentCheck
            {
                FirstName = vas.IdentCheck.FirstName,
                LastName = vas.IdentCheck.LastName,
                DateOfBirth = vas.IdentCheck.DateOfBirth,
                MinimumAge = vas.IdentCheck.MinimumAge
            }
            : null,
        DhlRetoure = vas.DhlRetoure is not null
            ? new DhlApiRetoure
            {
                BillingNumber = vas.DhlRetoure.BillingNumber,
                ReturnAddress = shipper
            }
            : null
    };
}

and added the shipper at the call within DhlOrderRequest

Services = MapServices(request.ValueAddedServices, MapShipper(request.Shipper, request.ShipperContact)),