flake: TestTemplatePush/Variables/PromptForDifferentRequiredTypes

[flake-investigator]

CI Run Link: https://github.com/coder/coder/actions/runs/22240419353
Job: test-go-pg (macos-latest) https://github.com/coder/coder/actions/runs/22240419353/job/64342844864
Commit: de4ff78cd171d42a39ae8537863c0862c0c15fdb (Jeremy Ruppel)

What failed:

• cli TestTemplatePush/Variables/PromptForDifferentRequiredTypes
• Additional unknown failures reported in the same run (e.g., TestTemplatePush/ProvisionerTags/WorkspaceTagsTerraform, TestServer/LocalAccessURL, TestServer/NoTLSAddress), likely cascading from the same hang.

Error excerpt:

ptytest.go:170: cmd: read error: match deadline exceeded: context deadline exceeded (wanted "Upload"; got "")
    Error Trace: /Users/runner/work/coder/coder/pty/ptytest/ptytest.go:375
                 /Users/runner/work/coder/coder/pty/ptytest/ptytest.go:199
                 /Users/runner/work/coder/coder/pty/ptytest/ptytest.go:170
                 /Users/runner/work/coder/coder/cli/templatepush_test.go:1101
    Test: TestTemplatePush/Variables/PromptForDifferentRequiredTypes
    Messages: match deadline exceeded: context deadline exceeded (wanted "Upload"; got "")
clitest.go:280: command "coder templates push" timed out during test cleanup
clitest.go:283: command "coder templates push" exited with error: running command "coder templates push": context deadline exceeded

Data race / crash checks:

• Reviewed log segments around the failure; no WARNING: DATA RACE, panic, or OOM indicators found.

Root cause assessment:

• Flaky PTY/CLI prompt timeout on macOS. The coder templates push interactive prompt did not emit the expected "Upload" prompt before the test context deadline, causing the PTY expect to time out and leaving the command hung in cleanup.

Test location:

• cli/templatepush_test.go (subtest PromptForDifferentRequiredTypes, around line 1056 in main)

Assignment analysis:

• git log --oneline -10 --follow cli/templatepush_test.go
  • 761dd55 ("fix(coderd/database): sort template version variables and fix test flake") by Mathias Fredriksson
  • bb58844 ("feat(cli): prompt for missing required template variables on template creation") by Rafael Rodriguez
• Assigning to @mafredri based on the most recent meaningful changes tied to the prompt/ordering behavior under test.

Related issues:

• Test flake: cli TestServer/EphemeralDeployment #549 (similar PTY match deadline exceeded in CLI tests)
• flake: TestServer_TelemetryDisabled_FinalReport #1331 (PTY timeout in TestServer)

Reproduction:

• go test ./cli -run TestTemplatePush/Variables/PromptForDifferentRequiredTypes -count=1 (macOS runner)