Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

Commit dcbc9a8

Browse files
committed
add logging and bug fixes
1 parent 35e9bf5 commit dcbc9a8

File tree

5 files changed

+49
-14
lines changed

5 files changed

+49
-14
lines changed

cloudflare_v4/__init__.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
# because everything logs
2-
import logging
3-
41
# all the exceptions
52
from exceptions import CloudFlareError, CloudFlareAPIError
63

@@ -9,8 +6,6 @@
96
# depends on exceptions
107
from util import call
118

12-
# depends on util
13-
from zones import get
14-
from user import get
15-
16-
__all__ = [ 'CloudFlareError', 'CloudFlareAPIError' ]
9+
__all__ = [ 'CloudFlareError', 'CloudFlareAPIError',
10+
'zones', 'user',
11+
'util' ]

cloudflare_v4/construct.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
import zones
2+
import user
3+
14
class CloudFlare(object):
25
def __init__(self, email, token):
36
self.EMAIL = email

cloudflare_v4/logger.py

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
import logging
2+
3+
DEBUG = 0
4+
INFO = 1
5+
6+
class Logger:
7+
def __init__(self, level):
8+
self.logger_level = self.get_level(level)
9+
10+
def getLogger(self):
11+
# create logger
12+
logger = logging.getLogger('Python CloudFlare API v4')
13+
logger.setLevel(self.logger_level)
14+
15+
# create console handler and set level to debug
16+
ch = logging.StreamHandler()
17+
ch.setLevel(logging.DEBUG)
18+
19+
# create formatter
20+
formatter = logging.Formatter('%(asctime)s - %(name)s - %(levelname)s - %(message)s')
21+
22+
# add formatter to ch
23+
ch.setFormatter(formatter)
24+
25+
# add ch to logger
26+
logger.addHandler(ch)
27+
28+
return logger
29+
30+
def get_level(self, level):
31+
if level == 0:
32+
return logging.DEBUG
33+
else:
34+
return logging.INFO

cloudflare_v4/util.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
11
from . import CloudFlareError, CloudFlareAPIError
2+
from . import logger
23

34
import json
45
import requests
56

7+
logger = logger.Logger(logger.DEBUG).getLogger()
8+
69
def call(auth, method, endpoint, params=None):
7-
logging.debug('auth')
8-
logging.debug('method')
9-
logging.debug('endpoint')
10-
logging.debug('params')
10+
logger.debug(auth)
11+
logger.debug(method)
12+
logger.debug(endpoint)
13+
logger.debug(params)
1114
if (auth is None) or (method is None) or (endpoint is None):
1215
raise CloudFlareError('You must specify auth, method, and endpoint')
1316
else:
@@ -18,7 +21,7 @@ def call(auth, method, endpoint, params=None):
1821
params=params
1922
)
2023
data = response.text
21-
logging.debug('data')
24+
logger.debug(data)
2225
try:
2326
data = json.loads(data)
2427
return data

cloudflare_v4/zones/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ def get(auth, params=None):
66
if type(params) is dict:
77
return util.call(auth, 'GET', ENDPOINT, params)
88
elif type(params) is str:
9-
return util.call(auth)
9+
return util.call(auth, 'GET', ENDPOINT + '/' + params)

0 commit comments

Comments
 (0)