cat -n packages/upgrade/src/codemods/transform-satellite-auto-sync.cjs

cat > /tmp/test_spreads.js << 'EOF'
// Test JSX spread override semantics
// In JSX: <Component isSatellite {...obj} satelliteAutoSync={true} />
// Does the explicit attribute AFTER the spread override the spread's value?

// For objects: { isSatellite: true, ...obj, satelliteAutoSync: true }
// Does the property AFTER the spread override?

// Let's verify with a simple example
const obj = { satelliteAutoSync: false, other: 123 };

// Object property override
const result1 = { isSatellite: true, ...obj, satelliteAutoSync: true };
console.log("Object with spread BEFORE override:");
console.log("  Input: { isSatellite: true, ...{satelliteAutoSync: false}, satelliteAutoSync: true }");
console.log("  Result satelliteAutoSync:", result1.satelliteAutoSync);
console.log("  Spread is overridden by later property? ", result1.satelliteAutoSync === true ? "YES" : "NO");

const result2 = { isSatellite: true, satelliteAutoSync: true, ...obj };
console.log("\nObject with spread AFTER property:");
console.log("  Input: { isSatellite: true, satelliteAutoSync: true, ...{satelliteAutoSync: false} }");
console.log("  Result satelliteAutoSync:", result2.satelliteAutoSync);
console.log("  Spread overrides property? ", result2.satelliteAutoSync === false ? "YES (PROBLEM)" : "NO");
EOF
node /tmp/test_spreads.js

cat > /tmp/analyze_code.js << 'EOF'
// Simulate the current codemod logic with different spread positions

// For objects: current code does:
// const isSatelliteIndex = properties.findIndex(prop => isObjectPropertyNamed(prop, 'isSatellite'));
// properties.splice(isSatelliteIndex + 1, 0, autoSyncProp);

console.log("=== Object property insertion analysis ===\n");

// Case 1: Spread BEFORE isSatellite
console.log("Case 1: { ...obj, isSatellite: true }");
console.log("  isSatelliteIndex = 1");
console.log("  splice(1 + 1, 0, autoSyncProp)");
console.log("  Result: [ ...obj, isSatellite, satelliteAutoSync, ... ]");
console.log("  Override risk: NO (property after spread wins)\n");

// Case 2: Spread AFTER isSatellite  
console.log("Case 2: { isSatellite: true, ...obj }");
console.log("  isSatelliteIndex = 0");
console.log("  splice(0 + 1, 0, autoSyncProp)");
console.log("  Result: [ isSatellite, satelliteAutoSync, ...obj, ... ]");
console.log("  Override risk: YES (spread after property wins)\n");

// For JSX: current code does:
// attributes.push(autoSyncAttr);

console.log("=== JSX attribute append analysis ===\n");

console.log("JSX appends attribute at END (last position)");
console.log("  After push: [ ...any, isSatellite, ...any, satelliteAutoSync=true ]");
console.log("  Key point: Is there ANYTHING after the push?");
console.log("  If spread is already last: spreads at END would follow the attribute");
console.log("  But push adds to end, so new attr is always last");
console.log("  Override risk: Need to check JSX semantics for attributes after spreads\n");
EOF
node /tmp/analyze_code.js

cat > /tmp/verify_risk.js << 'EOF'
console.log("=== RISK ANALYSIS ===\n");

console.log("OBJECT CASE: Properties order matters\n");

// Case A: Spread BEFORE isSatellite
console.log("A. { ...obj (with satelliteAutoSync: false), isSatellite: true }");
console.log("   isSatelliteIndex = 1");
console.log("   splice(1+1=2, 0, satelliteAutoSync=true)");
console.log("   Result: [ ...obj, isSatellite, satelliteAutoSync, ] ");
console.log("   Outcome: satelliteAutoSync is AFTER spread → WINS (true is correct)");
console.log("   Risk: NONE\n");

// Case B: Spread AFTER isSatellite
console.log("B. { isSatellite: true, ...obj (with satelliteAutoSync: false) }");
console.log("   isSatelliteIndex = 0");
console.log("   splice(0+1=1, 0, satelliteAutoSync=true)");
console.log("   Result: [ isSatellite, satelliteAutoSync, ...obj, ]");
console.log("   Outcome: satelliteAutoSync is BEFORE spread → LOSES (false overrides true)");
console.log("   Risk: CRITICAL! User's satelliteAutoSync:false is lost\n");

console.log("JSX CASE: Attributes order matters\n");

console.log("C. <Comp isSatellite {...obj (with satelliteAutoSync: false)} />");
console.log("   attributes.push() appends to end");
console.log("   Result: [ isSatellite, ...spread, satelliteAutoSync=true ]");
console.log("   Transpiles to: { isSatellite, ...obj, satelliteAutoSync: true }");
console.log("   Outcome: satelliteAutoSync is AFTER spread → WINS (true is correct)");
console.log("   Risk: NONE\n");

console.log("D. <Comp {...obj (with satelliteAutoSync: false)} isSatellite />");
console.log("   attributes.push() appends to end");
console.log("   Result: [ ...spread, isSatellite, satelliteAutoSync=true ]");
console.log("   Transpiles to: { ...obj, isSatellite, satelliteAutoSync: true }");
console.log("   Outcome: satelliteAutoSync is AFTER spread → WINS (true is correct)");
console.log("   Risk: NONE\n");

console.log("CONCLUSION:");
console.log("- JSX: SAFE (push always appends to end)");
console.log("- Objects: RISKY when spread comes AFTER isSatellite");
EOF
node /tmp/verify_risk.js

cat > /tmp/check_hasAutoSync.js << 'EOF'
// Check if hasAutoSync guards against the spread override risk

console.log("=== hasAutoSync check analysis ===\n");

console.log("Code: const hasAutoSync = properties.some(prop => isObjectPropertyNamed(prop, 'satelliteAutoSync'));");
console.log("This checks if satelliteAutoSync exists ANYWHERE in properties.\n");

console.log("Risk scenario:");
console.log("{ isSatellite: true, ...obj }  // obj = { satelliteAutoSync: false }");
console.log("hasAutoSync checks the actual properties array");
console.log("properties = [ {isSatellite}, {spread} ]");
console.log("The spread node itself is type: SpreadElement/SpreadProperty");
console.log("hasAutoSync looks for properties with name 'satelliteAutoSync'");
console.log("The spread doesn't have a 'name', so it's not detected by isObjectPropertyNamed");
console.log("Result: hasAutoSync = false (spread content is not inspected)");
console.log("Code proceeds to add the property at wrong position");
console.log("Conclusion: hasAutoSync does NOT protect against spread override risk");
EOF
node /tmp/check_hasAutoSync.js