Add align left option for String

[paddymul]

Checks

• I have checked that this enhancement has not already been requested

How would you categorize this request. You can select multiple if not sure

Display (is this related to visual display of a value)

Enhancement Description

Strings are text-align:right by default. Add an option for text-align:left

Pseudo Code Implementation

it's tricky because this needs to be a styler as well

Prior Art

N/a

[paddymul]

Implementation Plan

Overview

Add a left-alignment option for string columns in the AG Grid display.

Steps

1. Column config option — add "text_align" to the column config schema:

   • Values: "left", "right", "center"
   • Default: "left" for string columns, "right" for numeric columns

2. JS: Apply cell style — in the AG Grid column definition builder:

   • Read text_align from column config
   • Set cellStyle: { textAlign: config.text_align } on the ColDef

3. Auto-detection — in the analysis pipeline:

   • Set default alignment based on dtype: strings → left, numbers → right, dates → left
   • Users can override via column_config_overrides

4. Tests: Playwright test verifying string columns are left-aligned and numeric columns are right-aligned.

Files to modify

• Column config schema — add text_align field
• packages/buckaroo-js-core/src/components/DFViewerParts/ — cell style from config
• Analysis pipeline — auto-detect alignment

@codex

[chatgpt-codex-connector]

Summary

• Added a new text_align column-config field to the shared schema/types in Python and TypeScript ("left" | "right" | "center"), so alignment can be carried from analysis through rendering config. buckaroo/dataflow/styling_core.pyL122-L152 packages/buckaroo-js-core/src/components/DFViewerParts/DFWhole.tsL152-L172
• Implemented dtype-driven alignment defaults in the styling analysis pipeline:
  • integers/floats default to right
  • datetimes default to left
  • strings/other default to left
    This also keeps override behavior intact via existing column-config merge/update flow. buckaroo/customizations/styling.pyL18-L39
• Updated AG Grid ColDef generation to apply alignment from text_align while preserving existing color-map cellStyle behavior by merging both style sources. packages/buckaroo-js-core/src/components/DFViewerParts/gridUtils.tsL104-L133
• Added/updated tests and fixtures:
  • New Python tests for default dtype alignment + column_config_overrides override behavior.
  • Updated existing strict expected config assertions to include new alignment defaults.
  • Added a Playwright spec to assert numeric cells render right-aligned and string/object cells render left-aligned.
  • Updated the DFViewerInfiniteRaw story fixture to include explicit text_align values used by the browser test. tests/unit/dataflow/customizable_dataflow_test.pyL350-L405 packages/buckaroo-js-core/pw-tests/column-text-align.spec.tsL1-L16 packages/buckaroo-js-core/src/stories/DFViewerInfiniteRaw.stories.tsxL85-L124

Testing

• ✅ cd /workspace/buckaroo/packages/buckaroo-js-core && npm test -- --runInBand src/components/DFViewerParts/gridUtils.test.ts
• ⚠️ cd /workspace/buckaroo && pytest -q tests/unit/dataflow/customizable_dataflow_test.py (environment limitation: pandas is not installed in this container)
• ⚠️ cd /workspace/buckaroo/packages/buckaroo-js-core && npx playwright test pw-tests/column-text-align.spec.ts (environment limitation: Storybook webServer failed to start with spawn none ENOENT in this environment)

Committed to current branch and created a follow-up PR via make_pr as requested.

Screenshot note: I attempted to capture a browser screenshot of the updated story, but the Storybook endpoint was unavailable in this environment (ERR_EMPTY_RESPONSE), so I couldn’t produce an artifact image.

View task →