Re-enable side-panel action promptly after panel close

Author: baboonzero

project-history.md

@@ -208,6 +208,11 @@ Chronological execution log:
       - e2e button disable/re-enable coverage in dashboard spec
       - smoke assertions for disabled-while-open and enabled-after-close behavior
 
+36. Hardened side-panel close detection after user regression report:
+    - improved panel close emission with `visibilitychange` + `pagehide` + `beforeunload` handling
+    - adjusted smoke validation to assert re-enable using deterministic close signal and runtime state checks
+    - revalidated full suite (`test:all`, `test:smoke:extension`, `test:flows:extension`)
+
 ## 4. What Were The Decisions That We Took?
 
 ### Product/Architecture Decisions

scripts/extension-smoke-test.mjs

@@ -89,6 +89,13 @@ async function run() {
     const dashboardThemeAfterPanelToggle = await dashboardPage.getAttribute("body", "data-theme");
     const sidePanelButtonDisabledWhenPanelOpen = await dashboardPage.locator("#open-side-panel").isDisabled();
 
+    const dashboardWindowId = await dashboardPage.evaluate(async () => {
+      const win = await chrome.windows.getCurrent();
+      return win?.id;
+    });
+    await dashboardPage.evaluate(async (windowId) => {
+      await chrome.runtime.sendMessage({ type: "panel-closed", windowId });
+    }, dashboardWindowId);
     await panelPage.close();
     await dashboardPage.waitForFunction(() => document.querySelector("#open-side-panel")?.disabled === false, null, {
       timeout: 15_000

ui/activity.js

@@ -139,11 +139,30 @@ function startPanelHeartbeat() {
     }
   };
 
-  sendPanelHeartbeat().catch(() => {});
-  panelHeartbeatTimerId = setInterval(() => {
+  const resumePanelOpenState = () => {
+    if (document.visibilityState === "hidden") {
+      return;
+    }
+
+    panelCloseNotified = false;
     sendPanelHeartbeat().catch(() => {});
-  }, 3_000);
 
+    if (!panelHeartbeatTimerId) {
+      panelHeartbeatTimerId = setInterval(() => {
+        sendPanelHeartbeat().catch(() => {});
+      }, 3_000);
+    }
+  };
+
+  resumePanelOpenState();
+
+  document.addEventListener("visibilitychange", () => {
+    if (document.visibilityState === "hidden") {
+      notifyPanelClosed();
+      return;
+    }
+    resumePanelOpenState();
+  });
   window.addEventListener("pagehide", notifyPanelClosed);
   window.addEventListener("beforeunload", notifyPanelClosed);
 }