Skip to content

sched: Optimize reader-writer semaphore and achieve MISRA HIS goto compliance #18210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoxiang781216 merged 2 commits into from
Feb 3, 2026
Merged

sched: Optimize reader-writer semaphore and achieve MISRA HIS goto compliance #18210

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eec686
sem_rw: optimize up_read/up_write API
wyr-7 Jan 9, 2025
ca164e6
sem_rw.c: coverity: HIS_metric_violation(HIS_GOTO)
hujun260 Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions sched/semaphore/sem_rw.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,21 +170,19 @@ void up_read(FAR rw_semaphore_t *rwsem)
if (--rwsem->writer <= 0)
{
rwsem->holder = RWSEM_NO_HOLDER;
up_wait(rwsem);
}

goto out;
}

DEBUGASSERT(rwsem->reader > 0);

rwsem->reader--;

if (rwsem->waiter > 0)
else
{
up_wait(rwsem);
DEBUGASSERT(rwsem->reader > 0);

if (--rwsem->reader <= 0)
{
up_wait(rwsem);
}
}

out:
nxmutex_unlock(&rwsem->protected);
}

Expand Down Expand Up @@ -279,10 +277,9 @@ void up_write(FAR rw_semaphore_t *rwsem)
if (--rwsem->writer <= 0)
{
rwsem->holder = RWSEM_NO_HOLDER;
up_wait(rwsem);
}

up_wait(rwsem);

nxmutex_unlock(&rwsem->protected);
}

Expand Down
Loading