feat(openviking): continuation after plugin hardening#150
Open
mczabca-boop wants to merge 28 commits intoTinyAGI:mainfrom
Open
feat(openviking): continuation after plugin hardening#150mczabca-boop wants to merge 28 commits intoTinyAGI:mainfrom
mczabca-boop wants to merge 28 commits intoTinyAGI:mainfrom
Conversation
Collaborator
Author
SummaryThis PR continues the OpenViking integration/pluginization line ( In short: OpenViking remains fully pluginized, but prefetch is no longer “always-on”; it is now gated rule-first with optional LLM decisioning for ambiguous cases. What This PR Adds1) Rule-first prefetch gate inside
|
This was referenced Feb 28, 2026
fc86072 to
2a5bc26
Compare
This was referenced Mar 3, 2026
…ncurrency - Remove --dangerously-bypass-approvals-and-sandbox from codex LLM gate invocation and --dangerously-skip-permissions from claude invocation - Replace global process.env API key pollution (applyOpenVikingToolEnv) with buildOpenVikingToolEnv() that scopes credentials to each subprocess env only; openviking service spawn and runOpenVikingToolJson both receive env locally via runCommand extraEnv parameter - Rewrite session-map with in-memory cache + serialised async disk flush: mutations apply synchronously to the cache (preserving read-after-write consistency) while disk writes are queued and atomic (tmp + rename) - Add drainSessionMapWrites() for clean shutdown - Add TODO(perf) comment on runOpenVikingToolJson subprocess spawn hot path Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…messages Internal messages are system coordination traffic, not user conversation records. Previously they would fall through to the legacy writeback path and emit a spurious INFO log on every turn. Now afterModel exits early for internal messages before the writeback decision, eliminating the noise. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…otate path When rotateSessionMappingAndCommitAsync runs, it deletes the session from the map and then schedules an async commit. A crash between these two steps left the session unrecoverable because startup recovery only scans the session map. Fix: write a pending-commit marker file (runtime/openviking/pending-commits/) before deleting the map entry, clear it on successful commit, and extend scheduleStartupRecoveryCommit to scan and replay any leftover markers on next startup. Also adds a 'pending-commit-recovery' integration test scenario that simulates the post-crash state (marker present, session map empty) and verifies the recovery commits the session and cleans up the marker. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ation - Add step 6 to Quick Setup with two-tier flag guidance: minimum (SEARCH_NATIVE=1, retrieval only) and recommended (SESSION_NATIVE=1 + SEARCH_NATIVE=1, full session persistence) - Clarify that SESSION_NATIVE defaults to 0 and must be set explicitly - Replace flat Common flags list with a full Prefetch flags table including defaults and descriptions for all env vars - Add new Session Configuration section covering SESSION_NATIVE, SESSION_IDLE_TIMEOUT_MS, SESSION_SWITCH_MARKERS, COMMIT_ON_SHUTDOWN, COMMIT_TIMEOUT_MS, AUTOSYNC, and CLOSED_SESSION_RETENTION_DAYS - Note that internal messages are never written to OpenViking sessions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #149.\n\nThis PR contains the OpenViking continuation stack rebased onto TinyAGI/main (without the PR1 hardening commit).