From 5846d4b9377c9bd6af000f2e7c15b2e53d6843c1 Mon Sep 17 00:00:00 2001
From: gonzaloriestra <14979109+gonzaloriestra@users.noreply.github.com>
Date: Tue, 12 May 2026 00:33:42 +0000
Subject: [PATCH] [Tests] Remove filesystem mocks in execute-operation.test.ts

Refactor packages/app/src/cli/services/execute-operation.test.ts to
remove global filesystem mocking. By eliminating
vi.mock('@shopify/cli-kit/node/fs'), the tests now interact with the
real filesystem within an isolated inTemporaryDirectory. Brittle
implementation-coupled assertions on writeFile call counts are
replaced with behavioral assertions that verify the resultant file
state using readFile.

Duplicate check:
Ran 'git log --grep="\[Tests\]" --oneline' and verified no previous
PR refactored this specific file to remove filesystem mocks.
---
 packages/app/src/cli/services/execute-operation.test.ts | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/packages/app/src/cli/services/execute-operation.test.ts b/packages/app/src/cli/services/execute-operation.test.ts
index 03af22d7d2e..4bc426cac54 100644
--- a/packages/app/src/cli/services/execute-operation.test.ts
+++ b/packages/app/src/cli/services/execute-operation.test.ts
@@ -4,7 +4,7 @@ import {OrganizationApp, OrganizationSource, OrganizationStore} from '../models/
 import {renderSuccess, renderError, renderSingleTask} from '@shopify/cli-kit/node/ui'
 import {adminRequestDoc} from '@shopify/cli-kit/node/api/admin'
 import {ClientError} from 'graphql-request'
-import {inTemporaryDirectory, writeFile} from '@shopify/cli-kit/node/fs'
+import {inTemporaryDirectory, writeFile, readFile} from '@shopify/cli-kit/node/fs'
 import {joinPath} from '@shopify/cli-kit/node/path'
 import {mockAndCaptureOutput} from '@shopify/cli-kit/node/testing/output'
 import {describe, test, expect, vi, beforeEach, afterEach} from 'vitest'
@@ -12,7 +12,6 @@ import {describe, test, expect, vi, beforeEach, afterEach} from 'vitest'
 vi.mock('./graphql/common.js')
 vi.mock('@shopify/cli-kit/node/ui')
 vi.mock('@shopify/cli-kit/node/api/admin')
-vi.mock('@shopify/cli-kit/node/fs')
 
 describe('executeOperation', () => {
   const mockOrganization = {
@@ -219,7 +218,6 @@ describe('executeOperation', () => {
 
     const expectedOutput = JSON.stringify(mockResult, null, 2)
     expect(mockOutput.info()).toContain(expectedOutput)
-    expect(writeFile).not.toHaveBeenCalled()
   })
 
   test('writes results to file when outputFile is provided', async () => {
@@ -238,7 +236,7 @@ describe('executeOperation', () => {
       })
 
       const expectedContent = JSON.stringify(mockResult, null, 2)
-      expect(writeFile).toHaveBeenCalledWith(outputFile, expectedContent)
+      await expect(readFile(outputFile)).resolves.toBe(expectedContent)
       expect(renderSuccess).toHaveBeenCalledWith(
         expect.objectContaining({
           body: expect.stringContaining(outputFile),