-
Notifications
You must be signed in to change notification settings - Fork 31
Remove redundant pre-processor symbol MCUBOOT_TARGET_CONFIG #29
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workinginternal bug trackerIssue confirmed and logged into the internal bug tracking systemIssue confirmed and logged into the internal bug tracking systemprojectsProjects-related (demos, applications, examples) issue or pull-request.Projects-related (demos, applications, examples) issue or pull-request.rotRoot Of TrustRoot Of Trust
Milestone
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinginternal bug trackerIssue confirmed and logged into the internal bug tracking systemIssue confirmed and logged into the internal bug tracking systemprojectsProjects-related (demos, applications, examples) issue or pull-request.Projects-related (demos, applications, examples) issue or pull-request.rotRoot Of TrustRoot Of Trust
Type
Fields
Give feedbackNo fields configured for Bug.
Projects
Status
Analyzed
Describe the set-up
Describe the bug
Projects/*/Applications/ROT/OEMiROT_Boot
All the IDE-configs seem to add
'-DMCUBOOT_TARGET_CONFIG=<flash_layout.h>'to the build command line.I have only tested with STM32CubeIDE but it is present in EWARM/Project.ewp and MDK-ARM/Project.uvprojx too.
This preprocessor symbol is redundant. No code tests for it.
In the upstream mcuboot 1.7.2 it is used in
boot/zephyr/include/target.hbut this file is not present in Middlewares/Third_Party/mcuboot/ in this git. There is no Zephyr support in this git. And to my understanding (which I admit is limited), if you want to boot Zephyr using mcuboot, you build mcuboot as part of Zephyr. OEMiROT_Boot cannot be used for this purpose.Suggested fix
Remove
'-DMCUBOOT_TARGET_CONFIG=<flash_layout.h>'from the project configs for EWARM, MDK-ARM and STM32CubeIDE.