update RCModEQ to 1.2.2

Author: RCJacH

JSFX/Audio/RCModEQ/RCModEQ.jsfx

@@ -3,7 +3,7 @@ JSFX Name: RCModEQ
 Author: RCJacH
 Release Date: Aug 2025
 Link: https://github.com/RCJacH/ReaScripts
-Version: 1.2.1
+Version: 1.2.2
 Provides:
   dependencies/*
 Reference:
@@ -16,6 +16,10 @@ About:
   It lets you stack up to eight filters and drive their parameters with
   up to eight shape-selectable and deformable LFOs.
 Changelog:
+  * v1.2.2 (2026-02-21)
+    * Fix LFO amp offset with unipolar routing
+    * Fix LFO bar reset
+    * Fix MIDI note on not parsed
   * v1.2.1 (2026-01-28)
     + Fix sc rms converted value not updated when srate changes
     * Fix 1.1 migration function
@@ -705,7 +709,7 @@ out_pin:Right Output
     global()
     (
       set_SVF_type_2(idx, type);
-      notify_touched_filter_type(idx, type, is_end);
+      notify_touched_filter_type2(idx, type, is_end);
     );
 
   function set_filter_spread(idx, spread, is_end)
@@ -1122,7 +1126,7 @@ out_pin:Right Output
   CUR_TEMPO = tempo;
   router_update_active_routes(TOTAL_LFO_COUNT);
   while (midirecv(offset, msg1, msg2, msg3)) (
-    status = $xF0;
+    status = msg1 & $xF0;
     (status == STATUS_NOTE_ON && msg3) ? maybe_parse_all_LFO_midi_reset(TOTAL_LFO_COUNT, offset);
   );
 
@@ -3869,9 +3873,9 @@ out_pin:Right Output
         ui_drawSliderModOverlay(
           x1, y0, w1, h0,
           0,
-          get_router_route_bipolar(g_mod_route_idx, idx, ROUTER_AMOUNT_OFFSET),
+          get_router_route_bipolar(g_mod_route_idx, idx, ROUTER_LFO_AMP),
           mod_color_mem,
-          !get_router_route_bypassed(g_mod_route_idx, idx, ROUTER_AMOUNT_OFFSET),
+          !get_router_route_bypassed(g_mod_route_idx, idx, ROUTER_LFO_AMP),
           sl_amp.v_xl,
           ctrl_amp_mod.v_yl
         );

JSFX/Audio/RCModEQ/dependencies/lfo.jsfx-inc

@@ -72,10 +72,11 @@ LFO_RATE_MODE_BAR = 2;
 LFO_SYNC_TIME_LOOKUP_TABLE = 0;
 LFO_SYNC_TIME_LOOKUP_TABLE_COUNT = 0;
 
-prev_ts_change_play_position = 0;
 prev_play_state = play_state & 1;
 prev_ts_num     = ts_num;
 prev_ts_denom   = ts_denom;
+prev_bar_phase  = beat_position - floor(beat_position / max(0.000000001, (4. * ts_num / ts_denom))) * max(0.000000001, (4. * ts_num / ts_denom));
+prev_beat_position = beat_position;
 
 // ───────────── HELPERS ─────────────
 function round(x) global() ( floor(x + .5); );
@@ -557,13 +558,18 @@ function _get_lfo_inc(rate, rate_mode)
   );
 
 function maybe_parse_LFO_midi_reset(idx, offset)
-  local(mem)
-  global(LFO_TRIGGER_MODE_OFFSET, LFO_TRIGGER_MODE_MIDI_RESET)
+  local(mem, trigger_offset)
+  global(LFO_TRIGGER_MODE_OFFSET, LFO_TRIGGER_MODE_MIDI_RESET, LFO_MIDI_TRIG_OFFSET)
   (
     mem = get_LFO_mem_pos(idx);
-    mem[LFO_TRIGGER_MODE_OFFSET] = (
-      mem[LFO_TRIGGER_MODE_OFFSET] == LFO_TRIGGER_MODE_MIDI_RESET ?
-        offset : 0;
+    mem[LFO_TRIGGER_MODE_OFFSET] == LFO_TRIGGER_MODE_MIDI_RESET ? (
+      // +1 so an event at sample offset 0 triggers on the first @sample frame.
+      trigger_offset = offset + 1;
+      mem[LFO_MIDI_TRIG_OFFSET] = (
+        mem[LFO_MIDI_TRIG_OFFSET] ?
+          min(mem[LFO_MIDI_TRIG_OFFSET], trigger_offset)
+        : trigger_offset
+      );
     );
   );
 
@@ -587,14 +593,13 @@ function maybe_parse_all_LFO_midi_reset(lfo_count, offset)
       • keep its own book-keeping data.
 ------------------------------------------------------------------------*/
 function maybe_reset_LFO_phase(idx)
-  local(mem, trig, reset, beats, beatsPerBarQN, bar_idx)
+  local(mem, trig, reset, beatsPerBarQN, bar_phase, delta_beats)
   global(
-        tempo, play_state, play_position, ts_num, ts_denom,
-        prev_ts_change_play_position,
+        tempo, play_state, beat_position, ts_num, ts_denom,
 
-        prev_play_state, prev_ts_num, prev_ts_denom,
+        prev_play_state, prev_ts_num, prev_ts_denom, prev_bar_phase, prev_beat_position,
 
-        LFO_TRIGGER_MODE_OFFSET, LFO_PREV_BAR_OFFSET,
+        LFO_TRIGGER_MODE_OFFSET,
         LFO_MIDI_TRIG_OFFSET,
 
         LFO_TRIGGER_MODE_FREERUN,
@@ -616,11 +621,17 @@ function maybe_reset_LFO_phase(idx)
       /*──────────────── 2. BAR_RESET (new bar or meter change) ──*/
       (trig == LFO_TRIGGER_MODE_BAR_RESET) ?
       (
-        (ts_num != prev_ts_num) || (ts_denom != prev_ts_denom) ||
-          (play_position < prev_ts_change_play_position) ?
-            prev_ts_change_play_position = floor(play_position);
-        beats = play_position - prev_ts_change_play_position;
-        reset = (beats % ts_num) == 0;
+        beatsPerBarQN = max(0.000000001, qn_time_to_full_measure());
+        delta_beats = beat_position - prev_beat_position;
+        bar_phase = beat_position - floor(beat_position / beatsPerBarQN) * beatsPerBarQN;
+        reset = (
+          bar_phase < prev_bar_phase
+            || delta_beats < 0
+            || delta_beats > beatsPerBarQN
+            || ts_num != prev_ts_num
+            || ts_denom != prev_ts_denom
+            || (play_state&1 && !prev_play_state)
+        );
       );
 
       /*──────────────── 3. MIDI_RESET (count down) ───────────*/
@@ -647,7 +658,7 @@ function process_LFO(idx)
     LFO_RATE_MODE_OFFSET, LFO_HZ_RATE_OFFSET, LFO_SYNC_RATE_OFFSET,
     LFO_RATE_MOD_OFFSET, LFO_SHAPE_OFFSET,
     LFO_START_PHASE_OFFSET, LFO_START_PHASE_MOD_OFFSET,
-    LFO_DEFORM_OFFSET, LFO_DEFORM_MOD_OFFSET, LFO_AMP_OFFSET, LFO_AMP_MOD_OFFSET,
+    LFO_DEFORM_OFFSET, LFO_DEFORM_MOD_OFFSET,
     LFO_V_OFFSET, LFO_PHASE_OFFSET, LFO_PREV_RND_OFFSET, LFO_CUR_RND_OFFSET
   )
   (
@@ -679,9 +690,7 @@ function process_LFO(idx)
       );
 
       out = _get_amp_from_shape_and_phase(shape, deform, spread_phase, prev_rnd, cur_rnd);
-      amp = mem[LFO_AMP_OFFSET] + mem[LFO_AMP_MOD_OFFSET + chan];
-      amp = clamp(amp, 0., 1.);
-      mem[LFO_V_OFFSET + chan] = out * amp;
+      mem[LFO_V_OFFSET + chan] = out;
       mem[LFO_PHASE_OFFSET + chan] = phase;
       mem[LFO_PREV_RND_OFFSET + chan] = prev_rnd;
       mem[LFO_CUR_RND_OFFSET + chan] = cur_rnd;
@@ -690,8 +699,8 @@ function process_LFO(idx)
   );
 
 function process_all_LFOs(lfo_count)
-  local(i)
-  global(play_state, ts_num, ts_denom, prev_play_state, prev_ts_num, prev_ts_denom)
+  local(i, beatsPerBarQN)
+  global(play_state, beat_position, ts_num, ts_denom, prev_play_state, prev_ts_num, prev_ts_denom, prev_bar_phase, prev_beat_position)
   (
     i = 0;
     loop(lfo_count,
@@ -701,6 +710,9 @@ function process_all_LFOs(lfo_count)
       );
       i += 1;
     );
+    beatsPerBarQN = max(0.000000001, qn_time_to_full_measure());
+    prev_bar_phase = beat_position - floor(beat_position / beatsPerBarQN) * beatsPerBarQN;
+    prev_beat_position = beat_position;
     prev_play_state = play_state & 1;
     prev_ts_num     = ts_num;
     prev_ts_denom   = ts_denom;

JSFX/Audio/RCModEQ/dependencies/router.jsfx-inc

@@ -280,12 +280,13 @@ function router_update_active_routes(lfo_count)
 
 
 function process_router(process_type, lfo_count)
-  local(i, mem, chan, v, src_idx, dest, amount, mod_mem, is_bipolar, is_dirty_mem)
+  local(i, mem, chan, v, src_idx, dest, amount, mod_mem, is_bipolar, is_dirty_mem, lfo_mem, amp)
   global(
     g_router_active_route_count,
     ROUTER_IS_BYPASSED_OFFSET, ROUTER_SRC_IDX_OFFSET, ROUTER_DEST_OFFSET, ROUTER_AMOUNT_OFFSET,
     ROUTER_IS_DIRTY_MEM_POS_OFFSET, ROUTER_IS_BIPOLAR_OFFSET,
-    LFO_IS_ACTIVE_OFFSET, LFO_V_OFFSET, SIDECHAIN_V_OFFSET
+    LFO_IS_ACTIVE_OFFSET, LFO_V_OFFSET, SIDECHAIN_V_OFFSET,
+    LFO_AMP_OFFSET, LFO_AMP_MOD_OFFSET
   )
   (
     i = 0;
@@ -297,13 +298,19 @@ function process_router(process_type, lfo_count)
           src_idx = mem[ROUTER_SRC_IDX_OFFSET];
           mod_mem = src_idx < lfo_count ? get_LFO_mem_pos(src_idx) + LFO_V_OFFSET
             : get_SideChain_mem_pos(src_idx - lfo_count) + SIDECHAIN_V_OFFSET;
+          lfo_mem = src_idx < lfo_count ? get_LFO_mem_pos(src_idx) : 0;
           dest = mem[ROUTER_DEST_OFFSET];
           amount = mem[ROUTER_AMOUNT_OFFSET];
           is_bipolar = mem[ROUTER_IS_BIPOLAR_OFFSET];
           chan = 0;
           loop(2,
             v = mod_mem[chan];
             !is_bipolar ? v = (v + 1.) * .5;
+            src_idx < lfo_count ? (
+              amp = lfo_mem[LFO_AMP_OFFSET] + lfo_mem[LFO_AMP_MOD_OFFSET + chan];
+              amp = max(0., min(1., amp));
+              v *= amp;
+            );
             dest[chan] += v * amount;
             chan += 1;
           );

JSFX/Audio/RCModEQ/dependencies/svf_filter.jsfx-inc

@@ -115,7 +115,7 @@ function BW_to_Q(bw_oct)
   global()
   (
     // alpha  =  (ln 2 / 2) · BW
-    alpha      = 0.5 * log(2) * BW_oct;
+    alpha      = 0.5 * log(2) * bw_oct;
     // sinh(alpha) = ½ (e^α – e^–α) – rolled out to avoid a sinh()
     sinh_alpha = 0.5 * ( exp(alpha) - exp(-alpha) );
     // Guard against BW_oct = 0 → sinh_alpha = 0
@@ -124,7 +124,7 @@ function BW_to_Q(bw_oct)
 
 function _svf_get_Q(static_oct, mod_pct)
   local(norm_static, norm_combined)
-  global(SVF_MIN_BW, SVF_MIN_BW, SVF_MAX_BW)
+  global(SVF_MIN_BW, SVF_MAX_BW)
   (
     norm_combined  = static_oct + mod_pct * 4.;
     norm_combined  = clamp(norm_combined, SVF_MIN_BW, SVF_MAX_BW);