Skip to content

Commit 35ba1e7

Browse files
authored
Merge pull request #74 from Project-Funk-Engine/player-notes-art
added new placed note types, and art to the notes
2 parents 0ee00a4 + 9815194 commit 35ba1e7

3 files changed

Lines changed: 40 additions & 6 deletions

File tree

scenes/ChartViewport/ChartManager.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ public NoteArrow AddArrowToLane(
8989
Color colorOverride = default
9090
)
9191
{
92-
var newNote = CreateNote(type, beat); //TODO: Notes on track have unqiue visuals
93-
var loopArrow = CreateNote(type, beat + BeatsPerLoop); //Create a dummy arrow for looping visuals
92+
var newNote = CreateNote(type, note.Name, beat); //TODO: Notes on track have unqiue visuals
93+
var loopArrow = CreateNote(type, note.Name, beat + BeatsPerLoop); //Create a dummy arrow for looping visuals
9494
if (colorOverride != default)
9595
{
9696
newNote.SelfModulate = colorOverride;
@@ -100,11 +100,11 @@ public NoteArrow AddArrowToLane(
100100
return newNote;
101101
}
102102

103-
private NoteArrow CreateNote(ArrowType arrow, int beat = 0)
103+
private NoteArrow CreateNote(ArrowType arrow, string noteName, int beat = 0)
104104
{
105105
var noteScene = ResourceLoader.Load<PackedScene>("res://scenes/NoteManager/note.tscn");
106106
NoteArrow newArrow = noteScene.Instantiate<NoteArrow>();
107-
newArrow.Init(IH.Arrows[(int)arrow], beat);
107+
newArrow.Init(IH.Arrows[(int)arrow], beat, noteName);
108108
newArrow.OutlineSprite.Modulate = IH.Arrows[(int)arrow].Color;
109109

110110
_arrowGroup.AddChild(newArrow);

scenes/NoteManager/note.tscn

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,13 @@
1-
[gd_scene load_steps=4 format=3 uid="uid://ck3bfqy30rjbq"]
1+
[gd_scene load_steps=9 format=3 uid="uid://ck3bfqy30rjbq"]
22

33
[ext_resource type="Texture2D" uid="uid://hfxynr5jdgsp" path="res://scenes/NoteManager/assets/new_arrow.png" id="1_wq1hy"]
44
[ext_resource type="Script" path="res://scenes/NoteManager/scripts/NoteArrow.cs" id="2_lbl4b"]
55
[ext_resource type="Texture2D" uid="uid://cgq2ar3pdmkac" path="res://scenes/NoteManager/assets/arrow_outline.png" id="3_5g4ja"]
6+
[ext_resource type="Texture2D" uid="uid://c3chrsxrulapd" path="res://Classes/Notes/assets/single_note.png" id="4_1l7sl"]
7+
[ext_resource type="Texture2D" uid="uid://caw70lr5e1yiq" path="res://Classes/Notes/assets/double_note.png" id="5_yg3rb"]
8+
[ext_resource type="Texture2D" uid="uid://cdf3g3174du4r" path="res://Classes/Notes/assets/heal_note.png" id="6_lfb4v"]
9+
[ext_resource type="Texture2D" uid="uid://dg0lmu0pip4lr" path="res://Classes/Notes/assets/vampire_note.png" id="7_vcn70"]
10+
[ext_resource type="Texture2D" uid="uid://uksjoqp7p0gq" path="res://Classes/Notes/assets/quarter_note.png" id="8_2o4if"]
611

712
[node name="Right-arrow" type="Sprite2D" node_paths=PackedStringArray("OutlineSprite")]
813
texture = ExtResource("1_wq1hy")
@@ -11,3 +16,23 @@ OutlineSprite = NodePath("Outline")
1116

1217
[node name="Outline" type="Sprite2D" parent="."]
1318
texture = ExtResource("3_5g4ja")
19+
20+
[node name="PlayerBase" type="Sprite2D" parent="."]
21+
visible = false
22+
texture = ExtResource("4_1l7sl")
23+
24+
[node name="PlayerDouble" type="Sprite2D" parent="."]
25+
visible = false
26+
texture = ExtResource("5_yg3rb")
27+
28+
[node name="PlayerHeal" type="Sprite2D" parent="."]
29+
visible = false
30+
texture = ExtResource("6_lfb4v")
31+
32+
[node name="PlayerVampire" type="Sprite2D" parent="."]
33+
visible = false
34+
texture = ExtResource("7_vcn70")
35+
36+
[node name="PlayerQuarter" type="Sprite2D" parent="."]
37+
visible = false
38+
texture = ExtResource("8_2o4if")

scenes/NoteManager/scripts/NoteArrow.cs

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public partial class NoteArrow : Sprite2D
1616
[Export]
1717
public Sprite2D OutlineSprite;
1818

19-
public void Init(ArrowData parentArrowData, int beat)
19+
public void Init(ArrowData parentArrowData, int beat, string noteName)
2020
{
2121
ZIndex = 1;
2222

@@ -25,6 +25,15 @@ public void Init(ArrowData parentArrowData, int beat)
2525

2626
Position += Vector2.Down * (parentArrowData.Node.GlobalPosition.Y);
2727
RotationDegrees = parentArrowData.Node.RotationDegrees;
28+
29+
if (noteName == "EnemyBase")
30+
return;
31+
Sprite2D child = GetNode<Sprite2D>(noteName);
32+
if (child != null)
33+
{
34+
child.Visible = true;
35+
child.RotationDegrees = -parentArrowData.Node.RotationDegrees;
36+
}
2837
}
2938

3039
public override void _Process(double delta)

0 commit comments

Comments
 (0)