Skip to content

[Bug]: Unnecessary alloc usage from patina_internal_cpu #1405

@kuqin12

Description

@kuqin12

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

Current patina_internal_cpu has consumed the alloc module for various functionalities, i.e. setting up the services to forward the interrupt event to a component, leak the PatinaPageTable object into a box for further usage.

This unnecessarily pulled in alloc as dependency for fundamental functionalities, such as basic interrupt manager that sets up IDT and programs the IDTr.

Expected Behavior

The functionalities that requires alloc or global allocator should be guarded behind "alloc" feature flag.

Steps To Reproduce

Try building patina_internal_cpu without providing global allocator, the build will fail even without alloc flag.

Build Environment

- OS(s): Windows 11
- Tool Chain(s): Prod-1.92
- Targets Impacted: X64, AArch64

Version Information

Top of main.

Urgency

Medium

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

Metadata

Metadata

Assignees

Labels

type:bugSomething isn't workingurgency:mediumImportant with a moderate impact

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions