Skip to content

chore!: Make getTruncatedSnap and getTruncatedSnapExpect private#3923

Merged
Mrtenz merged 2 commits intocontroller-refactorsfrom
mrtenz/private-methods
Mar 25, 2026
Merged

chore!: Make getTruncatedSnap and getTruncatedSnapExpect private#3923
Mrtenz merged 2 commits intocontroller-refactorsfrom
mrtenz/private-methods

Conversation

@Mrtenz
Copy link
Copy Markdown
Member

@Mrtenz Mrtenz commented Mar 25, 2026

This changes the getTruncatedSnap and getTruncatedSnapExpect methods on SnapController to be private.


Note

Medium Risk
Medium risk because it is a breaking API surface change: external consumers can no longer call SnapController.getTruncatedSnap* and must switch to other helpers, though runtime behavior is otherwise unchanged.

Overview
Makes SnapController’s getTruncatedSnap/getTruncatedSnapExpect methods private (converted to #getTruncatedSnap/#getTruncatedSnapExpect) and updates all internal event payloads and flows (snapInstalled, snapUpdated, snapEnabled/disabled, snapTerminated, rollback, etc.) to use the new private methods.

Updates tests to stop calling the controller methods directly and instead assert against getTruncatedSnap(...), and documents the breaking removal in the CHANGELOG.

Written by Cursor Bugbot for commit f728514. This will update automatically on new commits. Configure here.

@Mrtenz Mrtenz marked this pull request as ready for review March 25, 2026 14:02
@Mrtenz Mrtenz requested a review from a team as a code owner March 25, 2026 14:02
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.56%. Comparing base (c038fb4) to head (f728514).
⚠️ Report is 1 commits behind head on controller-refactors.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           controller-refactors    #3923      +/-   ##
========================================================
- Coverage                 98.56%   98.56%   -0.01%     
========================================================
  Files                       425      425              
  Lines                     12313    12311       -2     
  Branches                   1934     1934              
========================================================
- Hits                      12136    12134       -2     
  Misses                      177      177              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mrtenz Mrtenz merged commit a1b0a84 into controller-refactors Mar 25, 2026
127 checks passed
@Mrtenz Mrtenz deleted the mrtenz/private-methods branch March 25, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants