chore!: Make getTruncatedSnap and getTruncatedSnapExpect private#3923
Merged
Mrtenz merged 2 commits intocontroller-refactorsfrom Mar 25, 2026
Merged
chore!: Make getTruncatedSnap and getTruncatedSnapExpect private#3923Mrtenz merged 2 commits intocontroller-refactorsfrom
getTruncatedSnap and getTruncatedSnapExpect private#3923Mrtenz merged 2 commits intocontroller-refactorsfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## controller-refactors #3923 +/- ##
========================================================
- Coverage 98.56% 98.56% -0.01%
========================================================
Files 425 425
Lines 12313 12311 -2
Branches 1934 1934
========================================================
- Hits 12136 12134 -2
Misses 177 177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FrederikBolding
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the
getTruncatedSnapandgetTruncatedSnapExpectmethods onSnapControllerto be private.Note
Medium Risk
Medium risk because it is a breaking API surface change: external consumers can no longer call
SnapController.getTruncatedSnap*and must switch to other helpers, though runtime behavior is otherwise unchanged.Overview
Makes
SnapController’sgetTruncatedSnap/getTruncatedSnapExpectmethods private (converted to#getTruncatedSnap/#getTruncatedSnapExpect) and updates all internal event payloads and flows (snapInstalled,snapUpdated,snapEnabled/disabled,snapTerminated, rollback, etc.) to use the new private methods.Updates tests to stop calling the controller methods directly and instead assert against
getTruncatedSnap(...), and documents the breaking removal in theCHANGELOG.Written by Cursor Bugbot for commit f728514. This will update automatically on new commits. Configure here.