Skip to content

fix(domains): standardize all domain names to lowercase#20

Merged
Leosgp merged 1 commit intomainfrom
ai_new
Mar 2, 2026
Merged

fix(domains): standardize all domain names to lowercase#20
Leosgp merged 1 commit intomainfrom
ai_new

Conversation

@Leosgp
Copy link
Collaborator

@Leosgp Leosgp commented Mar 2, 2026

Convert all capitalized domain names to lowercase to maintain consistency across the repository, following the standards defined in DOMAINS.md.

Changes:

  • Converted 69 files with uppercase domain names to lowercase
  • Fixed domains including: Agriculture→agriculture, Artificial Intelligence→artificial intelligence, Banking→banking, Chemistry→chemistry, and many more
  • All domain validation checks now pass

Resolves domain case inconsistencies identified by check_domains.py

🤖 Generated with Claude Code

Convert all capitalized domain names to lowercase to maintain consistency
across the repository, following the standards defined in DOMAINS.md.

Changes:
- Converted 69 files with uppercase domain names to lowercase
- Fixed domains including: Agriculture→agriculture, Artificial Intelligence→artificial intelligence,
  Banking→banking, Chemistry→chemistry, and many more
- All domain validation checks now pass

Resolves domain case inconsistencies identified by check_domains.py

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
Copy link

claude bot commented Mar 2, 2026

Code Review

Overview

This PR successfully standardizes all domain names to lowercase across 69 source metadata files, bringing the repository into full compliance with the naming convention defined in firstdata/schemas/DOMAINS.md.

✅ Strengths

1. Comprehensive Coverage

  • Successfully updated all 69 files with capitalized domain names
  • Consistent transformation pattern across all changes (e.g., "Structural Biology" → "structural biology")
  • No files appear to have been missed

2. Follows Project Standards

  • Aligns perfectly with DOMAINS.md requirement: "All domain names MUST use lowercase letters"
  • Correctly handles multi-word domains using spaces (not hyphens or underscores)
  • Examples: "artificial intelligence", "machine learning", "environmental sciences"

3. Quality Improvements

  • Adds missing newlines at end of JSON files (good practice for version control)
  • All validation checks now pass (confirmed by running check_domains.py)
  • CI checks (protect-schema, validate) are passing

4. Proper Documentation

  • Clear PR description explaining the changes
  • References the validation script used to identify issues
  • Links the changes to the DOMAINS.md standard

🔍 Analysis

Changed Domains (Sample)

  • Agriculture → agriculture
  • Artificial Intelligence → artificial intelligence
  • Banking → banking
  • Biotechnology → biotechnology
  • Chemistry → chemistry
  • Drug Discovery → drug discovery
  • Environmental Sciences → environmental sciences
  • Machine Learning → machine learning
  • Molecular Biology → molecular biology
  • Structural Biology → structural biology

Files Changed by Category

  • Academic/Biology sources: multiple files (alphafold-db.json, ena.json, genbank.json, etc.)
  • Various other academic and research data sources
  • All changes are domain field updates only - no other modifications

🎯 Validation Results

✓ check_domains.py: All domain fields are consistent
✓ CI protect-schema: PASS
✓ CI validate: PASS

📝 Suggestions

None - This PR is ready to merge as-is. The changes are:

  • Mechanically correct
  • Fully compliant with project standards
  • Properly validated
  • Scope-limited and safe

Summary

Recommendation: ✅ APPROVE

This is a clean, well-executed refactoring PR that eliminates technical debt and improves data consistency. The changes are low-risk (standardization only), fully validated, and necessary for maintaining repository quality as it scales toward 1000+ data sources.

Great work on maintaining code quality! 🎉

@Leosgp Leosgp merged commit 99429fb into main Mar 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant