MeasuredPillarLayer::clone() missing -- measured conductance lost during IGU copy

[vidanovic]

Problem

MeasuredPillarLayer inherits from CIGUGapLayer but does not override clone(). The base CIGUGapLayer::clone() does:

std::shared_ptr<CBaseLayer> CIGUGapLayer::clone() const
{
    return std::make_shared<CIGUGapLayer>(*this);
}

This slices MeasuredPillarLayer to a plain CIGUGapLayer, losing:

• m_MeasuredConductance (the computed pillar conductance from cStar())
• The calculateConvectionOrConductionFlow() override

Impact

When CSingleSystem copies the IGU in its constructor, all layers are cloned. The measured pillar gap becomes a plain air gap at 0 pressure. The solver then computes thermal performance without the pillar conductance.

The NFRC102_NFRC102_VacuumMeasuredPillar test passes on main, but with values that correspond to a vacuum gap without pillar conductance (U-value ~2.06) rather than a gap with measured pillar conductance of 65.7 W/m²K (U-value ~5.34).

How to verify on main branch

Put a breakpoint in MeasuredPillarLayer::calculateConvectionOrConductionFlow() (SupportPillarMeasured.cpp line 53) and run the NFRC102_NFRC102_VacuumMeasuredPillar test. The breakpoint will never be hit during the solver iterations because the cloned layer in the solver's IGU is a CIGUGapLayer, not a MeasuredPillarLayer.

Related

Same category of inheritance/clone bug as #245 (environment surface disconnection during replaceLayer).

[vidanovic]

Fixed in Version 1.0.69

Root cause: MeasuredPillarLayer inherited CIGUGapLayer::clone() without overriding it. clone() creates make_shared<CIGUGapLayer>(*this) which slices the derived class, losing m_MeasuredConductance and the calculateConvectionOrConductionFlow() override. When CSingleSystem copies the IGU, the measured pillar gap becomes a plain air gap at 0 pressure.

Fix: Fold pillar data (both computed and measured conductance) directly into CIGUGapLayer via activatePillar() methods. The pillar state is now part of CIGUGapLayer itself, so the default copy constructor preserves it through clone(). PillarGapLayer and MeasuredPillarLayer subclasses are eliminated.

Test update: VacuumMeasuredPillar test values updated to reflect correct measured pillar behavior (U-value 5.34 W/m²K with 65.7 W/m²K pillar conductance, vs old incorrect 2.06 W/m²K from a plain vacuum gap).

Commit: 4370377 on branch TarcogRefactor.