Skip to content

Commit 3a8ef57

Browse files
committed
minor updates
1 parent f47d899 commit 3a8ef57

File tree

7 files changed

+13
-35
lines changed

7 files changed

+13
-35
lines changed

examples/src/main/java/com/javaaidev/agenticpatterns/examples/evaluatoroptimizer/CodeGenerationConfiguration.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,15 @@
1313
import java.util.Objects;
1414
import org.springframework.ai.chat.client.ChatClient;
1515
import org.springframework.ai.chat.client.advisor.SimpleLoggerAdvisor;
16+
import org.springframework.beans.factory.annotation.Qualifier;
1617
import org.springframework.context.annotation.Bean;
1718
import org.springframework.context.annotation.Configuration;
1819

1920
@Configuration
2021
public class CodeGenerationConfiguration {
2122

2223
@Bean
24+
@Qualifier("codeGenerationWorkflow")
2325
public EvaluatorOptimizerWorkflow<CodeGenerationRequest, CodeGenerationRequest, CodeGenerationResponse, BooleanEvaluationResult, CodeGenerationResponse> codeGenerationWorkflow(
2426
ChatClient.Builder chatClientBuilder,
2527
SimpleLoggerAdvisor simpleLoggerAdvisor,

examples/src/main/java/com/javaaidev/agenticpatterns/examples/evaluatoroptimizer/CodeGenerationController.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import com.javaaidev.agenticpatterns.evaluatoroptimizer.EvaluatorOptimizerWorkflow;
55
import com.javaaidev.agenticpatterns.examples.evaluatoroptimizer.CodeGenerationConfiguration.CodeGenerationRequest;
66
import com.javaaidev.agenticpatterns.examples.evaluatoroptimizer.CodeGenerationConfiguration.CodeGenerationResponse;
7+
import org.springframework.beans.factory.annotation.Qualifier;
78
import org.springframework.web.bind.annotation.PostMapping;
89
import org.springframework.web.bind.annotation.RequestBody;
910
import org.springframework.web.bind.annotation.RequestMapping;
@@ -16,7 +17,7 @@ public class CodeGenerationController {
1617
private final EvaluatorOptimizerWorkflow<CodeGenerationRequest, CodeGenerationRequest, CodeGenerationResponse, BooleanEvaluationResult, CodeGenerationResponse> evaluatorOptimizerWorkflow;
1718

1819
public CodeGenerationController(
19-
EvaluatorOptimizerWorkflow<CodeGenerationRequest, CodeGenerationRequest, CodeGenerationResponse, BooleanEvaluationResult, CodeGenerationResponse> codeGenerationAgent) {
20+
@Qualifier("codeGenerationWorkflow") EvaluatorOptimizerWorkflow<CodeGenerationRequest, CodeGenerationRequest, CodeGenerationResponse, BooleanEvaluationResult, CodeGenerationResponse> codeGenerationAgent) {
2021
this.evaluatorOptimizerWorkflow = codeGenerationAgent;
2122
}
2223

examples/src/main/java/com/javaaidev/agenticpatterns/examples/taskexecution/UserGenerationAgent.java

Lines changed: 0 additions & 25 deletions
This file was deleted.

examples/src/main/java/com/javaaidev/agenticpatterns/examples/taskexecution/UserGenerationAgentController.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.javaaidev.agenticpatterns.examples.taskexecution;
22

33
import com.javaaidev.agenticpatterns.taskexecution.TaskExecutionAgent;
4+
import org.springframework.beans.factory.annotation.Qualifier;
45
import org.springframework.web.bind.annotation.PostMapping;
56
import org.springframework.web.bind.annotation.RequestBody;
67
import org.springframework.web.bind.annotation.RequestMapping;
@@ -13,7 +14,7 @@ public class UserGenerationAgentController {
1314
private final TaskExecutionAgent<UserGenerationRequest, UserGenerationResponse> userGenerationAgent;
1415

1516
public UserGenerationAgentController(
16-
TaskExecutionAgent<UserGenerationRequest, UserGenerationResponse> userGenerationAgent) {
17+
@Qualifier("userGenerationAgent") TaskExecutionAgent<UserGenerationRequest, UserGenerationResponse> userGenerationAgent) {
1718
this.userGenerationAgent = userGenerationAgent;
1819
}
1920

patterns/chain-workflow/src/main/java/com/javaaidev/agenticpatterns/chainworkflow/ChainStepAgent.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import org.jspecify.annotations.Nullable;
1111
import org.springframework.ai.chat.client.ChatClient;
1212
import org.springframework.ai.chat.client.ChatClient.ChatClientRequestSpec;
13-
import org.springframework.core.Ordered;
1413
import org.springframework.util.Assert;
1514

1615
/**
@@ -21,7 +20,7 @@
2120
*/
2221
public abstract class ChainStepAgent<Request, Response> extends
2322
TaskExecutionAgent<Request, Response> implements
24-
Ordered, ChainStep<Request, Response> {
23+
ChainStep<Request, Response> {
2524

2625
protected ChainStepAgent(ChatClient chatClient,
2726
@Nullable ObservationRegistry observationRegistry) {

patterns/evaluator-optimizer/src/main/java/com/javaaidev/agenticpatterns/evaluatoroptimizer/EvaluatorOptimizerWorkflow.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,17 @@ public class EvaluatorOptimizerWorkflow<Request, GenInput, GenOutput, ER extends
3838
private final Predicate<ER> evaluationPredicate;
3939
private final int maxNumberOfEvaluations;
4040

41-
EvaluatorOptimizerWorkflow(InitializationStep<Request, GenInput> initializationStep,
41+
public EvaluatorOptimizerWorkflow(
42+
InitializationStep<Request, GenInput> initializationStep,
4243
InitialResultGenerationStep<GenInput, GenOutput> initialResultGenerationStep,
4344
@Nullable EvaluationStep<GenInput, GenOutput, ER> evaluationStep,
4445
@Nullable OptimizationStep<GenInput, GenOutput, ER> optimizationStep,
4546
FinalizationStep<Request, GenInput, GenOutput, Response> finalizationStep,
4647
Predicate<ER> evaluationPredicate,
4748
int maxNumberOfEvaluations,
48-
@Nullable String workflowName,
49+
@Nullable String name,
4950
@Nullable ObservationRegistry observationRegistry) {
50-
super(workflowName, observationRegistry);
51+
super(name, observationRegistry);
5152
this.initializationStep = initializationStep;
5253
this.initialResultGenerationStep = initialResultGenerationStep;
5354
this.evaluationStep = evaluationStep;

patterns/routing-workflow/src/main/java/com/javaaidev/agenticpatterns/routingworkflow/RoutingWorkflow.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
import org.springframework.util.Assert;
1414

1515
/**
16-
* Routing Workflow agent, refer to <a
16+
* Routing Workflow, refer to <a
1717
* href="https://javaaidev.com/docs/agentic-patterns/patterns/routing-workflow">doc</a>
1818
*
1919
* @param <Request> Type of workflow input
@@ -25,8 +25,7 @@ public class RoutingWorkflow<Request, Response> extends AbstractAgenticWorkflow<
2525
private final RoutingSelector<Request, Response> routingSelector;
2626

2727
private static final Logger LOGGER = LoggerFactory.getLogger(RoutingWorkflow.class);
28-
29-
28+
3029
public RoutingWorkflow(List<RoutingChoice<Request, Response>> routingChoices,
3130
RoutingSelector<Request, Response> routingSelector,
3231
@Nullable String name,

0 commit comments

Comments
 (0)