-
Notifications
You must be signed in to change notification settings - Fork 6.7k
debug: django e2e tests #13765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug: django e2e tests #13765
Changes from all commits
1aa18a6
9867982
4a56d72
f47239d
1c20c68
4cedf2f
5fe35c2
a1ec42c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| Django==5.2.9 | ||
| Django==6.0.1; python_version >= "3.12" | ||
| gunicorn==23.0.0 | ||
| psycopg2-binary==2.9.10 | ||
| psycopg2-binary==2.9.11 | ||
| django-environ==0.12.0 | ||
| google-cloud-secret-manager==2.21.1 | ||
| django-storages[google]==1.14.6 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| Django==5.2.9 | ||
| Django==6.0.1; python_version >= "3.12" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change limits Django installation to Python 3.12+, which breaks the sample for users on older Python versions. To ensure broader compatibility, please specify Django versions for older Python versions as well. |
||
| gunicorn==23.0.0 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,9 @@ | ||
| Django==5.2.9; python_version >= "3.10" | ||
| Django==4.2.24; python_version >= "3.8" and python_version < "3.10" | ||
| Django==6.0.1; python_version >= "3.12" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removing the Django version specifications for older Python versions (3.8-3.11) is a breaking change for users of this sample. Please restore compatibility for these versions. |
||
| # Uncomment the mysqlclient requirement if you are using MySQL rather than | ||
| # PostgreSQL. You must also have a MySQL client installed in that case. | ||
| #mysqlclient==1.4.1 | ||
| wheel==0.40.0 | ||
| gunicorn==23.0.0; python_version > '3.0' | ||
| gunicorn==23.0.0; python_version < '3.0' | ||
| # psycopg2==2.8.4 # uncomment if you prefer to build from source | ||
| psycopg2-binary==2.9.10 | ||
| psycopg2-binary==2.9.11 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| Django==5.2.5; python_version >= "3.10" | ||
| Django==4.2.24; python_version >= "3.8" and python_version < "3.10" | ||
| Django==6.0.1; python_version >= "3.12" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removing the Django version specifications for older Python versions (3.8-3.11) is a breaking change for users of this sample. Please restore compatibility for these versions. |
||
| django-storages[google]==1.14.6 | ||
| django-environ==0.12.0 | ||
| psycopg2-binary==2.9.10 | ||
| psycopg2-binary==2.9.11 | ||
| gunicorn==23.0.0 | ||
| google-cloud-secret-manager==2.21.1 | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change limits Django installation to Python 3.12+, which breaks the sample for users on older Python versions. To ensure broader compatibility, please specify Django versions for older Python versions as well.