Merge pull request #16 from FrameworkComputer/fix-disabling

Fix device cleanup to run on device disable

Author: JohnAZoidberg

FrameworkArgb/Device.c

@@ -319,6 +319,7 @@ Return Value:
     WdfFdoInitSetFilter(DeviceInit);
 
     WDF_OBJECT_ATTRIBUTES_INIT_CONTEXT_TYPE(&deviceAttributes, DEVICE_CONTEXT);
+    deviceAttributes.EvtCleanupCallback = FrameworkArgbEvtDeviceCleanup;
 
     status = WdfDeviceCreate(&DeviceInit, &deviceAttributes, &device);
 
@@ -740,3 +741,39 @@ Return Value:
 
     return status;
 }
+
+VOID
+FrameworkArgbEvtDeviceCleanup(
+    _In_ WDFOBJECT DeviceObject
+)
+/*++
+Routine Description:
+
+    Free all the resources allocated for the device.
+    Called when the device is removed or disabled.
+
+Arguments:
+
+    DeviceObject - handle to a WDF Device object.
+
+Return Value:
+
+    VOID.
+
+--*/
+{
+    PDEVICE_CONTEXT DeviceContext;
+
+    TraceInformation("%!FUNC! Entry");
+
+    DeviceContext = GetDeviceContext(DeviceObject);
+
+    // Close handle to EC driver
+    if (DeviceContext && DeviceContext->CrosEcHandle && DeviceContext->CrosEcHandle != INVALID_HANDLE_VALUE) {
+        CloseHandle(DeviceContext->CrosEcHandle);
+        DeviceContext->CrosEcHandle = INVALID_HANDLE_VALUE;
+        TraceInformation("%!FUNC! Closed CrosEc Handle");
+    }
+
+    TraceInformation("%!FUNC! Exit");
+}

FrameworkArgb/Device.h

@@ -32,6 +32,7 @@ typedef UCHAR HID_REPORT_DESCRIPTOR, * PHID_REPORT_DESCRIPTOR;
 DRIVER_INITIALIZE                   DriverEntry;
 EVT_WDF_DRIVER_DEVICE_ADD           EvtDeviceAdd;
 EVT_WDF_TIMER                       EvtTimerFunc;
+EVT_WDF_OBJECT_CONTEXT_CLEANUP      FrameworkArgbEvtDeviceCleanup;
 
 #define MAX_LAMPARRAY_LAMP_COUNT    256
 //#define LAMPARRAY_WIDTH             80000   // 80mm

FrameworkArgb/Driver.c

@@ -150,6 +150,8 @@ FrameworkArgbEvtDriverContextCleanup(
 Routine Description:
 
     Free all the resources allocated in DriverEntry.
+    Note: Device-specific cleanup (like EC handle) is done in
+    FrameworkArgbEvtDeviceCleanup, not here.
 
 Arguments:
 
@@ -161,19 +163,10 @@ Return Value:
 
 --*/
 {
-    PDEVICE_CONTEXT DeviceContext;
+    UNREFERENCED_PARAMETER(DriverObject);
 
     TraceInformation("%!FUNC! Entry");
 
-    DeviceContext = GetDeviceContext(DriverObject);
-    // Close handle to EC driver
-    if (DeviceContext && DeviceContext->CrosEcHandle && DeviceContext->CrosEcHandle != INVALID_HANDLE_VALUE) {
-        CloseHandle(DeviceContext->CrosEcHandle);
-        DeviceContext->CrosEcHandle = INVALID_HANDLE_VALUE;
-        TraceError("%!FUNC! Failed to close CrosEc Handle");
-    }
-    TraceInformation("%!FUNC! Closed CrosEc Handle");
-
     //
     // Stop WPP Tracing
     //
@@ -182,4 +175,6 @@ Return Value:
 #else
     WPP_CLEANUP(WdfDriverWdmGetDriverObject((WDFDRIVER)DriverObject));
 #endif
+
+    TraceInformation("%!FUNC! Exit");
 }