Skip to content

Commit 4aa392a

Browse files
committed
windows: Upload release binary
So that the vcruntime DLL is built in and runs on freshly installed windows systems. Signed-off-by: Daniel Schaefer <dhs@frame.work>
1 parent 64cc788 commit 4aa392a

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

.github/workflows/ci.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,20 +91,24 @@ jobs:
9191
- name: Setup Rust toolchain
9292
run: rustup show
9393

94+
# Build debug library first to fail fast
9495
- name: Build library (Windows)
9596
run: cargo build -p framework_lib --no-default-features --features "windows"
9697

9798
- name: Build Windows tool
98-
run: cargo build -p framework_tool --no-default-features --features "windows"
99+
run: |
100+
cargo build -p framework_tool --no-default-features --features "windows"
101+
cargo build -p framework_tool --no-default-features --features "windows" --release
99102
100103
- name: Check if Windows tool can start
101-
run: cargo run --no-default-features --features "windows" -- --help
104+
run: cargo run --no-default-features --features "windows" -- --help --release
102105

106+
# Upload release build so that vcruntime is statically linked
103107
- name: Upload Windows App
104108
uses: actions/upload-artifact@v4
105109
with:
106110
name: framework_tool.exe
107-
path: target/debug/framework_tool.exe
111+
path: target/release/framework_tool.exe
108112

109113

110114
test:

framework_tool/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,5 @@ path = "../framework_lib"
1414
default-features = false
1515

1616
[build-dependencies]
17+
# Note: Only takes effect in release builds
1718
static_vcruntime = "2.0"

0 commit comments

Comments
 (0)